From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> To: rjw@rjwysocki.net, lenb@kernel.org, hdegoede@redhat.com, tj@kernel.org, arnd@arndb.de, mjg59@srcf.ucam.org, grant.likely@linaro.org Cc: hanjun.guo@linaro.org, al.stone@linaro.org, graeme.gregory@linaro.org, leo.duran@amd.com, linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> Subject: [V2 PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching Date: Mon, 5 Jan 2015 15:11:15 -0600 [thread overview] Message-ID: <1420492275-6878-3-git-send-email-Suravee.Suthikulpanit@amd.com> (raw) In-Reply-To: <1420492275-6878-1-git-send-email-Suravee.Suthikulpanit@amd.com> This patch adds ACPI supports for AHCI platform driver, which uses _CLS method to match the device. The following is an example of ASL structure in DSDT for a SATA controller, which contains _CLS package to be matched by the ahci_platform driver: Device (AHC0) // AHCI Controller { Name(_HID, "AMDI0600") Name (_CCA, 1) Name (_CLS, Package (3) { 0x01, // Base Class: Mass Storage 0x06, // Sub-Class: serial ATA 0x01, // Interface: AHCI }) Name (_CRS, ResourceTemplate () { Memory32Fixed (ReadWrite, 0xE0300000, 0x00010000) Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive,,,) { 387 } }) } Also, since ATA driver should not require PCI support for ATA_ACPI, this patch removes dependency in the driver/ata/Kconfig. Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> --- drivers/ata/Kconfig | 2 +- drivers/ata/ahci_platform.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index a3a1360..edca892 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -48,7 +48,7 @@ config ATA_VERBOSE_ERROR config ATA_ACPI bool "ATA ACPI Support" - depends on ACPI && PCI + depends on ACPI default y help This option adds support for ATA-related ACPI objects. diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index 18d5398..ae66974 100644 --- a/drivers/ata/ahci_platform.c +++ b/drivers/ata/ahci_platform.c @@ -71,12 +71,15 @@ static const struct of_device_id ahci_of_match[] = { }; MODULE_DEVICE_TABLE(of, ahci_of_match); +static const struct acpi_device_cls ahci_cls = {0x01, 0x06, 0x01}; + static struct platform_driver ahci_driver = { .probe = ahci_probe, .remove = ata_platform_remove_one, .driver = { .name = "ahci", .of_match_table = ahci_of_match, + .acpi_match_cls = &ahci_cls, .pm = &ahci_pm_ops, }, }; -- 1.9.3
WARNING: multiple messages have this Message-ID (diff)
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> To: <rjw@rjwysocki.net>, <lenb@kernel.org>, <hdegoede@redhat.com>, <tj@kernel.org>, <arnd@arndb.de>, <mjg59@srcf.ucam.org>, <grant.likely@linaro.org> Cc: <hanjun.guo@linaro.org>, <al.stone@linaro.org>, <graeme.gregory@linaro.org>, <leo.duran@amd.com>, <linux-ide@vger.kernel.org>, <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linaro-acpi@lists.linaro.org>, "Suravee Suthikulpanit" <Suravee.Suthikulpanit@amd.com> Subject: [V2 PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching Date: Mon, 5 Jan 2015 15:11:15 -0600 [thread overview] Message-ID: <1420492275-6878-3-git-send-email-Suravee.Suthikulpanit@amd.com> (raw) In-Reply-To: <1420492275-6878-1-git-send-email-Suravee.Suthikulpanit@amd.com> This patch adds ACPI supports for AHCI platform driver, which uses _CLS method to match the device. The following is an example of ASL structure in DSDT for a SATA controller, which contains _CLS package to be matched by the ahci_platform driver: Device (AHC0) // AHCI Controller { Name(_HID, "AMDI0600") Name (_CCA, 1) Name (_CLS, Package (3) { 0x01, // Base Class: Mass Storage 0x06, // Sub-Class: serial ATA 0x01, // Interface: AHCI }) Name (_CRS, ResourceTemplate () { Memory32Fixed (ReadWrite, 0xE0300000, 0x00010000) Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive,,,) { 387 } }) } Also, since ATA driver should not require PCI support for ATA_ACPI, this patch removes dependency in the driver/ata/Kconfig. Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> --- drivers/ata/Kconfig | 2 +- drivers/ata/ahci_platform.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index a3a1360..edca892 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -48,7 +48,7 @@ config ATA_VERBOSE_ERROR config ATA_ACPI bool "ATA ACPI Support" - depends on ACPI && PCI + depends on ACPI default y help This option adds support for ATA-related ACPI objects. diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index 18d5398..ae66974 100644 --- a/drivers/ata/ahci_platform.c +++ b/drivers/ata/ahci_platform.c @@ -71,12 +71,15 @@ static const struct of_device_id ahci_of_match[] = { }; MODULE_DEVICE_TABLE(of, ahci_of_match); +static const struct acpi_device_cls ahci_cls = {0x01, 0x06, 0x01}; + static struct platform_driver ahci_driver = { .probe = ahci_probe, .remove = ata_platform_remove_one, .driver = { .name = "ahci", .of_match_table = ahci_of_match, + .acpi_match_cls = &ahci_cls, .pm = &ahci_pm_ops, }, }; -- 1.9.3
next prev parent reply other threads:[~2015-01-05 21:11 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-05 21:11 [V2 PATCH 0/2] Introduce ACPI support for ahci_platform driver Suravee Suthikulpanit 2015-01-05 21:11 ` Suravee Suthikulpanit 2015-01-05 21:11 ` [V2 PATCH 1/2] ACPI / scan: Add support for ACPI _CLS device matching Suravee Suthikulpanit 2015-01-05 21:11 ` Suravee Suthikulpanit 2015-01-21 22:40 ` Rafael J. Wysocki 2015-02-08 16:18 ` Suravee Suthikulpanit 2015-02-08 16:18 ` Suravee Suthikulpanit 2015-01-05 21:11 ` Suravee Suthikulpanit [this message] 2015-01-05 21:11 ` [V2 PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching Suravee Suthikulpanit 2015-01-05 23:24 ` [V2 PATCH 0/2] Introduce ACPI support for ahci_platform driver Rafael J. Wysocki 2015-01-07 21:40 ` Suravee Suthikulanit 2015-01-07 21:40 ` Suravee Suthikulanit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1420492275-6878-3-git-send-email-Suravee.Suthikulpanit@amd.com \ --to=suravee.suthikulpanit@amd.com \ --cc=al.stone@linaro.org \ --cc=arnd@arndb.de \ --cc=graeme.gregory@linaro.org \ --cc=grant.likely@linaro.org \ --cc=hanjun.guo@linaro.org \ --cc=hdegoede@redhat.com \ --cc=lenb@kernel.org \ --cc=leo.duran@amd.com \ --cc=linaro-acpi@lists.linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mjg59@srcf.ucam.org \ --cc=rjw@rjwysocki.net \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.