All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@imgtec.com>
To: <linux-mips@linux-mips.org>
Cc: Paul Burton <paul.burton@imgtec.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 10/36] MIPS: jz4740: remove non-DT interrupt controller init
Date: Sun, 18 Jan 2015 14:27:21 -0800	[thread overview]
Message-ID: <1421620067-23933-11-git-send-email-paul.burton@imgtec.com> (raw)
In-Reply-To: <1421620067-23933-1-git-send-email-paul.burton@imgtec.com>

The jz4740 now probes the interrupt controller using DT, so remove the
now dead non-DT init code.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
---
 arch/mips/include/asm/mach-jz4740/irq.h |  2 --
 arch/mips/jz4740/irq.c                  | 25 +++++++------------------
 2 files changed, 7 insertions(+), 20 deletions(-)

diff --git a/arch/mips/include/asm/mach-jz4740/irq.h b/arch/mips/include/asm/mach-jz4740/irq.h
index 5ce4302..df50736 100644
--- a/arch/mips/include/asm/mach-jz4740/irq.h
+++ b/arch/mips/include/asm/mach-jz4740/irq.h
@@ -54,6 +54,4 @@
 
 #define NR_IRQS (JZ4740_IRQ_ADC_BASE + 6)
 
-extern void __init jz4740_intc_init(void);
-
 #endif
diff --git a/arch/mips/jz4740/irq.c b/arch/mips/jz4740/irq.c
index a4f0a82..9a8bda3 100644
--- a/arch/mips/jz4740/irq.c
+++ b/arch/mips/jz4740/irq.c
@@ -77,10 +77,16 @@ static struct irqaction jz4740_cascade_action = {
 	.name = "JZ4740 cascade interrupt",
 };
 
-static void __init __jz4740_intc_init(int parent_irq)
+static int __init jz4740_intc_of_init(struct device_node *node,
+	struct device_node *parent)
 {
 	struct irq_chip_generic *gc;
 	struct irq_chip_type *ct;
+	int parent_irq;
+
+	parent_irq = irq_of_parse_and_map(node, 0);
+	if (!parent_irq)
+		return -EINVAL;
 
 	jz_intc_base = ioremap(JZ4740_INTC_BASE_ADDR, 0x14);
 
@@ -105,23 +111,6 @@ static void __init __jz4740_intc_init(int parent_irq)
 	irq_setup_generic_chip(gc, IRQ_MSK(32), 0, 0, IRQ_NOPROBE | IRQ_LEVEL);
 
 	setup_irq(parent_irq, &jz4740_cascade_action);
-}
-
-void __init jz4740_intc_init(void)
-{
-	__jz4740_intc_init(2);
-}
-
-static int __init jz4740_intc_of_init(struct device_node *node,
-	struct device_node *parent)
-{
-	int parent_irq;
-
-	parent_irq = irq_of_parse_and_map(node, 0);
-	if (!parent_irq)
-		return -EINVAL;
-
-	__jz4740_intc_init(parent_irq);
 	return 0;
 }
 IRQCHIP_DECLARE(jz4740_intc, "ingenic,jz4740-intc", jz4740_intc_of_init);
-- 
2.2.1

WARNING: multiple messages have this Message-ID (diff)
From: Paul Burton <paul.burton@imgtec.com>
To: linux-mips@linux-mips.org
Cc: Paul Burton <paul.burton@imgtec.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 10/36] MIPS: jz4740: remove non-DT interrupt controller init
Date: Sun, 18 Jan 2015 14:27:21 -0800	[thread overview]
Message-ID: <1421620067-23933-11-git-send-email-paul.burton@imgtec.com> (raw)
Message-ID: <20150118222721.Ot2wKZH1zH-0t3BuKmuxk95Fg4l1rf402juTL7HBcKs@z> (raw)
In-Reply-To: <1421620067-23933-1-git-send-email-paul.burton@imgtec.com>

The jz4740 now probes the interrupt controller using DT, so remove the
now dead non-DT init code.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
---
 arch/mips/include/asm/mach-jz4740/irq.h |  2 --
 arch/mips/jz4740/irq.c                  | 25 +++++++------------------
 2 files changed, 7 insertions(+), 20 deletions(-)

diff --git a/arch/mips/include/asm/mach-jz4740/irq.h b/arch/mips/include/asm/mach-jz4740/irq.h
index 5ce4302..df50736 100644
--- a/arch/mips/include/asm/mach-jz4740/irq.h
+++ b/arch/mips/include/asm/mach-jz4740/irq.h
@@ -54,6 +54,4 @@
 
 #define NR_IRQS (JZ4740_IRQ_ADC_BASE + 6)
 
-extern void __init jz4740_intc_init(void);
-
 #endif
diff --git a/arch/mips/jz4740/irq.c b/arch/mips/jz4740/irq.c
index a4f0a82..9a8bda3 100644
--- a/arch/mips/jz4740/irq.c
+++ b/arch/mips/jz4740/irq.c
@@ -77,10 +77,16 @@ static struct irqaction jz4740_cascade_action = {
 	.name = "JZ4740 cascade interrupt",
 };
 
-static void __init __jz4740_intc_init(int parent_irq)
+static int __init jz4740_intc_of_init(struct device_node *node,
+	struct device_node *parent)
 {
 	struct irq_chip_generic *gc;
 	struct irq_chip_type *ct;
+	int parent_irq;
+
+	parent_irq = irq_of_parse_and_map(node, 0);
+	if (!parent_irq)
+		return -EINVAL;
 
 	jz_intc_base = ioremap(JZ4740_INTC_BASE_ADDR, 0x14);
 
@@ -105,23 +111,6 @@ static void __init __jz4740_intc_init(int parent_irq)
 	irq_setup_generic_chip(gc, IRQ_MSK(32), 0, 0, IRQ_NOPROBE | IRQ_LEVEL);
 
 	setup_irq(parent_irq, &jz4740_cascade_action);
-}
-
-void __init jz4740_intc_init(void)
-{
-	__jz4740_intc_init(2);
-}
-
-static int __init jz4740_intc_of_init(struct device_node *node,
-	struct device_node *parent)
-{
-	int parent_irq;
-
-	parent_irq = irq_of_parse_and_map(node, 0);
-	if (!parent_irq)
-		return -EINVAL;
-
-	__jz4740_intc_init(parent_irq);
 	return 0;
 }
 IRQCHIP_DECLARE(jz4740_intc, "ingenic,jz4740-intc", jz4740_intc_of_init);
-- 
2.2.1

  parent reply	other threads:[~2015-01-18 22:32 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-18 22:27 [PATCH 00/36] jz4780 & CI20 support Paul Burton
2015-01-18 22:27 ` Paul Burton
2015-01-18 22:27 ` [PATCH 02/36] MIPS: jz4740: require & include DT Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 03/36] MIPS: irq_cpu: declare irqchip table entry Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 04/36] MIPS: jz4740: probe CPU interrupt controller via DT Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 05/36] MIPS: jz4740: use generic plat_irq_dispatch Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 06/36] MIPS: jz4740: move arch_init_irq out of arch/mips/jz4740/irq.c Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 08/36] MIPS: jz4740: allow interrupt controller probe via DT Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 09/36] MIPS: jz4740: probe interrupt controller " Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` Paul Burton [this message]
2015-01-18 22:27   ` [PATCH 10/36] MIPS: jz4740: remove non-DT interrupt controller init Paul Burton
2015-01-18 22:27 ` [PATCH 11/36] MIPS: jz4740: register an irq_domain for the interrupt controller Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 12/36] MIPS: jz4740: call jz4740_clock_init earlier Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 13/36] MIPS: jz4740: replace use of jz4740_clock_bdata Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:27 ` [PATCH 14/36] clk: jz47xx-cgu: add driver for Ingenic jz47xx series CGU clocks Paul Burton
2015-01-18 22:27   ` Paul Burton
2015-01-18 22:36 ` [PATCH 16/36] MIPS,clk: migrate jz4740 to common clock framework Paul Burton
2015-01-18 22:36   ` Paul Burton
2015-01-25 18:23   ` Lars-Peter Clausen
2015-01-18 22:39 ` [PATCH 17/36] MIPS,clk: move jz4740_clock_set_wait_mode to jz4740-cgu Paul Burton
2015-01-18 22:39   ` Paul Burton
2015-01-18 22:39 ` [PATCH 18/36] MIPS,clk: move jz4740 UDC auto suspend functions " Paul Burton
2015-01-18 22:39   ` Paul Burton
2015-01-18 22:39 ` [PATCH 19/36] MIPS,clk: move jz4740 clock suspend,resume " Paul Burton
2015-01-18 22:39   ` Paul Burton
2015-01-18 22:40 ` [PATCH 20/36] MIPS: jz4740: remove clock.h Paul Burton
2015-01-18 22:40   ` Paul Burton
2015-01-18 22:40 ` [PATCH 21/36] MIPS: jz4740: only detect RAM size if not specified in DT Paul Burton
2015-01-18 22:40   ` Paul Burton
2015-01-18 22:40 ` [PATCH 22/36] MIPS: jz4740: support >32 interrupts Paul Burton
2015-01-18 22:40   ` Paul Burton
2015-01-18 22:40 ` [PATCH 23/36] MIPS: jz4740: define IRQ numbers based on number of intc IRQs Paul Burton
2015-01-18 22:40   ` Paul Burton
2015-01-25 18:28   ` Lars-Peter Clausen
     [not found] ` <1421620067-23933-1-git-send-email-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2015-01-18 22:27   ` [PATCH 01/36] devicetree/bindings: add Ingenic Semiconductor vendor prefix Paul Burton
2015-01-18 22:27     ` Paul Burton
2015-01-18 22:27     ` Paul Burton
2015-01-18 22:27   ` [PATCH 07/36] devicetree: document ingenic,jz4740-intc binding Paul Burton
2015-01-18 22:27     ` Paul Burton
2015-01-18 22:27     ` Paul Burton
     [not found]     ` <1421620067-23933-8-git-send-email-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2015-01-19 11:54       ` Sergei Shtylyov
2015-01-19 11:54         ` Sergei Shtylyov
2015-01-18 22:27   ` [PATCH 15/36] devicetree: add ingenic,jz4740-cgu binding documentation Paul Burton
2015-01-18 22:27     ` Paul Burton
2015-01-18 22:27     ` Paul Burton
2015-01-18 22:40   ` [PATCH 24/36] devicetree: document ingenic,jz4740-uart binding Paul Burton
2015-01-18 22:40     ` Paul Burton
2015-01-18 22:40     ` Paul Burton
2015-01-18 22:41   ` [PATCH 25/36] devicetree: document ingenic,jz4780-uart binding Paul Burton
2015-01-18 22:41     ` Paul Burton
2015-01-18 22:41     ` Paul Burton
     [not found]     ` <1421620869-25063-1-git-send-email-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2015-01-25 18:17       ` Lars-Peter Clausen
2015-01-25 18:17         ` Lars-Peter Clausen
2015-01-18 22:41   ` [PATCH 29/36] devicetree: add ingenic,jz4780-cgu binding documentation Paul Burton
2015-01-18 22:41     ` Paul Burton
2015-01-18 22:41     ` Paul Burton
2015-01-18 22:42   ` [PATCH 31/36] devicetree: document ingenic,jz4780-intc binding Paul Burton
2015-01-18 22:42     ` Paul Burton
2015-01-18 22:42     ` Paul Burton
2015-01-19 12:08     ` Sergei Shtylyov
2015-01-25 18:15     ` Lars-Peter Clausen
2015-01-18 22:41 ` [PATCH 26/36] serial: 8250_jz47xx: support for Ingenic jz47xx UARTs Paul Burton
2015-01-18 22:41   ` Paul Burton
2015-01-30 23:31   ` Greg Kroah-Hartman
2015-02-02 16:28     ` Zubair Lutfullah Kakakhel
2015-02-02 16:28       ` Zubair Lutfullah Kakakhel
2015-02-02 16:32       ` Greg Kroah-Hartman
2015-01-18 22:41 ` [PATCH 27/36] MIPS: allow mach-provided serial.h Paul Burton
2015-01-18 22:41   ` Paul Burton
2015-01-18 22:41 ` [PATCH 28/36] MIPS: jz4740: use jz47xx-uart & DT for UART output Paul Burton
2015-01-18 22:41   ` Paul Burton
2015-01-25 18:13   ` Lars-Peter Clausen
2015-01-18 22:42 ` [PATCH 30/36] clk: add Ingenic jz4780 CGU driver Paul Burton
2015-01-18 22:42   ` Paul Burton
2015-01-18 22:42 ` [PATCH 32/36] MIPS: jz4740: add jz4780 interrupt controller support Paul Burton
2015-01-18 22:42   ` Paul Burton
2015-01-18 22:42 ` [PATCH 33/36] MIPS: add jz4780 Ingenic vendor ID Paul Burton
2015-01-18 22:42   ` Paul Burton
2015-01-18 22:42 ` [PATCH 34/36] MIPS: initial Ingenic jz4780 support Paul Burton
2015-01-18 22:42   ` Paul Burton
2015-01-18 22:43 ` [PATCH 35/36] MIPS: initial MIPS Creator CI20 board support Paul Burton
2015-01-18 22:43   ` Paul Burton
2015-01-21  9:44   ` James Hogan
2015-01-21  9:44     ` James Hogan
2015-01-18 22:43 ` [PATCH 36/36] MIPS: allow jz4780 to be selected in Kconfig Paul Burton
2015-01-18 22:43   ` Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421620067-23933-11-git-send-email-paul.burton@imgtec.com \
    --to=paul.burton@imgtec.com \
    --cc=lars@metafoo.de \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.