All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
	Rob Herring <robh@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
	Paul Mackerras <paulus@samba.org>, Joel Stanley <joel@jms.id.au>,
	Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
	Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	"open list:LINUX FOR POWERPC..." <linuxppc-dev@lists.ozlabs.org>,
	Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n
Date: Fri, 23 Jan 2015 15:13:05 +1100	[thread overview]
Message-ID: <1421986385.24984.11.camel@ellerman.id.au> (raw)
In-Reply-To: <CAJhHMCB+5Qkyfpkvrgi5+DVyc2O3HJ1VVmBXEs_ETw1rst0OZA@mail.gmail.com>

On Thu, 2015-01-22 at 23:03 -0500, Pranith Kumar wrote:
> On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith
> <stewart@linux.vnet.ibm.com> wrote:
> > Pranith Kumar <bobby.prani@gmail.com> writes:
> >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
> >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
> >>>> return 0. Check for these return values and skip registering the dump buffer.
> >>>>
> >>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> >>>> CC: Michael Ellerman <mpe@ellerman.id.au>
> >>>> ---
> >>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
> >>>>  1 file changed, 6 insertions(+)
> >>>
> >>> What changed since v1? I don't see anything?
> >>
> >> Nothing in this patch but there is a v2 of the first patch in this
> >> series, so had to resend this patch with a v2.

OK. You didn't send patch 1 to the this list though, so I only saw it on lkml.
Please don't do that in future.

> > You also missed my Reviewed-by :)
> 
> Sincere apologies for the oversight. Maintainers, could you please add
> this Reviewed-by tag when picking this up?
> 
> Reviewed-by: Stewart Smith <stewart@linux.vnet.ibm.com>

For future reference patchwork will catch these tags automatically. So if you
have forgotten to add them you can always reply to your own patch like you have
here and patchwork will detect them.

eg:

http://patchwork.ozlabs.org/patch/431648/mbox/

cheers



WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
	Rob Herring <robh@kernel.org>,
	Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
	open list <linux-kernel@vger.kernel.org>,
	Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
	Paul Mackerras <paulus@samba.org>, Joel Stanley <joel@jms.id.au>,
	Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	"open list:LINUX FOR POWERPC..." <linuxppc-dev@lists.ozlabs.org>,
	Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n
Date: Fri, 23 Jan 2015 15:13:05 +1100	[thread overview]
Message-ID: <1421986385.24984.11.camel@ellerman.id.au> (raw)
In-Reply-To: <CAJhHMCB+5Qkyfpkvrgi5+DVyc2O3HJ1VVmBXEs_ETw1rst0OZA@mail.gmail.com>

On Thu, 2015-01-22 at 23:03 -0500, Pranith Kumar wrote:
> On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith
> <stewart@linux.vnet.ibm.com> wrote:
> > Pranith Kumar <bobby.prani@gmail.com> writes:
> >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
> >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
> >>>> return 0. Check for these return values and skip registering the dump buffer.
> >>>>
> >>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> >>>> CC: Michael Ellerman <mpe@ellerman.id.au>
> >>>> ---
> >>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
> >>>>  1 file changed, 6 insertions(+)
> >>>
> >>> What changed since v1? I don't see anything?
> >>
> >> Nothing in this patch but there is a v2 of the first patch in this
> >> series, so had to resend this patch with a v2.

OK. You didn't send patch 1 to the this list though, so I only saw it on lkml.
Please don't do that in future.

> > You also missed my Reviewed-by :)
> 
> Sincere apologies for the oversight. Maintainers, could you please add
> this Reviewed-by tag when picking this up?
> 
> Reviewed-by: Stewart Smith <stewart@linux.vnet.ibm.com>

For future reference patchwork will catch these tags automatically. So if you
have forgotten to add them you can always reply to your own patch like you have
here and patchwork will detect them.

eg:

http://patchwork.ozlabs.org/patch/431648/mbox/

cheers

  reply	other threads:[~2015-01-23  4:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22  2:26 [PATCH v2 1/2] printk: Add dummy routine for when CONFIG_PRINTK=n Pranith Kumar
2015-01-22  2:26 ` [PATCH v2 2/2] powerpc/powernv: Skip registering log region " Pranith Kumar
2015-01-22  5:19   ` Michael Ellerman
2015-01-22  5:19     ` Michael Ellerman
2015-01-22 14:34     ` Pranith Kumar
2015-01-22 14:34       ` Pranith Kumar
2015-01-22 22:35       ` Stewart Smith
2015-01-22 22:35         ` Stewart Smith
2015-01-23  4:03         ` Pranith Kumar
2015-01-23  4:03           ` Pranith Kumar
2015-01-23  4:13           ` Michael Ellerman [this message]
2015-01-23  4:13             ` Michael Ellerman
2015-01-22 14:13 ` [PATCH v2 1/2] printk: Add dummy routine for " Petr Mladek
2015-01-22 14:17 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421986385.24984.11.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=anton@samba.org \
    --cc=bobby.prani@gmail.com \
    --cc=hegdevasant@linux.vnet.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=neelegup@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=robh@kernel.org \
    --cc=stewart@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.