All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pranavkumar Sawargaonkar <psawargaonkar@apm.com>
To: devicetree@vger.kernel.org
Cc: Feng Kan <fkan@apm.com>,
	arnd@arndb.de, marc.zyngier@arm.com, jcm@redhat.com,
	patches@apm.com, kvmarm@lists.cs.columbia.edu,
	christoffer.dall@linaro.org, Tushar Jagad <tjagad@apm.com>,
	Pranavkumar Sawargaonkar <psawargaonkar@apm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: Fix GIC reg sizes for APM X-Gene
Date: Tue, 27 Jan 2015 12:33:26 +0530	[thread overview]
Message-ID: <1422342206-4750-1-git-send-email-psawargaonkar@apm.com> (raw)

In APM X-Gene, GIC register space is 64K aligned while the sizes mentioned
in the dt are 4K aligned. This breaks KVM when kernel is built with 64K page
size due to size alignment checking in vgic driver for VCPU Control and
VCPU register.

This patch corrects the sizes to be inline with the hardware spec.

CC: linux-arm-kernel@lists.infradead.org
CC: kvmarm@lists.cs.columbia.edu
CC: arnd@arndb.de
CC: marc.zyngier@arm.com
CC: christoffer.dall@linaro.org
CC: jcm@redhat.com
Signed-off-by: Pranavkumar Sawargaonkar <psawargaonkar@apm.com>
Signed-off-by: Tushar Jagad <tjagad@apm.com>
Signed-off-by: Feng Kan <fkan@apm.com>
---
 arch/arm64/boot/dts/apm/apm-storm.dtsi |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index f1ad9c2..65f0e6d 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -81,10 +81,10 @@
 		compatible = "arm,cortex-a15-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
-		reg = <0x0 0x78010000 0x0 0x1000>,	/* GIC Dist */
-		      <0x0 0x78020000 0x0 0x1000>,	/* GIC CPU */
-		      <0x0 0x78040000 0x0 0x2000>,	/* GIC VCPU Control */
-		      <0x0 0x78060000 0x0 0x2000>;	/* GIC VCPU */
+		reg = <0x0 0x78010000 0x0 0x10000>,	/* GIC Dist */
+		      <0x0 0x78020000 0x0 0x20000>,	/* GIC CPU */
+		      <0x0 0x78040000 0x0 0x10000>,	/* GIC VCPU Control */
+		      <0x0 0x78060000 0x0 0x20000>;	/* GIC VCPU */
 		interrupts = <1 9 0xf04>;	/* GIC Maintenence IRQ */
 	};

--
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: psawargaonkar@apm.com (Pranavkumar Sawargaonkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: Fix GIC reg sizes for APM X-Gene
Date: Tue, 27 Jan 2015 12:33:26 +0530	[thread overview]
Message-ID: <1422342206-4750-1-git-send-email-psawargaonkar@apm.com> (raw)

In APM X-Gene, GIC register space is 64K aligned while the sizes mentioned
in the dt are 4K aligned. This breaks KVM when kernel is built with 64K page
size due to size alignment checking in vgic driver for VCPU Control and
VCPU register.

This patch corrects the sizes to be inline with the hardware spec.

CC: linux-arm-kernel at lists.infradead.org
CC: kvmarm at lists.cs.columbia.edu
CC: arnd at arndb.de
CC: marc.zyngier at arm.com
CC: christoffer.dall at linaro.org
CC: jcm at redhat.com
Signed-off-by: Pranavkumar Sawargaonkar <psawargaonkar@apm.com>
Signed-off-by: Tushar Jagad <tjagad@apm.com>
Signed-off-by: Feng Kan <fkan@apm.com>
---
 arch/arm64/boot/dts/apm/apm-storm.dtsi |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index f1ad9c2..65f0e6d 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -81,10 +81,10 @@
 		compatible = "arm,cortex-a15-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
-		reg = <0x0 0x78010000 0x0 0x1000>,	/* GIC Dist */
-		      <0x0 0x78020000 0x0 0x1000>,	/* GIC CPU */
-		      <0x0 0x78040000 0x0 0x2000>,	/* GIC VCPU Control */
-		      <0x0 0x78060000 0x0 0x2000>;	/* GIC VCPU */
+		reg = <0x0 0x78010000 0x0 0x10000>,	/* GIC Dist */
+		      <0x0 0x78020000 0x0 0x20000>,	/* GIC CPU */
+		      <0x0 0x78040000 0x0 0x10000>,	/* GIC VCPU Control */
+		      <0x0 0x78060000 0x0 0x20000>;	/* GIC VCPU */
 		interrupts = <1 9 0xf04>;	/* GIC Maintenence IRQ */
 	};

--
1.7.9.5

             reply	other threads:[~2015-01-27  7:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27  7:03 Pranavkumar Sawargaonkar [this message]
2015-01-27  7:03 ` [PATCH] arm64: dts: Fix GIC reg sizes for APM X-Gene Pranavkumar Sawargaonkar
2015-02-19 15:51 ` Christoffer Dall
2015-02-19 15:51   ` Christoffer Dall
     [not found] ` <1422342206-4750-1-git-send-email-psawargaonkar-qTEPVZfXA3Y@public.gmane.org>
2015-01-27  9:32   ` Jon Masters
2015-01-27  9:32     ` Jon Masters
2015-02-11  4:09     ` Pranavkumar Sawargaonkar
2015-02-11  4:09       ` Pranavkumar Sawargaonkar
2015-02-19 18:23   ` Rob Herring
2015-02-19 18:23     ` Rob Herring
     [not found]     ` <CAL_JsqJQcuX2cp50oHod-QAbhdMg48TaRP+gLGEO2kbFnQ3B+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-19 19:03       ` Christoffer Dall
2015-02-19 19:03         ` Christoffer Dall
2015-02-21 21:56         ` Rob Herring
2015-02-21 21:56           ` Rob Herring
     [not found]           ` <CAL_JsqLcBOC+AnVe7oATjg2g6Fz2vqwacu8QzS4tXMaxxOP_Xg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-21 23:58             ` Peter Maydell
2015-02-21 23:58               ` Peter Maydell
2015-02-23 12:07             ` Christoffer Dall
2015-02-23 12:07               ` Christoffer Dall
2015-02-23 12:24               ` Jon Masters
2015-02-23 12:24                 ` Jon Masters
2015-02-23 16:39               ` Rob Herring
2015-02-23 16:39                 ` Rob Herring
2015-02-24  6:34                 ` Pranavkumar Sawargaonkar
2015-02-24  6:34                   ` Pranavkumar Sawargaonkar
     [not found]                   ` <CANFfpkQF-8Kzq-UoP=xLpkTafGn6ScyiEb6oCs-Lxygb+ummLA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-24 14:30                     ` Rob Herring
2015-02-24 14:30                       ` Rob Herring
     [not found]                       ` <CAL_JsqLs4HdT6N=Vb4s--x3ugXKbWYQ5R2WGbiWFhhnYxnK-xw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-27  3:57                         ` Pranavkumar Sawargaonkar
2015-02-27  3:57                           ` Pranavkumar Sawargaonkar
2015-03-19 18:54                     ` Marc Zyngier
2015-03-19 18:54                       ` Marc Zyngier
2015-03-11 14:53   ` Marc Zyngier
2015-03-11 14:53     ` Marc Zyngier
     [not found]     ` <550056FD.8060804-5wv7dgnIgG8@public.gmane.org>
2015-03-11 17:19       ` Feng Kan
2015-03-11 17:19         ` Feng Kan
     [not found]         ` <CAL85gmCuB4LfNp+6B8cL9+emFqWPM6W9gevTzibyaAzL+7jVdg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-11 17:31           ` Marc Zyngier
2015-03-11 17:31             ` Marc Zyngier
2015-03-11 17:57             ` Feng Kan
2015-03-11 17:57               ` Feng Kan
     [not found]               ` <CAL85gmDVfop1_roHyLTRzFY3BahzTWs7nwbpmZD7emFKcFHyLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-11 18:17                 ` Marc Zyngier
2015-03-11 18:17                   ` Marc Zyngier
     [not found]                   ` <550086B9.4010001-5wv7dgnIgG8@public.gmane.org>
2015-03-12  3:52                     ` Pranavkumar Sawargaonkar
2015-03-12  3:52                       ` Pranavkumar Sawargaonkar
     [not found]                       ` <CANFfpkQ1QyWEGwwQx1g1By=uXvctJjF8AOO+uA5CFUgO4v9DFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-12  9:25                         ` Marc Zyngier
2015-03-12  9:25                           ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422342206-4750-1-git-send-email-psawargaonkar@apm.com \
    --to=psawargaonkar@apm.com \
    --cc=arnd@arndb.de \
    --cc=christoffer.dall@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fkan@apm.com \
    --cc=jcm@redhat.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=patches@apm.com \
    --cc=tjagad@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.