All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: rtl8723au: core: Add space after '>'
@ 2015-02-23 18:03 Hatice ERTÜRK
  2015-02-23 20:15 ` [Outreachy kernel] " Jes Sorensen
  0 siblings, 1 reply; 5+ messages in thread
From: Hatice ERTÜRK @ 2015-02-23 18:03 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Hatice ERTURK

This Error found with checkpatch.pl

ERROR: spaces required around that '>'

Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
index d851675..32fbf022 100644
--- a/drivers/staging/rtl8723au/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
@@ -1200,7 +1200,7 @@ int rtw_xmitframe_coalesce23a(struct rtw_adapter *padapter, struct sk_buff *skb,
 		pdata += mem_sz;
 		data_len -= mem_sz;
 
-		if ((pattrib->icv_len >0) && (pattrib->bswenc)) {
+		if ((pattrib->icv_len > 0) && (pattrib->bswenc)) {
 			memcpy(pframe, pattrib->icv, pattrib->icv_len);
 			pframe += pattrib->icv_len;
 		}
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: core: Add space after '>'
  2015-02-23 18:03 [PATCH] Staging: rtl8723au: core: Add space after '>' Hatice ERTÜRK
@ 2015-02-23 20:15 ` Jes Sorensen
  0 siblings, 0 replies; 5+ messages in thread
From: Jes Sorensen @ 2015-02-23 20:15 UTC (permalink / raw)
  To: Hatice ERTÜRK, outreachy-kernel

On 02/23/15 13:03, Hatice ERTÜRK wrote:
> This Error found with checkpatch.pl
> 
> ERROR: spaces required around that '>'
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
> index d851675..32fbf022 100644
> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
> @@ -1200,7 +1200,7 @@ int rtw_xmitframe_coalesce23a(struct rtw_adapter *padapter, struct sk_buff *skb,
>  		pdata += mem_sz;
>  		data_len -= mem_sz;
>  
> -		if ((pattrib->icv_len >0) && (pattrib->bswenc)) {
> +		if ((pattrib->icv_len > 0) && (pattrib->bswenc)) {

Please provide a personalized commit message, and you can also remove
the unnecessary parenthesis' here.

Cheers,
Jes


>  			memcpy(pframe, pattrib->icv, pattrib->icv_len);
>  			pframe += pattrib->icv_len;
>  		}
> 



^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] Staging: rtl8723au: core: Add space after '&'
@ 2015-02-23 15:53 Hatice ERTÜRK
  0 siblings, 0 replies; 5+ messages in thread
From: Hatice ERTÜRK @ 2015-02-23 15:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Hatice ERTURK

This Error found checkpatch.pl

ERROR: need consistent spacing around '&'

Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_xmit.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
index 7a5e6bf..2c9fe07 100644
--- a/drivers/staging/rtl8723au/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
@@ -255,7 +255,7 @@ static void update_attrib_vcs_info(struct rtw_adapter *padapter, struct xmit_fra
 		return;
 	}
 
-	if (!(psta->state &_FW_LINKED)) {
+	if (!(psta->state & _FW_LINKED)) {
 		DBG_8723A("%s, psta->state(0x%x) != _FW_LINKED\n", __func__, psta->state);
 		return;
 	}
@@ -661,7 +661,7 @@ static int xmitframe_addmic(struct rtw_adapter *padapter,
 		return _FAIL;
 	}
 
-	if (!(stainfo->state &_FW_LINKED)) {
+	if (!(stainfo->state & _FW_LINKED)) {
 		DBG_8723A("%s, psta->state(0x%x) != _FW_LINKED\n",
 			  __func__, stainfo->state);
 		return _FAIL;
@@ -874,7 +874,7 @@ static int rtw_make_wlanhdr(struct rtw_adapter *padapter, u8 *hdr,
 		return _FAIL;
 	}
 
-	if (!(psta->state &_FW_LINKED)) {
+	if (!(psta->state & _FW_LINKED)) {
 		DBG_8723A("%s, psta->state(0x%x) != _FW_LINKED\n", __func__, psta->state);
 		return _FAIL;
 	}
@@ -1012,7 +1012,7 @@ s32 rtw_txframes_sta_ac_pending23a(struct rtw_adapter *padapter,
 		DBG_8723A("%s, psta == NUL\n", __func__);
 		return 0;
 	}
-	if (!(psta->state &_FW_LINKED)) {
+	if (!(psta->state & _FW_LINKED)) {
 		DBG_8723A("%s, psta->state(0x%x) != _FW_LINKED\n", __func__,
 			  psta->state);
 		return 0;
@@ -1098,7 +1098,7 @@ int rtw_xmitframe_coalesce23a(struct rtw_adapter *padapter, struct sk_buff *skb,
 		return _FAIL;
 	}
 
-	if (!(psta->state &_FW_LINKED)) {
+	if (!(psta->state & _FW_LINKED)) {
 		DBG_8723A("%s, psta->state(0x%x) != _FW_LINKED\n",
 			  __func__, psta->state);
 		return _FAIL;
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] Staging: rtl8723au: core: Add space after '}'
@ 2015-02-22 19:09 Hatice ERTÜRK
  0 siblings, 0 replies; 5+ messages in thread
From: Hatice ERTÜRK @ 2015-02-22 19:09 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Hatice ERTURK

ERROR: space required after that close brace '}'
This Error found with checkpatch.pl

Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_efuse.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
index 94536da..108e67d 100644
--- a/drivers/staging/rtl8723au/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
@@ -307,7 +307,7 @@ EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)
 	}
 	else
 		return 0xFF;
-}/* EFUSE_Read1Byte23a */
+} /* EFUSE_Read1Byte23a */
 
 /*-----------------------------------------------------------------------------
  * Function:	EFUSE_Write1Byte
@@ -375,7 +375,7 @@ EFUSE_Write1Byte(
 			}
 		}
 	}
-}/* EFUSE_Write1Byte */
+} /* EFUSE_Write1Byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
 int
@@ -703,7 +703,7 @@ void EFUSE_ShadowMapUpdate23a(struct rtw_adapter *pAdapter, u8 efuseType)
 		Efuse_ReadAllMap(pAdapter, efuseType,
 				 pEEPROM->efuse_eeprom_data);
 
-}/*  EFUSE_ShadowMapUpdate23a */
+} /*  EFUSE_ShadowMapUpdate23a */
 
 /*-----------------------------------------------------------------------------
  * Function:	EFUSE_ShadowRead23a
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] Staging: rtl8723au: core: Add space after '&'
@ 2015-02-22 18:59 Hatice ERTÜRK
  0 siblings, 0 replies; 5+ messages in thread
From: Hatice ERTÜRK @ 2015-02-22 18:59 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Hatice ERTURK

This Error found checkpatch.pl

ERROR: need consistent spacing around '&'

Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_efuse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
index 0e64d12..94536da 100644
--- a/drivers/staging/rtl8723au/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
@@ -387,12 +387,12 @@ efuse_OneByteRead23a(struct rtw_adapter *pAdapter, u16 addr, u8 *data)
 	/*  -----------------e-fuse reg ctrl --------------------------------- */
 	/* address */
 	rtl8723au_write8(pAdapter, EFUSE_CTRL+1, (u8)(addr&0xff));
-	rtl8723au_write8(pAdapter, EFUSE_CTRL+2, ((u8)((addr>>8) &0x03)) |
+	rtl8723au_write8(pAdapter, EFUSE_CTRL+2, ((u8)((addr>>8) & 0x03)) |
 	(rtl8723au_read8(pAdapter, EFUSE_CTRL+2)&0xFC));
 
 	rtl8723au_write8(pAdapter, EFUSE_CTRL+3,  0x72);/* read cmd */
 
-	while(!(0x80 &rtl8723au_read8(pAdapter, EFUSE_CTRL+3)) && (tmpidx<100))
+	while(!(0x80 & rtl8723au_read8(pAdapter, EFUSE_CTRL+3)) && (tmpidx<100))
 		tmpidx++;
 	if (tmpidx < 100) {
 		*data = rtl8723au_read8(pAdapter, EFUSE_CTRL);
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-23 20:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-23 18:03 [PATCH] Staging: rtl8723au: core: Add space after '>' Hatice ERTÜRK
2015-02-23 20:15 ` [Outreachy kernel] " Jes Sorensen
  -- strict thread matches above, loose matches on Subject: below --
2015-02-23 15:53 [PATCH] Staging: rtl8723au: core: Add space after '&' Hatice ERTÜRK
2015-02-22 19:09 [PATCH] Staging: rtl8723au: core: Add space after '}' Hatice ERTÜRK
2015-02-22 18:59 [PATCH] Staging: rtl8723au: core: Add space after '&' Hatice ERTÜRK

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.