* [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
@ 2015-03-11 9:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2015-03-11 9:54 UTC (permalink / raw)
To: Kukjin Kim, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Sergei Shtylyov, Javier Martinez Canillas, Arnd Bergmann,
Olof Johansson, Krzysztof Kozlowski
The power domain nodes in DTS may be very generic (e.g. "power-domain"
for Exynos 5420) making it very hard to debug:
$ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
domain status slaves
power-domain on
Use platform device name instead so the names will be a little more user
friendly:
domain status slaves
100440e0.power-domain on
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
Notes:
Changes since v1:
1. Add Javier's reviewed-by.
arch/arm/mach-exynos/pm_domains.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
index 37266a826437..84e1d9f4d76c 100644
--- a/arch/arm/mach-exynos/pm_domains.c
+++ b/arch/arm/mach-exynos/pm_domains.c
@@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
return -ENOMEM;
}
- pd->pd.name = kstrdup(np->name, GFP_KERNEL);
+ pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
pd->name = pd->pd.name;
pd->base = of_iomap(np, 0);
pd->pd.power_off = exynos_pd_power_off;
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
@ 2015-03-11 9:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2015-03-11 9:54 UTC (permalink / raw)
To: linux-arm-kernel
The power domain nodes in DTS may be very generic (e.g. "power-domain"
for Exynos 5420) making it very hard to debug:
$ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
domain status slaves
power-domain on
Use platform device name instead so the names will be a little more user
friendly:
domain status slaves
100440e0.power-domain on
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
Notes:
Changes since v1:
1. Add Javier's reviewed-by.
arch/arm/mach-exynos/pm_domains.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
index 37266a826437..84e1d9f4d76c 100644
--- a/arch/arm/mach-exynos/pm_domains.c
+++ b/arch/arm/mach-exynos/pm_domains.c
@@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
return -ENOMEM;
}
- pd->pd.name = kstrdup(np->name, GFP_KERNEL);
+ pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
pd->name = pd->pd.name;
pd->base = of_iomap(np, 0);
pd->pd.power_off = exynos_pd_power_off;
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
2015-03-11 9:54 ` Krzysztof Kozlowski
@ 2015-03-11 9:56 ` Chanwoo Choi
-1 siblings, 0 replies; 8+ messages in thread
From: Chanwoo Choi @ 2015-03-11 9:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kukjin Kim, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Sergei Shtylyov, Javier Martinez Canillas, Arnd Bergmann,
Olof Johansson
On 03/11/2015 06:54 PM, Krzysztof Kozlowski wrote:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Notes:
> Changes since v1:
> 1. Add Javier's reviewed-by.
>
> arch/arm/mach-exynos/pm_domains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
> index 37266a826437..84e1d9f4d76c 100644
> --- a/arch/arm/mach-exynos/pm_domains.c
> +++ b/arch/arm/mach-exynos/pm_domains.c
> @@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
> return -ENOMEM;
> }
>
> - pd->pd.name = kstrdup(np->name, GFP_KERNEL);
> + pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
> pd->name = pd->pd.name;
> pd->base = of_iomap(np, 0);
> pd->pd.power_off = exynos_pd_power_off;
>
Looks good to me. This patch is very useful for debug.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
@ 2015-03-11 9:56 ` Chanwoo Choi
0 siblings, 0 replies; 8+ messages in thread
From: Chanwoo Choi @ 2015-03-11 9:56 UTC (permalink / raw)
To: linux-arm-kernel
On 03/11/2015 06:54 PM, Krzysztof Kozlowski wrote:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Notes:
> Changes since v1:
> 1. Add Javier's reviewed-by.
>
> arch/arm/mach-exynos/pm_domains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
> index 37266a826437..84e1d9f4d76c 100644
> --- a/arch/arm/mach-exynos/pm_domains.c
> +++ b/arch/arm/mach-exynos/pm_domains.c
> @@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
> return -ENOMEM;
> }
>
> - pd->pd.name = kstrdup(np->name, GFP_KERNEL);
> + pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
> pd->name = pd->pd.name;
> pd->base = of_iomap(np, 0);
> pd->pd.power_off = exynos_pd_power_off;
>
Looks good to me. This patch is very useful for debug.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
2015-03-11 9:54 ` Krzysztof Kozlowski
@ 2015-03-11 17:15 ` Kevin Hilman
-1 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2015-03-11 17:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kukjin Kim, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Sergei Shtylyov, Javier Martinez Canillas, Arnd Bergmann,
Olof Johansson
Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Kevin Hilman <khilman@linaro.org>
I still think we need some more detail as wel, but this is a good step
in the right direction.
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
@ 2015-03-11 17:15 ` Kevin Hilman
0 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2015-03-11 17:15 UTC (permalink / raw)
To: linux-arm-kernel
Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Kevin Hilman <khilman@linaro.org>
I still think we need some more detail as wel, but this is a good step
in the right direction.
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
2015-03-11 17:15 ` Kevin Hilman
@ 2015-03-17 17:19 ` Kukjin Kim
-1 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2015-03-17 17:19 UTC (permalink / raw)
To: Kevin Hilman
Cc: Krzysztof Kozlowski, Kukjin Kim, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Sergei Shtylyov,
Javier Martinez Canillas, Arnd Bergmann, Olof Johansson
On 03/12/15 02:15, Kevin Hilman wrote:
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
>
>> The power domain nodes in DTS may be very generic (e.g. "power-domain"
>> for Exynos 5420) making it very hard to debug:
>>
>> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
>> domain status slaves
>> power-domain on
>>
>> Use platform device name instead so the names will be a little more user
>> friendly:
>> domain status slaves
>> 100440e0.power-domain on
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Reviewed-by: Kevin Hilman <khilman@linaro.org>
>
> I still think we need some more detail as wel, but this is a good step
> in the right direction.
>
Thanks, applied.
- Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
@ 2015-03-17 17:19 ` Kukjin Kim
0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2015-03-17 17:19 UTC (permalink / raw)
To: linux-arm-kernel
On 03/12/15 02:15, Kevin Hilman wrote:
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
>
>> The power domain nodes in DTS may be very generic (e.g. "power-domain"
>> for Exynos 5420) making it very hard to debug:
>>
>> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
>> domain status slaves
>> power-domain on
>>
>> Use platform device name instead so the names will be a little more user
>> friendly:
>> domain status slaves
>> 100440e0.power-domain on
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Reviewed-by: Kevin Hilman <khilman@linaro.org>
>
> I still think we need some more detail as wel, but this is a good step
> in the right direction.
>
Thanks, applied.
- Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-17 17:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-11 9:54 [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name Krzysztof Kozlowski
2015-03-11 9:54 ` Krzysztof Kozlowski
2015-03-11 9:56 ` Chanwoo Choi
2015-03-11 9:56 ` Chanwoo Choi
2015-03-11 17:15 ` Kevin Hilman
2015-03-11 17:15 ` Kevin Hilman
2015-03-17 17:19 ` Kukjin Kim
2015-03-17 17:19 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.