All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/7] drm/i915: PSR: Remove wrong LINK_DISABLE.
@ 2015-02-28  1:26 Rodrigo Vivi
  2015-02-28  1:26 ` [PATCH 2/7] drm/i915: PSR: Fix DP_PSR_NO_TRAIN_ON_EXIT logic Rodrigo Vivi
                   ` (8 more replies)
  0 siblings, 9 replies; 46+ messages in thread
From: Rodrigo Vivi @ 2015-02-28  1:26 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

This wrong logic and useless define came from first versions and
came along with all rework. Just now I notice how ugly, wrong and
useless this is.

val is already defined as 0 anyway and logic is completelly wrong
and useless. So let's starting the link_standby fix with this
cleaning.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h  | 1 -
 drivers/gpu/drm/i915/intel_psr.c | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 55143cb..b95554d 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -2658,7 +2658,6 @@ enum skl_disp_power_wells {
 #define EDP_PSR_CTL(dev)			(EDP_PSR_BASE(dev) + 0)
 #define   EDP_PSR_ENABLE			(1<<31)
 #define   BDW_PSR_SINGLE_FRAME			(1<<30)
-#define   EDP_PSR_LINK_DISABLE			(0<<27)
 #define   EDP_PSR_LINK_STANDBY			(1<<27)
 #define   EDP_PSR_MIN_LINK_ENTRY_TIME_MASK	(3<<25)
 #define   EDP_PSR_MIN_LINK_ENTRY_TIME_8_LINES	(0<<25)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index b9f40c2..2e6831d 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -247,8 +247,7 @@ static void hsw_psr_enable_source(struct intel_dp *intel_dp)
 		val |= EDP_PSR_TP2_TP3_TIME_0us;
 		val |= EDP_PSR_TP1_TIME_0us;
 		val |= EDP_PSR_SKIP_AUX_EXIT;
-	} else
-		val |= EDP_PSR_LINK_DISABLE;
+	}
 
 	I915_WRITE(EDP_PSR_CTL(dev), val |
 		   (IS_BROADWELL(dev) ? 0 : link_entry_time) |
-- 
1.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 46+ messages in thread

end of thread, other threads:[~2015-04-14 13:18 UTC | newest]

Thread overview: 46+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-28  1:26 [PATCH 1/7] drm/i915: PSR: Remove wrong LINK_DISABLE Rodrigo Vivi
2015-02-28  1:26 ` [PATCH 2/7] drm/i915: PSR: Fix DP_PSR_NO_TRAIN_ON_EXIT logic Rodrigo Vivi
2015-03-16  5:24   ` R, Durgadoss
2015-03-16 17:35     ` [PATCH] " Rodrigo Vivi
2015-03-16 23:36       ` shuang.he
2015-03-24 15:29       ` Rodrigo Vivi
2015-03-25  0:39         ` Runyan, Arthur J
2015-04-10 18:10           ` Rodrigo Vivi
2015-04-11  1:22             ` shuang.he
2015-04-14 13:18             ` R, Durgadoss
2015-02-28  1:26 ` [PATCH 3/7] drm/i915: PSR: deprecate link_standby support for core platforms Rodrigo Vivi
2015-03-02 11:41   ` Jindal, Sonika
2015-03-02 20:27     ` Rodrigo Vivi
2015-03-16  5:28   ` R, Durgadoss
2015-03-16 17:37     ` [PATCH] " Rodrigo Vivi
2015-03-16 17:38     ` Rodrigo Vivi
2015-02-28  1:26 ` [PATCH 4/7] drm/i915: PSR VLV: Add single frame update Rodrigo Vivi
2015-03-05  2:48   ` Pandiyan, Dhinakaran
2015-02-28  1:26 ` [PATCH 5/7] drm/i915: Make sure we invalidate frontbuffer on fbcon Rodrigo Vivi
2015-03-02 17:59   ` Daniel Vetter
2015-03-02 18:35     ` Vivi, Rodrigo
2015-03-03  8:28       ` Daniel Vetter
2015-03-03 20:03         ` Vivi, Rodrigo
2015-03-04 14:30           ` Daniel Vetter
2015-03-04 23:05             ` Rodrigo Vivi
2015-03-05 12:06               ` Daniel Vetter
2015-03-10  0:57                 ` [PATCH] " Rodrigo Vivi
2015-03-10 10:08                   ` shuang.he
2015-03-10 10:23                   ` Daniel Vetter
2015-02-28  1:26 ` [PATCH 6/7] drm/i915: VLV/CHV PSR: Increase wait delay time before active PSR Rodrigo Vivi
2015-03-16  5:15   ` R, Durgadoss
2015-02-28  1:26 ` [PATCH 7/7] drm/i915: Enable PSR by default Rodrigo Vivi
2015-03-03  9:54   ` shuang.he
2015-03-16  5:31   ` R, Durgadoss
2015-03-23 20:20     ` Rodrigo Vivi
2015-03-24 10:03       ` Daniel Vetter
2015-03-24 10:08         ` Chris Wilson
2015-03-24 20:55           ` Vivi, Rodrigo
2015-03-24 22:05             ` chris
2015-03-25 13:53               ` Daniel Vetter
2015-03-25 19:27               ` Vivi, Rodrigo
2015-03-25 19:40                 ` chris
2015-03-02 17:56 ` [PATCH 1/7] drm/i915: PSR: Remove wrong LINK_DISABLE Daniel Vetter
2015-03-16  5:15 ` R, Durgadoss
2015-04-09 17:42 ` Matthew Garrett
2015-04-13 23:11   ` Rodrigo Vivi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.