* [PATCH iproute2] bridge: drop reference to unused option embedded from manpage
@ 2015-03-17 15:34 Andy Gospodarek
2015-03-18 0:52 ` Toshiaki Makita
0 siblings, 1 reply; 4+ messages in thread
From: Andy Gospodarek @ 2015-03-17 15:34 UTC (permalink / raw)
To: netdev; +Cc: John Fastabend
While looking at the manpage, I noticed a reference to 'embedded' that was
added by this commit:
commit d611682a8c8f28205158e6d3a7d5e2d01db022cc
Author: John Fastabend <john.r.fastabend@intel.com>
Date: Thu Sep 13 23:50:36 2012 -0700
iproute2: bridge: finish removing replace option in man pages
I no longer see any reference to the 'embedded' option in any c- or h-files, so
it seems worthwhile to remove.
Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
CC: John Fastabend <john.r.fastabend@intel.com>
---
man/man8/bridge.8 | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index 2005b9f..1855041 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -54,7 +54,7 @@ bridge \- show / manipulate bridge addresses and devices
.B dev
.IR DEV " { "
.BR local " | " temp " } { "
-.BR self " } { " embedded " } { " router " } [ "
+.BR self " } { " router " } [ "
.B dst
.IR IPADDR " ] [ "
.B vni
@@ -326,10 +326,6 @@ the interface to which this address is associated.
- the address is associated with a software fdb (default)
.sp
-.B embedded
-- the address is associated with an offloaded fdb
-.sp
-
.B router
- the destination address is associated with a router.
Valid if the referenced device is a VXLAN type device and has
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH iproute2] bridge: drop reference to unused option embedded from manpage
2015-03-17 15:34 [PATCH iproute2] bridge: drop reference to unused option embedded from manpage Andy Gospodarek
@ 2015-03-18 0:52 ` Toshiaki Makita
2015-03-19 16:14 ` Andy Gospodarek
0 siblings, 1 reply; 4+ messages in thread
From: Toshiaki Makita @ 2015-03-18 0:52 UTC (permalink / raw)
To: Andy Gospodarek, netdev; +Cc: John Fastabend
On 2015/03/18 0:34, Andy Gospodarek wrote:
> While looking at the manpage, I noticed a reference to 'embedded' that was
> added by this commit:
>
> commit d611682a8c8f28205158e6d3a7d5e2d01db022cc
> Author: John Fastabend <john.r.fastabend@intel.com>
> Date: Thu Sep 13 23:50:36 2012 -0700
>
> iproute2: bridge: finish removing replace option in man pages
>
> I no longer see any reference to the 'embedded' option in any c- or h-files, so
> it seems worthwhile to remove.
Actually, in addition, "master" option is missing.
Also, the current explanation of "self" looks incorrect and appropriate
for "master".
I wondered if you could fix them together with this... or I will do later.
Thanks,
Toshiaki Makita
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH iproute2] bridge: drop reference to unused option embedded from manpage
2015-03-18 0:52 ` Toshiaki Makita
@ 2015-03-19 16:14 ` Andy Gospodarek
2015-03-24 21:55 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: Andy Gospodarek @ 2015-03-19 16:14 UTC (permalink / raw)
To: Toshiaki Makita; +Cc: netdev, John Fastabend
On Wed, Mar 18, 2015 at 09:52:11AM +0900, Toshiaki Makita wrote:
> On 2015/03/18 0:34, Andy Gospodarek wrote:
> > While looking at the manpage, I noticed a reference to 'embedded' that was
> > added by this commit:
> >
> > commit d611682a8c8f28205158e6d3a7d5e2d01db022cc
> > Author: John Fastabend <john.r.fastabend@intel.com>
> > Date: Thu Sep 13 23:50:36 2012 -0700
> >
> > iproute2: bridge: finish removing replace option in man pages
> >
> > I no longer see any reference to the 'embedded' option in any c- or h-files, so
> > it seems worthwhile to remove.
>
> Actually, in addition, "master" option is missing.
> Also, the current explanation of "self" looks incorrect and appropriate
> for "master".
>
> I wondered if you could fix them together with this... or I will do later.
>
Good idea, but I would prefer the suggested change as another patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH iproute2] bridge: drop reference to unused option embedded from manpage
2015-03-19 16:14 ` Andy Gospodarek
@ 2015-03-24 21:55 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2015-03-24 21:55 UTC (permalink / raw)
To: Andy Gospodarek; +Cc: Toshiaki Makita, netdev, John Fastabend
On Thu, 19 Mar 2015 12:14:22 -0400
Andy Gospodarek <gospo@cumulusnetworks.com> wrote:
> On Wed, Mar 18, 2015 at 09:52:11AM +0900, Toshiaki Makita wrote:
> > On 2015/03/18 0:34, Andy Gospodarek wrote:
> > > While looking at the manpage, I noticed a reference to 'embedded' that was
> > > added by this commit:
> > >
> > > commit d611682a8c8f28205158e6d3a7d5e2d01db022cc
> > > Author: John Fastabend <john.r.fastabend@intel.com>
> > > Date: Thu Sep 13 23:50:36 2012 -0700
> > >
> > > iproute2: bridge: finish removing replace option in man pages
> > >
> > > I no longer see any reference to the 'embedded' option in any c- or h-files, so
> > > it seems worthwhile to remove.
> >
> > Actually, in addition, "master" option is missing.
> > Also, the current explanation of "self" looks incorrect and appropriate
> > for "master".
> >
> > I wondered if you could fix them together with this... or I will do later.
> >
>
> Good idea, but I would prefer the suggested change as another patch.
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
I applied this patch, feel free to do more cleanups in later patches.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-24 21:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-17 15:34 [PATCH iproute2] bridge: drop reference to unused option embedded from manpage Andy Gospodarek
2015-03-18 0:52 ` Toshiaki Makita
2015-03-19 16:14 ` Andy Gospodarek
2015-03-24 21:55 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.