All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xen.org
Cc: Olaf Hering <olaf@aepfle.de>, Keir Fraser <keir@xen.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string
Date: Fri, 20 Mar 2015 18:24:38 +0100	[thread overview]
Message-ID: <1426872279-5001-5-git-send-email-olaf@aepfle.de> (raw)
In-Reply-To: <1426872279-5001-1-git-send-email-olaf@aepfle.de>

To allow reproducible builds of hvmloader introduce a make variable
SMBIOS_REL_DATE=mm/dd/yyyy to provide a fixed date string. Without this
change the hvmloader binary changes with every rebuild.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Keir Fraser <keir@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 INSTALL                           | 1 +
 tools/firmware/hvmloader/Makefile | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/INSTALL b/INSTALL
index eac34b4..198cb9d 100644
--- a/INSTALL
+++ b/INSTALL
@@ -214,6 +214,7 @@ into the binaries. To allow reproducible builds the following variables
 can be used to provide fixed timestamps in the expected format.
 XEN_BUILD_DATE=any
 XEN_BUILD_TIME=hh:mm:ss
+SMBIOS_REL_DATE=mm/dd/yyyy
 
 The following variables can be used to tweak some aspects of the
 hypervisor build.
diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile
index cf967fd..34008d2 100644
--- a/tools/firmware/hvmloader/Makefile
+++ b/tools/firmware/hvmloader/Makefile
@@ -26,6 +26,9 @@ SUBDIRS := acpi
 # The HVM loader is started in 32-bit mode at the address below:
 LOADADDR = 0x100000
 
+# SMBIOS spec requires format mm/dd/yyyy
+SMBIOS_REL_DATE ?= $(shell date +%m/%d/%Y)
+
 CFLAGS += $(CFLAGS_xeninclude)
 
 OBJS  = hvmloader.o mp_tables.o util.o smbios.o 
@@ -88,7 +91,7 @@ all: subdirs-all
 	$(MAKE) hvmloader
 
 ovmf.o rombios.o seabios.o hvmloader.o: roms.inc
-smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(shell date +%m/%d/%Y)\""
+smbios.o: CFLAGS += -D__SMBIOS_DATE__="$(SMBIOS_REL_DATE)"
 
 hvmloader: $(OBJS) acpi/acpi.a
 	$(LD) $(LDFLAGS_DIRECT) -N -Ttext $(LOADADDR) -o hvmloader.tmp $^

  parent reply	other threads:[~2015-03-20 17:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 17:24 [PATCH 0/5] tools: various changes Olaf Hering
2015-03-20 17:24 ` [PATCH 1/5] tools/mkrpm: improve version.release handling Olaf Hering
2015-03-23 16:15   ` George Dunlap
2015-03-23 17:05     ` Olaf Hering
2015-03-23 17:52     ` Olaf Hering
2015-03-23 18:07       ` George Dunlap
2015-03-23 18:49         ` Olaf Hering
2015-03-23 19:00           ` George Dunlap
2015-03-24 12:15             ` Olaf Hering
2015-03-20 17:24 ` [PATCH 2/5] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file Olaf Hering
2015-03-24 15:53   ` Ian Campbell
2015-03-20 17:24 ` [PATCH 3/5] INSTALL: mention variables for reproducible builds Olaf Hering
2015-03-24 15:55   ` Ian Campbell
2015-03-25  8:49     ` Olaf Hering
2015-03-25 10:55       ` Ian Campbell
2015-03-20 17:24 ` Olaf Hering [this message]
2015-03-23  8:36   ` [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string Jan Beulich
2015-03-23  9:15     ` Olaf Hering
2015-03-23 12:24       ` Jan Beulich
2015-03-23 12:25   ` Jan Beulich
2015-03-20 17:24 ` [PATCH 5/5] hvmloader: add knob for fixed VGABIOS " Olaf Hering
2015-03-24 15:57   ` Ian Campbell
2015-03-25  8:46     ` Olaf Hering
2015-03-25 10:55       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426872279-5001-5-git-send-email-olaf@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.