Re: [PATCH 1/5] tools/mkrpm: improve version.release handling

From: George Dunlap <George.Dunlap@eu.citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 1/5] tools/mkrpm: improve version.release handling
Date: Mon, 23 Mar 2015 18:07:10 +0000	[thread overview]
Message-ID: <CAFLBxZbKuUCk7u-_0J=Amn301myNjUzYRG6y15Fk_fH3tCj=8g@mail.gmail.com> (raw)
In-Reply-To: <20150323175232.GA13774@aepfle.de>

On Mon, Mar 23, 2015 at 5:52 PM, Olaf Hering <olaf@aepfle.de> wrote:
> On Mon, Mar 23, George Dunlap wrote:
>
>> xen-4.6_unstable-20150323160547.x86_64.rpm
>
> Do you want to continue to get "unstable" as release?
> My patch uses everything passed as "$2" as Version string. I think thats
> ok.

I think "unstable" (or "pre" for the stable branches) should
definitely be in there to distinguish it from an actual release.  If I
were writing the patch I might consider taking out the _ (i.e., s/-//;
instead of s/-/_/;) but that's not a big deal.

> Release will be either 0 or $PKG_DATE.

You mean, "0 or $PKG_RELEASE"?  I had in mind that someone might want
to either set their own package release manually (PKG_RELEASE="9"), or
do PKG_RELEASE="$(git log RELEASE-4.5.0.. | wc -l)"

Thanks,
 -George