All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string
Date: Mon, 23 Mar 2015 08:36:50 +0000	[thread overview]
Message-ID: <550FDEB2020000780006C785@mail.emea.novell.com> (raw)
In-Reply-To: <1426872279-5001-5-git-send-email-olaf@aepfle.de>

>>> On 20.03.15 at 18:24, <olaf@aepfle.de> wrote:
> To allow reproducible builds of hvmloader introduce a make variable
> SMBIOS_REL_DATE=mm/dd/yyyy to provide a fixed date string. Without this
> change the hvmloader binary changes with every rebuild.

I don't really object to this change, but didn't we discuss using
smbios.c's time stamp instead, which then would properly reflect
eventual changes during incremental builds along with producing
unchanged output when there hasn't been any change?

Jan

  reply	other threads:[~2015-03-23  8:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 17:24 [PATCH 0/5] tools: various changes Olaf Hering
2015-03-20 17:24 ` [PATCH 1/5] tools/mkrpm: improve version.release handling Olaf Hering
2015-03-23 16:15   ` George Dunlap
2015-03-23 17:05     ` Olaf Hering
2015-03-23 17:52     ` Olaf Hering
2015-03-23 18:07       ` George Dunlap
2015-03-23 18:49         ` Olaf Hering
2015-03-23 19:00           ` George Dunlap
2015-03-24 12:15             ` Olaf Hering
2015-03-20 17:24 ` [PATCH 2/5] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file Olaf Hering
2015-03-24 15:53   ` Ian Campbell
2015-03-20 17:24 ` [PATCH 3/5] INSTALL: mention variables for reproducible builds Olaf Hering
2015-03-24 15:55   ` Ian Campbell
2015-03-25  8:49     ` Olaf Hering
2015-03-25 10:55       ` Ian Campbell
2015-03-20 17:24 ` [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string Olaf Hering
2015-03-23  8:36   ` Jan Beulich [this message]
2015-03-23  9:15     ` Olaf Hering
2015-03-23 12:24       ` Jan Beulich
2015-03-23 12:25   ` Jan Beulich
2015-03-20 17:24 ` [PATCH 5/5] hvmloader: add knob for fixed VGABIOS " Olaf Hering
2015-03-24 15:57   ` Ian Campbell
2015-03-25  8:46     ` Olaf Hering
2015-03-25 10:55       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550FDEB2020000780006C785@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=olaf@aepfle.de \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.