From: Hanjun Guo <hanjun.guo@linaro.org> To: Catalin Marinas <catalin.marinas@arm.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Will Deacon <will.deacon@arm.com>, Olof Johansson <olof@lixom.net>, Grant Likely <grant.likely@linaro.org> Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Arnd Bergmann <arnd@arndb.de>, Mark Rutland <mark.rutland@arm.com>, Graeme Gregory <graeme.gregory@linaro.org>, Sudeep Holla <Sudeep.Holla@arm.com>, Jon Masters <jcm@redhat.com>, Marc Zyngier <marc.zyngier@arm.com>, Mark Brown <broonie@kernel.org>, Robert Richter <rric@kernel.org>, Timur Tabi <timur@codeaurora.org>, Ashwin Chaugule <ashwinc@codeaurora.org>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Mark Salter <msalter@redhat.com>, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, Hanjun Guo <hanjun.guo@linaro.org> Subject: [patch v11 01/23] ACPI / table: Use pr_debug() instead of pr_info() for MADT table scanning Date: Tue, 24 Mar 2015 22:02:34 +0800 [thread overview] Message-ID: <1427205776-5060-2-git-send-email-hanjun.guo@linaro.org> (raw) In-Reply-To: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org> For a normal 8 cpu sockets system, it will up to 240 cpu threads (Xeon E7 v2 family for now), and we need 240 entries for local apic or local x2apic in MADT table, so it will be much verbose information printed with a slow uart console when system booted, this will be even worse with large system with 16/32 cpu sockets. This patch just use pr_debug() instead of pr_info() for ioapic/iosapic, local apic/x2apic/sapic structures when scanning the MADT table to remove those verbose information, but leave other structures unchanged. CC: Rafael J Wysocki <rjw@rjwysocki.net> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Olof Johansson <olof@lixom.net> Acked-by: Grant Likely <grant.likely@linaro.org> Tested-by: Timur Tabi <timur@codeaurora.org> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> --- drivers/acpi/tables.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 93b8152..f4e5b88 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -23,6 +23,8 @@ * */ +/* Uncomment next line to get verbose printout */ +/* #define DEBUG */ #define pr_fmt(fmt) "ACPI: " fmt #include <linux/init.h> @@ -61,9 +63,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_local_apic *p = (struct acpi_madt_local_apic *)header; - pr_info("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", - p->processor_id, p->id, - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); + pr_debug("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", + p->processor_id, p->id, + (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); } break; @@ -71,9 +73,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_local_x2apic *p = (struct acpi_madt_local_x2apic *)header; - pr_info("X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n", - p->local_apic_id, p->uid, - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); + pr_debug("X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n", + p->local_apic_id, p->uid, + (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); } break; @@ -81,8 +83,8 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_io_apic *p = (struct acpi_madt_io_apic *)header; - pr_info("IOAPIC (id[0x%02x] address[0x%08x] gsi_base[%d])\n", - p->id, p->address, p->global_irq_base); + pr_debug("IOAPIC (id[0x%02x] address[0x%08x] gsi_base[%d])\n", + p->id, p->address, p->global_irq_base); } break; @@ -155,9 +157,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_io_sapic *p = (struct acpi_madt_io_sapic *)header; - pr_info("IOSAPIC (id[0x%x] address[%p] gsi_base[%d])\n", - p->id, (void *)(unsigned long)p->address, - p->global_irq_base); + pr_debug("IOSAPIC (id[0x%x] address[%p] gsi_base[%d])\n", + p->id, (void *)(unsigned long)p->address, + p->global_irq_base); } break; @@ -165,9 +167,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_local_sapic *p = (struct acpi_madt_local_sapic *)header; - pr_info("LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n", - p->processor_id, p->id, p->eid, - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); + pr_debug("LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n", + p->processor_id, p->id, p->eid, + (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); } break; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: hanjun.guo@linaro.org (Hanjun Guo) To: linux-arm-kernel@lists.infradead.org Subject: [patch v11 01/23] ACPI / table: Use pr_debug() instead of pr_info() for MADT table scanning Date: Tue, 24 Mar 2015 22:02:34 +0800 [thread overview] Message-ID: <1427205776-5060-2-git-send-email-hanjun.guo@linaro.org> (raw) In-Reply-To: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org> For a normal 8 cpu sockets system, it will up to 240 cpu threads (Xeon E7 v2 family for now), and we need 240 entries for local apic or local x2apic in MADT table, so it will be much verbose information printed with a slow uart console when system booted, this will be even worse with large system with 16/32 cpu sockets. This patch just use pr_debug() instead of pr_info() for ioapic/iosapic, local apic/x2apic/sapic structures when scanning the MADT table to remove those verbose information, but leave other structures unchanged. CC: Rafael J Wysocki <rjw@rjwysocki.net> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Olof Johansson <olof@lixom.net> Acked-by: Grant Likely <grant.likely@linaro.org> Tested-by: Timur Tabi <timur@codeaurora.org> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> --- drivers/acpi/tables.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 93b8152..f4e5b88 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -23,6 +23,8 @@ * */ +/* Uncomment next line to get verbose printout */ +/* #define DEBUG */ #define pr_fmt(fmt) "ACPI: " fmt #include <linux/init.h> @@ -61,9 +63,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_local_apic *p = (struct acpi_madt_local_apic *)header; - pr_info("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", - p->processor_id, p->id, - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); + pr_debug("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", + p->processor_id, p->id, + (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); } break; @@ -71,9 +73,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_local_x2apic *p = (struct acpi_madt_local_x2apic *)header; - pr_info("X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n", - p->local_apic_id, p->uid, - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); + pr_debug("X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n", + p->local_apic_id, p->uid, + (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); } break; @@ -81,8 +83,8 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_io_apic *p = (struct acpi_madt_io_apic *)header; - pr_info("IOAPIC (id[0x%02x] address[0x%08x] gsi_base[%d])\n", - p->id, p->address, p->global_irq_base); + pr_debug("IOAPIC (id[0x%02x] address[0x%08x] gsi_base[%d])\n", + p->id, p->address, p->global_irq_base); } break; @@ -155,9 +157,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_io_sapic *p = (struct acpi_madt_io_sapic *)header; - pr_info("IOSAPIC (id[0x%x] address[%p] gsi_base[%d])\n", - p->id, (void *)(unsigned long)p->address, - p->global_irq_base); + pr_debug("IOSAPIC (id[0x%x] address[%p] gsi_base[%d])\n", + p->id, (void *)(unsigned long)p->address, + p->global_irq_base); } break; @@ -165,9 +167,9 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) { struct acpi_madt_local_sapic *p = (struct acpi_madt_local_sapic *)header; - pr_info("LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n", - p->processor_id, p->id, p->eid, - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); + pr_debug("LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n", + p->processor_id, p->id, p->eid, + (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); } break; -- 1.9.1
next prev parent reply other threads:[~2015-03-24 14:02 UTC|newest] Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-24 14:02 [patch v11 00/23] Introduce ACPI for ARM64 based on ACPI 5.1 Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo [this message] 2015-03-24 14:02 ` [patch v11 01/23] ACPI / table: Use pr_debug() instead of pr_info() for MADT table scanning Hanjun Guo 2015-03-24 14:02 ` [patch v11 02/23] ACPI: add arm64 to the platforms that use ioremap Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 16:43 ` Catalin Marinas 2015-03-25 16:43 ` Catalin Marinas 2015-03-25 16:43 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 03/23] ARM64: allow late use of early_ioremap Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 16:43 ` Catalin Marinas 2015-03-25 16:43 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 04/23] ARM64 / ACPI: Get RSDP and ACPI boot-time tables Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 16:44 ` Catalin Marinas 2015-03-25 16:44 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 05/23] ACPI: fix acpi_os_ioremap for arm64 Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 16:50 ` Catalin Marinas 2015-03-25 16:50 ` Catalin Marinas 2015-03-25 16:50 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 06/23] ACPI / sleep: Introduce CONFIG_ACPI_SYSTEM_POWER_STATES_SUPPORT Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-24 14:02 ` [patch v11 07/23] ARM64 / ACPI: Introduce PCI stub functions for ACPI Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 16:50 ` Catalin Marinas 2015-03-25 16:50 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 08/23] ARM64 / ACPI: Introduce early_param "acpi=" to enable/disable ACPI Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 16:57 ` Catalin Marinas 2015-03-25 16:57 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 09/23] ARM64 / ACPI: If we chose to boot from acpi then disable FDT Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:00 ` Catalin Marinas 2015-03-25 17:00 ` Catalin Marinas 2015-03-26 10:57 ` Lorenzo Pieralisi 2015-03-26 10:57 ` Lorenzo Pieralisi 2015-03-26 10:57 ` Lorenzo Pieralisi 2015-03-24 14:02 ` [patch v11 10/23] ARM64 / ACPI: Get PSCI flags in FADT for PSCI init Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:01 ` Catalin Marinas 2015-03-25 17:01 ` Catalin Marinas 2015-03-25 17:01 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 11/23] ACPI / table: Print GIC information when MADT is parsed Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-24 14:02 ` [patch v11 12/23] ARM64 / ACPI: Parse MADT for SMP initialization Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:17 ` Catalin Marinas 2015-03-25 17:17 ` Catalin Marinas 2015-03-25 17:17 ` Catalin Marinas 2015-03-26 15:15 ` Will Deacon 2015-03-26 15:15 ` Will Deacon 2015-03-26 15:15 ` Will Deacon 2015-03-26 19:48 ` Hanjun Guo 2015-03-26 19:48 ` Hanjun Guo 2015-03-26 19:48 ` Hanjun Guo 2015-03-26 21:12 ` Will Deacon 2015-03-26 21:12 ` Will Deacon 2015-03-26 21:12 ` Will Deacon 2015-03-26 23:01 ` Hanjun Guo 2015-03-26 23:01 ` Hanjun Guo 2015-03-26 23:01 ` Hanjun Guo 2015-03-24 14:02 ` [patch v11 13/23] ACPI / processor: Introduce phys_cpuid_t for CPU hardware ID Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:21 ` Catalin Marinas 2015-03-25 17:21 ` Catalin Marinas 2015-03-25 17:21 ` Catalin Marinas 2015-03-26 3:49 ` Hanjun Guo 2015-03-26 3:49 ` Hanjun Guo 2015-03-26 3:49 ` Hanjun Guo 2015-03-26 15:13 ` Will Deacon 2015-03-26 15:13 ` Will Deacon 2015-03-26 15:13 ` Will Deacon 2015-03-27 13:40 ` Hanjun Guo 2015-03-27 13:40 ` Hanjun Guo 2015-03-27 13:40 ` Hanjun Guo 2015-03-30 13:58 ` Catalin Marinas 2015-03-30 13:58 ` Catalin Marinas 2015-03-30 13:58 ` Catalin Marinas 2015-03-31 1:49 ` Hanjun Guo 2015-03-31 1:49 ` Hanjun Guo 2015-03-31 1:49 ` Hanjun Guo 2015-03-24 14:02 ` [patch v11 14/23] ACPI / processor: Make it possible to get CPU hardware ID via GICC Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:25 ` Catalin Marinas 2015-03-25 17:25 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 15/23] ARM64 / ACPI: Introduce ACPI_IRQ_MODEL_GIC and register device's gsi Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-24 14:02 ` [patch v11 16/23] irqchip: Add GICv2 specific ACPI boot support Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:27 ` Catalin Marinas 2015-03-25 17:27 ` Catalin Marinas 2015-03-25 17:27 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 17/23] clocksource / arch_timer: Parse GTDT to initialize arch timer Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:28 ` Catalin Marinas 2015-03-25 17:28 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 18/23] ARM64 / ACPI: Select ACPI_REDUCED_HARDWARE_ONLY if ACPI is enabled on ARM64 Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:29 ` Catalin Marinas 2015-03-25 17:29 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 19/23] XEN / ACPI: Make XEN ACPI depend on X86 Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-24 15:30 ` Boris Ostrovsky 2015-03-24 15:30 ` Boris Ostrovsky 2015-03-24 15:30 ` Boris Ostrovsky 2015-03-24 17:24 ` Stefano Stabellini 2015-03-24 17:24 ` Stefano Stabellini 2015-03-24 17:24 ` Stefano Stabellini 2015-03-25 11:51 ` Will Deacon 2015-03-25 11:51 ` Will Deacon 2015-03-25 11:51 ` Will Deacon 2015-03-25 15:38 ` Stefano Stabellini 2015-03-25 15:38 ` Stefano Stabellini 2015-03-25 15:38 ` Stefano Stabellini 2015-03-24 14:02 ` [patch v11 20/23] ARM64 / ACPI: Enable ARM64 in Kconfig Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:29 ` Catalin Marinas 2015-03-25 17:29 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 21/23] Documentation: ACPI for ARM64 Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:30 ` Catalin Marinas 2015-03-25 17:30 ` Catalin Marinas 2015-03-24 14:02 ` [patch v11 22/23] ARM64 / ACPI: additions of ACPI documentation for arm64 Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-24 14:02 ` [patch v11 23/23] ARM64 / ACPI: Don't unflatten device tree if acpi=force is passed Hanjun Guo 2015-03-24 14:02 ` Hanjun Guo 2015-03-25 17:31 ` Catalin Marinas 2015-03-25 17:31 ` Catalin Marinas 2015-03-25 17:31 ` Catalin Marinas 2015-03-24 23:04 ` [patch v11 00/23] Introduce ACPI for ARM64 based on ACPI 5.1 Rafael J. Wysocki 2015-03-24 23:04 ` Rafael J. Wysocki 2015-03-25 12:55 ` Hanjun Guo 2015-03-25 12:55 ` Hanjun Guo 2015-03-25 12:55 ` Hanjun Guo 2015-03-25 3:53 ` Ming Lei 2015-03-25 3:53 ` Ming Lei 2015-03-30 16:49 ` Timur Tabi 2015-03-30 16:49 ` Timur Tabi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1427205776-5060-2-git-send-email-hanjun.guo@linaro.org \ --to=hanjun.guo@linaro.org \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=Sudeep.Holla@arm.com \ --cc=arnd@arndb.de \ --cc=ashwinc@codeaurora.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=graeme.gregory@linaro.org \ --cc=grant.likely@linaro.org \ --cc=jcm@redhat.com \ --cc=linaro-acpi@lists.linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=msalter@redhat.com \ --cc=olof@lixom.net \ --cc=rjw@rjwysocki.net \ --cc=rric@kernel.org \ --cc=suravee.suthikulpanit@amd.com \ --cc=timur@codeaurora.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.