* [PATCH] libxl: Fix memory leak if pthread_create fails.
@ 2015-03-26 1:35 Konrad Rzeszutek Wilk
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-03-26 1:35 UTC (permalink / raw)
To: jfehlig, libvir-list; +Cc: xen-devel
If we fail to create the thread we leak the shutdown_info
structure.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
src/libxl/libxl_domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 774b070..0ac5c62 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -482,7 +482,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
libxlDriverPrivatePtr driver = data;
virDomainObjPtr vm = NULL;
libxl_shutdown_reason xl_reason = event->u.domain_shutdown.shutdown_reason;
- struct libxlShutdownThreadInfo *shutdown_info;
+ struct libxlShutdownThreadInfo *shutdown_info = NULL;
virThread thread;
libxlDriverConfigPtr cfg;
@@ -535,6 +535,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
virObjectUnref(cfg);
if (vm)
virObjectUnlock(vm);
+ VIR_FREE(shutdown_info);
}
void
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libxl: Fix memory leak if pthread_create fails.
[not found] <1427333711-12822-1-git-send-email-konrad.wilk@oracle.com>
@ 2015-03-26 20:47 ` Jim Fehlig
0 siblings, 0 replies; 2+ messages in thread
From: Jim Fehlig @ 2015-03-26 20:47 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: libvir-list, xen-devel
Konrad Rzeszutek Wilk wrote:
> If we fail to create the thread we leak the shutdown_info
> structure.
>
Nice catch, thanks! ACK and pushed.
Regards,
Jim
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> src/libxl/libxl_domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
> index 774b070..0ac5c62 100644
> --- a/src/libxl/libxl_domain.c
> +++ b/src/libxl/libxl_domain.c
> @@ -482,7 +482,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
> libxlDriverPrivatePtr driver = data;
> virDomainObjPtr vm = NULL;
> libxl_shutdown_reason xl_reason = event->u.domain_shutdown.shutdown_reason;
> - struct libxlShutdownThreadInfo *shutdown_info;
> + struct libxlShutdownThreadInfo *shutdown_info = NULL;
> virThread thread;
> libxlDriverConfigPtr cfg;
>
> @@ -535,6 +535,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
> virObjectUnref(cfg);
> if (vm)
> virObjectUnlock(vm);
> + VIR_FREE(shutdown_info);
> }
>
> void
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-26 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-26 1:35 [PATCH] libxl: Fix memory leak if pthread_create fails Konrad Rzeszutek Wilk
[not found] <1427333711-12822-1-git-send-email-konrad.wilk@oracle.com>
2015-03-26 20:47 ` Jim Fehlig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.