Re: [PATCH] libxl: Fix memory leak if pthread_create fails.

Re: [PATCH] libxl: Fix memory leak if pthread_create fails.

[Jim Fehlig]

Konrad Rzeszutek Wilk wrote:
> If we fail to create the thread we leak the shutdown_info
> structure.
>   

Nice catch, thanks!  ACK and pushed.

Regards,
Jim

> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  src/libxl/libxl_domain.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
> index 774b070..0ac5c62 100644
> --- a/src/libxl/libxl_domain.c
> +++ b/src/libxl/libxl_domain.c
> @@ -482,7 +482,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
>      libxlDriverPrivatePtr driver = data;
>      virDomainObjPtr vm = NULL;
>      libxl_shutdown_reason xl_reason = event->u.domain_shutdown.shutdown_reason;
> -    struct libxlShutdownThreadInfo *shutdown_info;
> +    struct libxlShutdownThreadInfo *shutdown_info = NULL;
>      virThread thread;
>      libxlDriverConfigPtr cfg;
>  
> @@ -535,6 +535,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
>      virObjectUnref(cfg);
>      if (vm)
>          virObjectUnlock(vm);
> +    VIR_FREE(shutdown_info);
>  }
>  
>  void
>   

[PATCH] libxl: Fix memory leak if pthread_create fails.

[Konrad Rzeszutek Wilk]

If we fail to create the thread we leak the shutdown_info
structure.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 src/libxl/libxl_domain.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 774b070..0ac5c62 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -482,7 +482,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
     libxlDriverPrivatePtr driver = data;
     virDomainObjPtr vm = NULL;
     libxl_shutdown_reason xl_reason = event->u.domain_shutdown.shutdown_reason;
-    struct libxlShutdownThreadInfo *shutdown_info;
+    struct libxlShutdownThreadInfo *shutdown_info = NULL;
     virThread thread;
     libxlDriverConfigPtr cfg;
 
@@ -535,6 +535,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
     virObjectUnref(cfg);
     if (vm)
         virObjectUnlock(vm);
+    VIR_FREE(shutdown_info);
 }
 
 void
-- 
1.8.4.2