From: Marc Zyngier <marc.zyngier@arm.com> To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: "Jon Medhurst (Tixy)" <tixy@linaro.org>, Andre Przywara <andre.przywara@arm.com>, Will Deacon <will.deacon@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Dave Martin <dave.martin@arm.com> Subject: [PATCH v3 0/5] arm64: Patching branches for fun and profit Date: Fri, 27 Mar 2015 13:09:20 +0000 [thread overview] Message-ID: <1427461765-14462-1-git-send-email-marc.zyngier@arm.com> (raw) The current alternative instruction framework is not kind to branches, potentially leading to all kind of hacks in the code that uses alternatives. This series expands it to deal with immediate branches (for a start), and applies it to the VGIC world switch. Patch #1 adds the required infrastructure to extract the immediate from an instruction. Patch #2 allows the use of an immediate b or bl instruction as an alternative, computing the target branch as the instruction is being patched in. Patch #3 defines a feature framework that works exactly like the CPU errata infrastructure (and shares a lot with it). Patch #4 adds detection of the system register GICv3 CPU interface. Patch #5 enables dynamic patching of the KVM code. This has been tested with GICv3 on a FastModel. * From v1: - Fixed missing cpu_to_le32 when writing back the instruction - Added Will's Acks. * From v2: - Replaced cpu_to_le32 with aarch_write_insn, which is the proper API and takes care of the potential pitfall if the text is read-only. Thanks to Tixy for suggesting this. Marc Zyngier (5): arm64: insn: Add aarch64_insn_decode_immediate arm64: alternative: Allow immediate branch as alternative instruction arm64: Extract feature parsing code from cpu_errata.c arm64: alternative: Introduce feature for GICv3 CPU interface arm64: KVM: Switch vgic save/restore to alternative_insn arch/arm/include/asm/kvm_host.h | 5 --- arch/arm64/include/asm/cpufeature.h | 23 ++++++++++- arch/arm64/include/asm/insn.h | 1 + arch/arm64/include/asm/kvm_host.h | 23 ----------- arch/arm64/kernel/Makefile | 2 +- arch/arm64/kernel/alternative.c | 55 ++++++++++++++++++++++++- arch/arm64/kernel/asm-offsets.c | 1 - arch/arm64/kernel/cpu_errata.c | 36 ++--------------- arch/arm64/kernel/cpufeature.c | 63 +++++++++++++++++++++++++++++ arch/arm64/kernel/cpuinfo.c | 1 + arch/arm64/kernel/insn.c | 81 +++++++++++++++++++++++++++++-------- arch/arm64/kvm/hyp.S | 18 ++------- virt/kvm/arm/vgic.c | 3 -- 13 files changed, 214 insertions(+), 98 deletions(-) create mode 100644 arch/arm64/kernel/cpufeature.c -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/5] arm64: Patching branches for fun and profit Date: Fri, 27 Mar 2015 13:09:20 +0000 [thread overview] Message-ID: <1427461765-14462-1-git-send-email-marc.zyngier@arm.com> (raw) The current alternative instruction framework is not kind to branches, potentially leading to all kind of hacks in the code that uses alternatives. This series expands it to deal with immediate branches (for a start), and applies it to the VGIC world switch. Patch #1 adds the required infrastructure to extract the immediate from an instruction. Patch #2 allows the use of an immediate b or bl instruction as an alternative, computing the target branch as the instruction is being patched in. Patch #3 defines a feature framework that works exactly like the CPU errata infrastructure (and shares a lot with it). Patch #4 adds detection of the system register GICv3 CPU interface. Patch #5 enables dynamic patching of the KVM code. This has been tested with GICv3 on a FastModel. * From v1: - Fixed missing cpu_to_le32 when writing back the instruction - Added Will's Acks. * From v2: - Replaced cpu_to_le32 with aarch_write_insn, which is the proper API and takes care of the potential pitfall if the text is read-only. Thanks to Tixy for suggesting this. Marc Zyngier (5): arm64: insn: Add aarch64_insn_decode_immediate arm64: alternative: Allow immediate branch as alternative instruction arm64: Extract feature parsing code from cpu_errata.c arm64: alternative: Introduce feature for GICv3 CPU interface arm64: KVM: Switch vgic save/restore to alternative_insn arch/arm/include/asm/kvm_host.h | 5 --- arch/arm64/include/asm/cpufeature.h | 23 ++++++++++- arch/arm64/include/asm/insn.h | 1 + arch/arm64/include/asm/kvm_host.h | 23 ----------- arch/arm64/kernel/Makefile | 2 +- arch/arm64/kernel/alternative.c | 55 ++++++++++++++++++++++++- arch/arm64/kernel/asm-offsets.c | 1 - arch/arm64/kernel/cpu_errata.c | 36 ++--------------- arch/arm64/kernel/cpufeature.c | 63 +++++++++++++++++++++++++++++ arch/arm64/kernel/cpuinfo.c | 1 + arch/arm64/kernel/insn.c | 81 +++++++++++++++++++++++++++++-------- arch/arm64/kvm/hyp.S | 18 ++------- virt/kvm/arm/vgic.c | 3 -- 13 files changed, 214 insertions(+), 98 deletions(-) create mode 100644 arch/arm64/kernel/cpufeature.c -- 2.1.4
next reply other threads:[~2015-03-27 13:02 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-27 13:09 Marc Zyngier [this message] 2015-03-27 13:09 ` [PATCH v3 0/5] arm64: Patching branches for fun and profit Marc Zyngier 2015-03-27 13:09 ` [PATCH v3 1/5] arm64: insn: Add aarch64_insn_decode_immediate Marc Zyngier 2015-03-27 13:09 ` Marc Zyngier 2015-03-27 13:09 ` [PATCH v3 2/5] arm64: alternative: Allow immediate branch as alternative instruction Marc Zyngier 2015-03-27 13:09 ` Marc Zyngier 2015-03-27 13:09 ` [PATCH v3 3/5] arm64: Extract feature parsing code from cpu_errata.c Marc Zyngier 2015-03-27 13:09 ` Marc Zyngier 2015-03-27 13:09 ` [PATCH v3 4/5] arm64: alternative: Introduce feature for GICv3 CPU interface Marc Zyngier 2015-03-27 13:09 ` Marc Zyngier 2015-05-14 11:25 ` Christoffer Dall 2015-05-14 11:25 ` Christoffer Dall 2015-05-28 9:27 ` Marc Zyngier 2015-05-28 9:27 ` Marc Zyngier 2015-05-28 13:02 ` Christoffer Dall 2015-05-28 13:02 ` Christoffer Dall 2015-05-28 13:12 ` Marc Zyngier 2015-05-28 13:12 ` Marc Zyngier 2015-03-27 13:09 ` [PATCH v3 5/5] arm64: KVM: Switch vgic save/restore to alternative_insn Marc Zyngier 2015-03-27 13:09 ` Marc Zyngier 2015-05-14 11:53 ` Christoffer Dall 2015-05-14 11:53 ` Christoffer Dall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1427461765-14462-1-git-send-email-marc.zyngier@arm.com \ --to=marc.zyngier@arm.com \ --cc=andre.przywara@arm.com \ --cc=catalin.marinas@arm.com \ --cc=dave.martin@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=tixy@linaro.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.