All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Mueller <mimu@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Gleb Natapov <gleb@kernel.org>, Alexander Graf <agraf@suse.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Michael Mueller <mimu@linux.vnet.ibm.com>,
	Andreas Faerber <afaerber@suse.de>,
	Richard Henderson <rth@twiddle.net>,
	Daniel Hansel <daniel.hansel@linux.vnet.ibm.com>
Subject: [PATCH v4 15/15] target-s390x: Enable cpu model usage
Date: Mon, 30 Mar 2015 16:28:28 +0200	[thread overview]
Message-ID: <1427725708-52100-16-git-send-email-mimu@linux.vnet.ibm.com> (raw)
In-Reply-To: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com>

This patch enables QEMU to instantiate S390 CPUs with cpu model types.

Signed-off-by: Michael Mueller <mimu@linux.vnet.ibm.com>
---
 hw/s390x/s390-virtio.c | 12 +++++++++++-
 target-s390x/helper.c  |  9 ++-------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c
index bdb5388..8fda717 100644
--- a/hw/s390x/s390-virtio.c
+++ b/hw/s390x/s390-virtio.c
@@ -32,6 +32,7 @@
 #include "hw/virtio/virtio.h"
 #include "hw/sysbus.h"
 #include "sysemu/kvm.h"
+#include "sysemu/cpus.h"
 #include "exec/address-spaces.h"
 
 #include "hw/s390x/s390-virtio-bus.h"
@@ -157,7 +158,12 @@ void s390_init_cpus(const char *cpu_model, uint8_t *storage_keys)
     int i;
 
     if (cpu_model == NULL) {
-        cpu_model = "host";
+        cpu_model = "none";
+    }
+
+    if (is_help_option(cpu_model)) {
+        list_cpus(stdout, &fprintf, cpu_model);
+        exit(0);
     }
 
     ipi_states = g_malloc(sizeof(S390CPU *) * smp_cpus);
@@ -167,6 +173,10 @@ void s390_init_cpus(const char *cpu_model, uint8_t *storage_keys)
         CPUState *cs;
 
         cpu = cpu_s390x_init(cpu_model);
+        if (cpu == NULL) {
+            fprintf(stderr, "Unable to find CPU definition\n");
+            exit(1);
+        }
         cs = CPU(cpu);
 
         ipi_states[i] = cpu;
diff --git a/target-s390x/helper.c b/target-s390x/helper.c
index f1060c2..29dabe2 100644
--- a/target-s390x/helper.c
+++ b/target-s390x/helper.c
@@ -22,6 +22,7 @@
 #include "exec/gdbstub.h"
 #include "qemu/timer.h"
 #include "exec/cpu_ldst.h"
+#include "cpu-models.h"
 #ifndef CONFIG_USER_ONLY
 #include "sysemu/sysemu.h"
 #endif
@@ -66,13 +67,7 @@ void s390x_cpu_timer(void *opaque)
 
 S390CPU *cpu_s390x_init(const char *cpu_model)
 {
-    S390CPU *cpu;
-
-    cpu = S390_CPU(object_new(TYPE_S390_CPU));
-
-    object_property_set_bool(OBJECT(cpu), true, "realized", NULL);
-
-    return cpu;
+    return S390_CPU(cpu_generic_init(TYPE_S390_CPU, cpu_model));
 }
 
 #if defined(CONFIG_USER_ONLY)
-- 
1.8.3.1


WARNING: multiple messages have this Message-ID (diff)
From: Michael Mueller <mimu@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Gleb Natapov <gleb@kernel.org>, Alexander Graf <agraf@suse.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Daniel Hansel <daniel.hansel@linux.vnet.ibm.com>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Andreas Faerber <afaerber@suse.de>,
	Michael Mueller <mimu@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v4 15/15] target-s390x: Enable cpu model usage
Date: Mon, 30 Mar 2015 16:28:28 +0200	[thread overview]
Message-ID: <1427725708-52100-16-git-send-email-mimu@linux.vnet.ibm.com> (raw)
In-Reply-To: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com>

This patch enables QEMU to instantiate S390 CPUs with cpu model types.

Signed-off-by: Michael Mueller <mimu@linux.vnet.ibm.com>
---
 hw/s390x/s390-virtio.c | 12 +++++++++++-
 target-s390x/helper.c  |  9 ++-------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c
index bdb5388..8fda717 100644
--- a/hw/s390x/s390-virtio.c
+++ b/hw/s390x/s390-virtio.c
@@ -32,6 +32,7 @@
 #include "hw/virtio/virtio.h"
 #include "hw/sysbus.h"
 #include "sysemu/kvm.h"
+#include "sysemu/cpus.h"
 #include "exec/address-spaces.h"
 
 #include "hw/s390x/s390-virtio-bus.h"
@@ -157,7 +158,12 @@ void s390_init_cpus(const char *cpu_model, uint8_t *storage_keys)
     int i;
 
     if (cpu_model == NULL) {
-        cpu_model = "host";
+        cpu_model = "none";
+    }
+
+    if (is_help_option(cpu_model)) {
+        list_cpus(stdout, &fprintf, cpu_model);
+        exit(0);
     }
 
     ipi_states = g_malloc(sizeof(S390CPU *) * smp_cpus);
@@ -167,6 +173,10 @@ void s390_init_cpus(const char *cpu_model, uint8_t *storage_keys)
         CPUState *cs;
 
         cpu = cpu_s390x_init(cpu_model);
+        if (cpu == NULL) {
+            fprintf(stderr, "Unable to find CPU definition\n");
+            exit(1);
+        }
         cs = CPU(cpu);
 
         ipi_states[i] = cpu;
diff --git a/target-s390x/helper.c b/target-s390x/helper.c
index f1060c2..29dabe2 100644
--- a/target-s390x/helper.c
+++ b/target-s390x/helper.c
@@ -22,6 +22,7 @@
 #include "exec/gdbstub.h"
 #include "qemu/timer.h"
 #include "exec/cpu_ldst.h"
+#include "cpu-models.h"
 #ifndef CONFIG_USER_ONLY
 #include "sysemu/sysemu.h"
 #endif
@@ -66,13 +67,7 @@ void s390x_cpu_timer(void *opaque)
 
 S390CPU *cpu_s390x_init(const char *cpu_model)
 {
-    S390CPU *cpu;
-
-    cpu = S390_CPU(object_new(TYPE_S390_CPU));
-
-    object_property_set_bool(OBJECT(cpu), true, "realized", NULL);
-
-    return cpu;
+    return S390_CPU(cpu_generic_init(TYPE_S390_CPU, cpu_model));
 }
 
 #if defined(CONFIG_USER_ONLY)
-- 
1.8.3.1

  parent reply	other threads:[~2015-03-30 14:29 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 14:28 [PATCH v4 00/15] s390x cpu model implementation Michael Mueller
2015-03-30 14:28 ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 01/15] Introduce stub routine cpu_desc_avail Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 02/15] target-s390x: Introduce cpu facilities Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 03/15] target-s390x: Generate facility defines per cpu model Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 04/15] target-s390x: Introduce cpu models Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 05/15] target-s390x: Define cpu model specific facility lists Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 06/15] target-s390x: Add cpu model alias definition routines Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 19:36   ` Christian Borntraeger
2015-03-30 19:36     ` [Qemu-devel] " Christian Borntraeger
2015-03-30 19:36     ` Christian Borntraeger
2015-03-31  7:25     ` Michael Mueller
2015-03-31  7:25       ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28 ` [PATCH v4 08/15] target-s390x: Add KVM VM attribute interface for cpu models Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 09/15] target-s390x: Add cpu class initialization routines Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 10/15] target-s390x: Prepare accelerator during cpu object realization Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 19:33   ` Eduardo Habkost
2015-03-30 19:33     ` [Qemu-devel] " Eduardo Habkost
2015-03-31 10:26     ` Michael Mueller
2015-03-31 10:26       ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 19:50   ` Eduardo Habkost
2015-03-30 19:50     ` [Qemu-devel] " Eduardo Habkost
2015-03-31  9:10     ` Michael Mueller
2015-03-31  9:10       ` Michael Mueller
2015-03-30 20:17   ` Eduardo Habkost
2015-03-30 20:17     ` [Qemu-devel] " Eduardo Habkost
2015-03-30 20:17     ` Eduardo Habkost
2015-03-30 20:20     ` [Qemu-devel] " Eric Blake
2015-03-30 20:20       ` Eric Blake
2015-03-30 20:20       ` Eric Blake
2015-03-31 13:16       ` [Qemu-devel] " Eduardo Habkost
2015-03-31 13:16         ` Eduardo Habkost
2015-03-31 11:21     ` Michael Mueller
2015-03-31 11:21       ` Michael Mueller
2015-03-31 18:28       ` Eduardo Habkost
2015-03-31 18:28         ` Eduardo Habkost
2015-03-30 20:19   ` Eric Blake
2015-03-30 20:19     ` Eric Blake
2015-03-31  7:56     ` Michael Mueller
2015-03-31  7:56       ` Michael Mueller
2015-03-31  7:56       ` Michael Mueller
2015-03-31 18:35   ` Eduardo Habkost
2015-03-31 18:35     ` [Qemu-devel] " Eduardo Habkost
2015-03-31 20:09     ` Michael Mueller
2015-03-31 20:09       ` [Qemu-devel] " Michael Mueller
2015-03-31 20:09       ` Michael Mueller
2015-04-01 13:01       ` Eduardo Habkost
2015-04-01 13:01         ` [Qemu-devel] " Eduardo Habkost
2015-04-01 16:31         ` Michael Mueller
2015-04-01 16:31           ` Michael Mueller
2015-04-01 16:59           ` Eduardo Habkost
2015-04-01 16:59             ` Eduardo Habkost
2015-04-01 16:59             ` Eduardo Habkost
2015-04-01 19:05             ` [Qemu-devel] " Michael Mueller
2015-04-01 19:05               ` Michael Mueller
2015-04-01 19:05               ` Michael Mueller
2015-04-01 19:10               ` [Qemu-devel] " Michael Mueller
2015-04-01 19:10                 ` Michael Mueller
2015-04-01 23:05               ` Eduardo Habkost
2015-04-01 23:05                 ` Eduardo Habkost
2015-04-01 23:05                 ` Eduardo Habkost
2015-04-02  7:09                 ` [Qemu-devel] " Michael Mueller
2015-04-02  7:09                   ` Michael Mueller
2015-04-02  7:09                   ` Michael Mueller
2015-04-02 15:15                   ` [Qemu-devel] " Eduardo Habkost
2015-04-02 15:15                     ` Eduardo Habkost
2015-03-30 14:28 ` [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 20:28   ` Eric Blake
2015-03-30 20:28     ` Eric Blake
2015-03-31  7:42     ` Michael Mueller
2015-03-31  7:42       ` Michael Mueller
2015-03-31  7:42       ` Michael Mueller
2015-03-31 19:46   ` Eduardo Habkost
2015-03-31 19:46     ` [Qemu-devel] " Eduardo Habkost
2015-03-31 19:46     ` Eduardo Habkost
2015-03-31 19:50     ` Eric Blake
2015-03-31 19:50       ` [Qemu-devel] " Eric Blake
2015-03-31 19:50       ` Eric Blake
2015-03-31 20:22     ` [Qemu-devel] " Michael Mueller
2015-03-31 20:22       ` Michael Mueller
2015-03-30 14:28 ` [PATCH v4 13/15] target-s390x: Extend " Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 19:54   ` Eduardo Habkost
2015-03-30 19:54     ` [Qemu-devel] " Eduardo Habkost
2015-03-30 14:28 ` [PATCH v4 14/15] target-s390x: Introduce facility test routine Michael Mueller
2015-03-30 14:28   ` [Qemu-devel] " Michael Mueller
2015-03-30 14:28   ` Michael Mueller
2015-03-30 14:28 ` Michael Mueller [this message]
2015-03-30 14:28   ` [Qemu-devel] [PATCH v4 15/15] target-s390x: Enable cpu model usage Michael Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427725708-52100-16-git-send-email-mimu@linux.vnet.ibm.com \
    --to=mimu@linux.vnet.ibm.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=daniel.hansel@linux.vnet.ibm.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.