* [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning"
@ 2015-04-02 11:15 Sudip Mukherjee
2015-04-03 13:44 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2015-04-02 11:15 UTC (permalink / raw)
To: Greg Kroah-Hartman, Lad, Prabhakar
Cc: Sudip Mukherjee, linux-usb, linux-kernel
This reverts commit <1dc6120ef7f003305d99ef12f598a6b05eacc38c>.
if we are doing allyesconfig on x86_64, build fails with error:
drivers/built-in.o: In function `sl811_cs_probe':
sl811_cs.c:(.text+0x1d4612e): undefined reference to `sl811h_driver'
this commit has declared sl811h_driver as static but it was being
accessed from sl811_cs.c.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/usb/host/sl811-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c
index 944a417..f1d5c5a 100644
--- a/drivers/usb/host/sl811-hcd.c
+++ b/drivers/usb/host/sl811-hcd.c
@@ -1801,7 +1801,7 @@ sl811h_resume(struct platform_device *dev)
/* this driver is exported so sl811_cs can depend on it */
-static struct platform_driver sl811h_driver = {
+struct platform_driver sl811h_driver = {
.probe = sl811h_probe,
.remove = sl811h_remove,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning"
2015-04-02 11:15 [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning" Sudip Mukherjee
@ 2015-04-03 13:44 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2015-04-03 13:44 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Lad, Prabhakar, linux-usb, linux-kernel
On Thu, Apr 02, 2015 at 04:45:40PM +0530, Sudip Mukherjee wrote:
> This reverts commit <1dc6120ef7f003305d99ef12f598a6b05eacc38c>.
>
> if we are doing allyesconfig on x86_64, build fails with error:
> drivers/built-in.o: In function `sl811_cs_probe':
> sl811_cs.c:(.text+0x1d4612e): undefined reference to `sl811h_driver'
>
> this commit has declared sl811h_driver as static but it was being
> accessed from sl811_cs.c.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/usb/host/sl811-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Someone else sent this patch in a few days before you did, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-03 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-02 11:15 [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning" Sudip Mukherjee
2015-04-03 13:44 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.