From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, devicetree@vger.kernel.org,
galak@codeaurora.org, netdev@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver
Date: Thu, 02 Apr 2015 13:56:39 +0000 [thread overview]
Message-ID: <1427982999.18722.35.camel@xylophone.i.decadent.org.uk> (raw)
In-Reply-To: <2926619.fiYHPz1IBk@wasted.cogentembedded.com>
This driver looks somewhat similar to sh-eth, but lacks some of the
recent bug fixes made to that. At least commit 283e38db65e7 ("sh_eth:
Fix serialisation of interrupt disable with interrupt & NAPI handler")
appears to be applicable, but there are probably others.
One feature request:
On Sat, 2015-03-28 at 02:13 +0300, Sergei Shtylyov wrote:
[...]
> +/* ioctl to device function */
> +static int ravb_do_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
> +{
> + struct ravb_private *priv = netdev_priv(ndev);
> + struct phy_device *phydev = priv->phydev;
> +
> + if (!netif_running(ndev))
> + return -EINVAL;
> +
> + if (!phydev)
> + return -ENODEV;
> +
> + if (cmd = SIOCSHWTSTAMP)
> + return ravb_hwtstamp_ioctl(ndev, req, cmd);
[...]
The driver should also handle SIOCGHWTSTAMP.
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, devicetree@vger.kernel.org,
galak@codeaurora.org, netdev@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver
Date: Thu, 02 Apr 2015 14:56:39 +0100 [thread overview]
Message-ID: <1427982999.18722.35.camel@xylophone.i.decadent.org.uk> (raw)
In-Reply-To: <2926619.fiYHPz1IBk@wasted.cogentembedded.com>
This driver looks somewhat similar to sh-eth, but lacks some of the
recent bug fixes made to that. At least commit 283e38db65e7 ("sh_eth:
Fix serialisation of interrupt disable with interrupt & NAPI handler")
appears to be applicable, but there are probably others.
One feature request:
On Sat, 2015-03-28 at 02:13 +0300, Sergei Shtylyov wrote:
[...]
> +/* ioctl to device function */
> +static int ravb_do_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
> +{
> + struct ravb_private *priv = netdev_priv(ndev);
> + struct phy_device *phydev = priv->phydev;
> +
> + if (!netif_running(ndev))
> + return -EINVAL;
> +
> + if (!phydev)
> + return -ENODEV;
> +
> + if (cmd == SIOCSHWTSTAMP)
> + return ravb_hwtstamp_ioctl(ndev, req, cmd);
[...]
The driver should also handle SIOCGHWTSTAMP.
Ben.
next prev parent reply other threads:[~2015-04-02 13:56 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 23:13 [PATCH resend] Renesas Ethernet AVB driver Sergei Shtylyov
2015-03-27 23:13 ` Sergei Shtylyov
2015-03-28 5:17 ` Lino Sanfilippo
2015-03-28 5:17 ` Lino Sanfilippo
2015-03-28 8:36 ` Richard Cochran
2015-03-28 8:36 ` Richard Cochran
2015-03-28 13:55 ` Sergei Shtylyov
2015-03-28 13:55 ` Sergei Shtylyov
2015-03-28 8:28 ` Richard Cochran
2015-03-28 8:28 ` Richard Cochran
2015-03-28 18:26 ` David Miller
2015-03-28 18:26 ` David Miller
2015-03-30 22:51 ` Sergei Shtylyov
2015-03-30 22:51 ` Sergei Shtylyov
2015-03-31 6:43 ` Richard Cochran
2015-03-31 6:43 ` Richard Cochran
2015-03-31 9:01 ` Richard Cochran
2015-03-31 9:01 ` Richard Cochran
2015-03-31 15:38 ` David Miller
2015-03-31 15:38 ` David Miller
2015-03-31 17:40 ` Sergei Shtylyov
2015-03-31 17:40 ` Sergei Shtylyov
2015-03-31 17:48 ` David Miller
2015-03-31 17:48 ` David Miller
2015-04-03 6:27 ` masaru.nagai.vx
2015-04-03 6:27 ` masaru.nagai.vx
2015-04-03 6:27 ` masaru.nagai.vx
2015-04-12 22:03 ` Sergei Shtylyov
2015-04-12 22:03 ` Sergei Shtylyov
2015-04-09 13:11 ` Bjørn Mork
2015-04-09 13:11 ` Bjørn Mork
2015-04-09 17:57 ` David Miller
2015-04-09 17:57 ` David Miller
2015-04-13 20:23 ` Sergei Shtylyov
2015-04-13 20:23 ` Sergei Shtylyov
2015-04-14 5:27 ` Richard Cochran
2015-04-14 5:27 ` Richard Cochran
2015-04-14 10:14 ` Sergei Shtylyov
2015-04-14 10:14 ` Sergei Shtylyov
2015-04-14 16:30 ` Richard Cochran
2015-04-14 16:30 ` Richard Cochran
2015-04-14 16:58 ` Sergei Shtylyov
2015-04-14 16:58 ` Sergei Shtylyov
2015-04-14 18:30 ` Richard Cochran
2015-04-14 18:30 ` Richard Cochran
2015-04-15 1:01 ` masaru.nagai.vx
2015-04-15 1:01 ` masaru.nagai.vx
2015-04-15 1:01 ` masaru.nagai.vx
2015-04-15 5:31 ` Richard Cochran
2015-04-15 5:31 ` Richard Cochran
2015-04-02 13:56 ` Ben Hutchings [this message]
2015-04-02 13:56 ` Ben Hutchings
2015-04-13 20:34 ` Sergei Shtylyov
2015-04-13 20:34 ` Sergei Shtylyov
2015-04-13 22:13 ` Lino Sanfilippo
2015-04-13 22:13 ` Lino Sanfilippo
2015-04-13 22:31 ` Ben Hutchings
2015-04-13 22:31 ` Ben Hutchings
2015-04-13 22:53 ` Lino Sanfilippo
2015-04-13 22:53 ` Lino Sanfilippo
2015-04-13 23:08 ` Ben Hutchings
2015-04-13 23:08 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427982999.18722.35.camel@xylophone.i.decadent.org.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.