All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, devicetree@vger.kernel.org,
	galak@codeaurora.org, netdev@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver
Date: Sat, 28 Mar 2015 08:36:00 +0000	[thread overview]
Message-ID: <20150328083600.GB4255@localhost.localdomain> (raw)
In-Reply-To: <55163959.8080101@gmx.de>

On Sat, Mar 28, 2015 at 06:17:13AM +0100, Lino Sanfilippo wrote:
> 
> Do you really need one huge lock for all register accesses? Maybe you
> should rethink which registers can actually be accessed concurrently and
> implement some finer grained locking.

One lock is fine, unless the registers are highly contended.

Thanks,
Richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, devicetree@vger.kernel.org,
	galak@codeaurora.org, netdev@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver
Date: Sat, 28 Mar 2015 09:36:00 +0100	[thread overview]
Message-ID: <20150328083600.GB4255@localhost.localdomain> (raw)
In-Reply-To: <55163959.8080101@gmx.de>

On Sat, Mar 28, 2015 at 06:17:13AM +0100, Lino Sanfilippo wrote:
> 
> Do you really need one huge lock for all register accesses? Maybe you
> should rethink which registers can actually be accessed concurrently and
> implement some finer grained locking.

One lock is fine, unless the registers are highly contended.

Thanks,
Richard

  reply	other threads:[~2015-03-28  8:36 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 23:13 [PATCH resend] Renesas Ethernet AVB driver Sergei Shtylyov
2015-03-27 23:13 ` Sergei Shtylyov
2015-03-28  5:17 ` Lino Sanfilippo
2015-03-28  5:17   ` Lino Sanfilippo
2015-03-28  8:36   ` Richard Cochran [this message]
2015-03-28  8:36     ` Richard Cochran
2015-03-28 13:55   ` Sergei Shtylyov
2015-03-28 13:55     ` Sergei Shtylyov
2015-03-28  8:28 ` Richard Cochran
2015-03-28  8:28   ` Richard Cochran
2015-03-28 18:26   ` David Miller
2015-03-28 18:26     ` David Miller
2015-03-30 22:51   ` Sergei Shtylyov
2015-03-30 22:51     ` Sergei Shtylyov
2015-03-31  6:43     ` Richard Cochran
2015-03-31  6:43       ` Richard Cochran
2015-03-31  9:01       ` Richard Cochran
2015-03-31  9:01         ` Richard Cochran
2015-03-31 15:38       ` David Miller
2015-03-31 15:38         ` David Miller
2015-03-31 17:40         ` Sergei Shtylyov
2015-03-31 17:40           ` Sergei Shtylyov
2015-03-31 17:48           ` David Miller
2015-03-31 17:48             ` David Miller
2015-04-03  6:27             ` masaru.nagai.vx
2015-04-03  6:27               ` masaru.nagai.vx
2015-04-03  6:27               ` masaru.nagai.vx
2015-04-12 22:03               ` Sergei Shtylyov
2015-04-12 22:03                 ` Sergei Shtylyov
2015-04-09 13:11       ` Bjørn Mork
2015-04-09 13:11         ` Bjørn Mork
2015-04-09 17:57         ` David Miller
2015-04-09 17:57           ` David Miller
2015-04-13 20:23     ` Sergei Shtylyov
2015-04-13 20:23       ` Sergei Shtylyov
2015-04-14  5:27       ` Richard Cochran
2015-04-14  5:27         ` Richard Cochran
2015-04-14 10:14         ` Sergei Shtylyov
2015-04-14 10:14           ` Sergei Shtylyov
2015-04-14 16:30           ` Richard Cochran
2015-04-14 16:30             ` Richard Cochran
2015-04-14 16:58             ` Sergei Shtylyov
2015-04-14 16:58               ` Sergei Shtylyov
2015-04-14 18:30               ` Richard Cochran
2015-04-14 18:30                 ` Richard Cochran
2015-04-15  1:01                 ` masaru.nagai.vx
2015-04-15  1:01                   ` masaru.nagai.vx
2015-04-15  1:01                   ` masaru.nagai.vx
2015-04-15  5:31                   ` Richard Cochran
2015-04-15  5:31                     ` Richard Cochran
2015-04-02 13:56 ` Ben Hutchings
2015-04-02 13:56   ` Ben Hutchings
2015-04-13 20:34   ` Sergei Shtylyov
2015-04-13 20:34     ` Sergei Shtylyov
2015-04-13 22:13     ` Lino Sanfilippo
2015-04-13 22:13       ` Lino Sanfilippo
2015-04-13 22:31       ` Ben Hutchings
2015-04-13 22:31         ` Ben Hutchings
2015-04-13 22:53         ` Lino Sanfilippo
2015-04-13 22:53           ` Lino Sanfilippo
2015-04-13 23:08           ` Ben Hutchings
2015-04-13 23:08             ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150328083600.GB4255@localhost.localdomain \
    --to=richardcochran@gmail.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-sh@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.