All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: "Igal.Liberman" <igal.liberman@freescale.com>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/dts: Update the core cluster PLL node(s)
Date: Tue, 14 Apr 2015 15:21:08 -0500	[thread overview]
Message-ID: <1429042868.22867.689.camel@freescale.com> (raw)
In-Reply-To: <1429005306-24544-1-git-send-email-igal.liberman@freescale.com>

On Tue, 2015-04-14 at 12:55 +0300, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> This patch replaces the following:
> 	https://patchwork.ozlabs.org/patch/427664/
> 
> This patch is described by the following binding document update:
> 	https://patchwork.ozlabs.org/patch/461150/
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> ---
>  arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> index 48e0b6e..7e1f074 100644
> --- a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> @@ -49,14 +49,16 @@ global-utilities@e1000 {
>  		reg = <0x800 0x4>;
>  		compatible = "fsl,qoriq-core-pll-2.0";
>  		clocks = <&sysclk>;
> -		clock-output-names = "pll0", "pll0-div2", "pll0-div4";
> +		clock-output-names = "pll0", "pll0-div2", "pll0-div3",
> +				      "pll0-div4";
>  	};
>  	pll1: pll1@820 {
>  		#clock-cells = <1>;
>  		reg = <0x820 0x4>;
>  		compatible = "fsl,qoriq-core-pll-2.0";
>  		clocks = <&sysclk>;
> -		clock-output-names = "pll1", "pll1-div2", "pll1-div4";
> +		clock-output-names = "pll1", "pll1-div2", "pll1-div3",
> +				      "pll1-div4";

Wait, so if the driver implements the binding you submitted, you'll
break compatibility with these older device trees...

I think we need to just accept the ugly count-the-clock-names approach
and document it.

-Scott


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Igal.Liberman <igal.liberman@freescale.com>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/dts: Update the core cluster PLL node(s)
Date: Tue, 14 Apr 2015 15:21:08 -0500	[thread overview]
Message-ID: <1429042868.22867.689.camel@freescale.com> (raw)
In-Reply-To: <1429005306-24544-1-git-send-email-igal.liberman@freescale.com>

On Tue, 2015-04-14 at 12:55 +0300, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> This patch replaces the following:
> 	https://patchwork.ozlabs.org/patch/427664/
> 
> This patch is described by the following binding document update:
> 	https://patchwork.ozlabs.org/patch/461150/
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> ---
>  arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> index 48e0b6e..7e1f074 100644
> --- a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> @@ -49,14 +49,16 @@ global-utilities@e1000 {
>  		reg = <0x800 0x4>;
>  		compatible = "fsl,qoriq-core-pll-2.0";
>  		clocks = <&sysclk>;
> -		clock-output-names = "pll0", "pll0-div2", "pll0-div4";
> +		clock-output-names = "pll0", "pll0-div2", "pll0-div3",
> +				      "pll0-div4";
>  	};
>  	pll1: pll1@820 {
>  		#clock-cells = <1>;
>  		reg = <0x820 0x4>;
>  		compatible = "fsl,qoriq-core-pll-2.0";
>  		clocks = <&sysclk>;
> -		clock-output-names = "pll1", "pll1-div2", "pll1-div4";
> +		clock-output-names = "pll1", "pll1-div2", "pll1-div3",
> +				      "pll1-div4";

Wait, so if the driver implements the binding you submitted, you'll
break compatibility with these older device trees...

I think we need to just accept the ugly count-the-clock-names approach
and document it.

-Scott

  reply	other threads:[~2015-04-14 20:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  9:55 [PATCH] powerpc/dts: Update the core cluster PLL node(s) Igal.Liberman
2015-04-14  9:55 ` Igal.Liberman
2015-04-14 20:21 ` Scott Wood [this message]
2015-04-14 20:21   ` Scott Wood
2015-04-14 20:22   ` Scott Wood
2015-04-14 20:22     ` Scott Wood
     [not found]     ` <1429042950.22867.690.camel-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-04-15 11:07       ` Igal.Liberman-KZfg59tc24xl57MIdRCFDg
2015-04-15 11:07         ` Igal.Liberman
     [not found]         ` <DM2PR03MB3831BEEDD2C17991818FFA9E6E50-ufbTtyGzTTRJonC5hhDUuuO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2015-04-15 17:14           ` Scott Wood
2015-04-15 17:14             ` Scott Wood
2015-04-16  6:13             ` Igal.Liberman
2015-04-16  6:13               ` Igal.Liberman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429042868.22867.689.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=devicetree@vger.kernel.org \
    --cc=igal.liberman@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.