All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Linux-MM <linux-mm@kvack.org>
Cc: Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Andi Kleen <andi@firstfloor.org>,
	LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de>
Subject: [PATCH 3/4] mm: Gather more PFNs before sending a TLB to flush unmapped pages
Date: Wed, 15 Apr 2015 11:42:55 +0100	[thread overview]
Message-ID: <1429094576-5877-4-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1429094576-5877-1-git-send-email-mgorman@suse.de>

The patch "mm: Send a single IPI to TLB flush multiple pages when unmapping"
would batch 32 pages before sending an IPI. This patch increases the size of
the data structure to hold a pages worth of PFNs before sending an IPI. This
is a trade-off between memory usage and reducing IPIS sent. In the ideal
case where multiple processes are reading large mapped files, this patch
reduces interrupts/second from roughly 180K per second to 60K per second.

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 include/linux/sched.h | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 9d51841806f4..abff66ecc302 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1275,11 +1275,16 @@ enum perf_event_task_context {
 	perf_nr_task_contexts,
 };
 
-/* Matches SWAP_CLUSTER_MAX but refined to limit header dependencies */
-#define BATCH_TLBFLUSH_SIZE 32UL
+/*
+ * Use a page to store as many PFNs as possible for batch unmapping. Adjusting
+ * this trades memory usage for number of IPIs sent
+ */
+#define BATCH_TLBFLUSH_SIZE \
+	((PAGE_SIZE - sizeof(struct cpumask) - sizeof(unsigned long)) / sizeof(unsigned long))
 
 /* Track pages that require TLB flushes */
 struct unmap_batch {
+	/* Update BATCH_TLBFLUSH_SIZE when adjusting this structure */
 	struct cpumask cpumask;
 	unsigned long nr_pages;
 	unsigned long pfns[BATCH_TLBFLUSH_SIZE];
-- 
2.1.2


WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Linux-MM <linux-mm@kvack.org>
Cc: Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Andi Kleen <andi@firstfloor.org>,
	LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de>
Subject: [PATCH 3/4] mm: Gather more PFNs before sending a TLB to flush unmapped pages
Date: Wed, 15 Apr 2015 11:42:55 +0100	[thread overview]
Message-ID: <1429094576-5877-4-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1429094576-5877-1-git-send-email-mgorman@suse.de>

The patch "mm: Send a single IPI to TLB flush multiple pages when unmapping"
would batch 32 pages before sending an IPI. This patch increases the size of
the data structure to hold a pages worth of PFNs before sending an IPI. This
is a trade-off between memory usage and reducing IPIS sent. In the ideal
case where multiple processes are reading large mapped files, this patch
reduces interrupts/second from roughly 180K per second to 60K per second.

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 include/linux/sched.h | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 9d51841806f4..abff66ecc302 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1275,11 +1275,16 @@ enum perf_event_task_context {
 	perf_nr_task_contexts,
 };
 
-/* Matches SWAP_CLUSTER_MAX but refined to limit header dependencies */
-#define BATCH_TLBFLUSH_SIZE 32UL
+/*
+ * Use a page to store as many PFNs as possible for batch unmapping. Adjusting
+ * this trades memory usage for number of IPIs sent
+ */
+#define BATCH_TLBFLUSH_SIZE \
+	((PAGE_SIZE - sizeof(struct cpumask) - sizeof(unsigned long)) / sizeof(unsigned long))
 
 /* Track pages that require TLB flushes */
 struct unmap_batch {
+	/* Update BATCH_TLBFLUSH_SIZE when adjusting this structure */
 	struct cpumask cpumask;
 	unsigned long nr_pages;
 	unsigned long pfns[BATCH_TLBFLUSH_SIZE];
-- 
2.1.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-04-15 10:43 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 10:42 [RFC PATCH 0/4] TLB flush multiple pages with a single IPI Mel Gorman
2015-04-15 10:42 ` Mel Gorman
2015-04-15 10:42 ` [PATCH 1/4] x86, mm: Trace when an IPI is about to be sent Mel Gorman
2015-04-15 10:42   ` Mel Gorman
2015-04-15 10:42 ` [PATCH 2/4] mm: Send a single IPI to TLB flush multiple pages when unmapping Mel Gorman
2015-04-15 10:42   ` Mel Gorman
2015-04-15 21:03   ` Rik van Riel
2015-04-15 21:03     ` Rik van Riel
2015-04-15 21:16     ` Hugh Dickins
2015-04-15 21:16       ` Hugh Dickins
2015-04-15 21:28       ` Mel Gorman
2015-04-15 21:28         ` Mel Gorman
2015-04-15 21:32         ` Dave Hansen
2015-04-15 21:32           ` Dave Hansen
2015-04-16  6:38         ` Minchan Kim
2015-04-16  6:38           ` Minchan Kim
2015-04-16  8:07           ` Mel Gorman
2015-04-16  8:07             ` Mel Gorman
2015-04-16  8:29             ` Minchan Kim
2015-04-16  8:29               ` Minchan Kim
2015-04-16  9:19               ` Mel Gorman
2015-04-16  9:19                 ` Mel Gorman
2015-04-16 23:30                 ` Minchan Kim
2015-04-16 23:30                   ` Minchan Kim
2015-04-15 22:20   ` Andi Kleen
2015-04-15 22:20     ` Andi Kleen
2015-04-15 22:53     ` Mel Gorman
2015-04-15 22:53       ` Mel Gorman
2015-04-15 10:42 ` Mel Gorman [this message]
2015-04-15 10:42   ` [PATCH 3/4] mm: Gather more PFNs before sending a TLB to flush unmapped pages Mel Gorman
2015-04-15 11:42   ` Peter Zijlstra
2015-04-15 11:42     ` Peter Zijlstra
2015-04-15 12:15     ` Mel Gorman
2015-04-15 12:15       ` Mel Gorman
2015-04-15 12:24       ` Peter Zijlstra
2015-04-15 12:24         ` Peter Zijlstra
2015-04-15 12:56         ` Mel Gorman
2015-04-15 12:56           ` Mel Gorman
2015-04-15 10:42 ` [PATCH 4/4] mm: migrate: Batch TLB flushing when unmapping pages for migration Mel Gorman
2015-04-15 10:42   ` Mel Gorman
2015-04-15 21:06   ` Hugh Dickins
2015-04-15 21:06     ` Hugh Dickins
2015-04-15 21:44     ` Mel Gorman
2015-04-15 21:44       ` Mel Gorman
2015-04-15 23:50       ` Hugh Dickins
2015-04-15 23:50         ` Hugh Dickins
2015-04-16 10:22 [RFC PATCH 0/4] TLB flush multiple pages with a single IPI v2 Mel Gorman
2015-04-16 10:22 ` [PATCH 3/4] mm: Gather more PFNs before sending a TLB to flush unmapped pages Mel Gorman
2015-04-16 10:22   ` Mel Gorman
2015-04-16 16:00   ` Rik van Riel
2015-04-16 16:00     ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429094576-5877-4-git-send-email-mgorman@suse.de \
    --to=mgorman@suse.de \
    --cc=andi@firstfloor.org \
    --cc=dave.hansen@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.