* [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled
@ 2015-04-20 23:14 ` Tyler Baker
0 siblings, 0 replies; 6+ messages in thread
From: Tyler Baker @ 2015-04-20 23:14 UTC (permalink / raw)
To: Shuah Khan
Cc: Kevin Hilman, John Stultz, Darren Hart, David Herrmann,
Michael Ellerman, linux-kernel, linux-arm-kernel, Tyler Baker
The breakpoints test should only should be executed on x86 targets, so lets
emit a skip and omit the installation when ARCH != x86.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
tools/testing/selftests/breakpoints/Makefile | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
index 1822356..430b76d 100644
--- a/tools/testing/selftests/breakpoints/Makefile
+++ b/tools/testing/selftests/breakpoints/Makefile
@@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64)
ARCH := x86
endif
-
all:
ifeq ($(ARCH),x86)
gcc breakpoint_test.c -o breakpoint_test
@@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test
include ../lib.mk
+install:
+ifneq ($(ARCH),x86)
+echo "Not an x86 target, can't install breakpoints selftests"
+override EMIT_TESTS := echo "echo \"selftests: breakpoint_test [SKIP]\""
+endif
+
clean:
rm -fr breakpoint_test
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled
@ 2015-04-20 23:14 ` Tyler Baker
0 siblings, 0 replies; 6+ messages in thread
From: Tyler Baker @ 2015-04-20 23:14 UTC (permalink / raw)
To: linux-arm-kernel
The breakpoints test should only should be executed on x86 targets, so lets
emit a skip and omit the installation when ARCH != x86.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
tools/testing/selftests/breakpoints/Makefile | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
index 1822356..430b76d 100644
--- a/tools/testing/selftests/breakpoints/Makefile
+++ b/tools/testing/selftests/breakpoints/Makefile
@@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64)
ARCH := x86
endif
-
all:
ifeq ($(ARCH),x86)
gcc breakpoint_test.c -o breakpoint_test
@@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test
include ../lib.mk
+install:
+ifneq ($(ARCH),x86)
+echo "Not an x86 target, can't install breakpoints selftests"
+override EMIT_TESTS := echo "echo \"selftests: breakpoint_test [SKIP]\""
+endif
+
clean:
rm -fr breakpoint_test
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled
2015-04-20 23:14 ` Tyler Baker
@ 2015-04-21 9:41 ` Suzuki K. Poulose
-1 siblings, 0 replies; 6+ messages in thread
From: Suzuki K. Poulose @ 2015-04-21 9:41 UTC (permalink / raw)
To: Tyler Baker, Shuah Khan
Cc: Kevin Hilman, John Stultz, Darren Hart, David Herrmann,
Michael Ellerman, linux-kernel, linux-arm-kernel
On 21/04/15 00:14, Tyler Baker wrote:
> The breakpoints test should only should be executed on x86 targets, so lets
> emit a skip and omit the installation when ARCH != x86.
>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> tools/testing/selftests/breakpoints/Makefile | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 1822356..430b76d 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64)
> ARCH := x86
> endif
>
> -
> all:
> ifeq ($(ARCH),x86)
> gcc breakpoint_test.c -o breakpoint_test
> @@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test
>
> include ../lib.mk
>
> +install:
> +ifneq ($(ARCH),x86)
> +echo "Not an x86 target, can't install breakpoints selftests"
It would make more sense to send this to stderr than stdout, people may
look for errors there.
Cheers
Suzuki
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled
@ 2015-04-21 9:41 ` Suzuki K. Poulose
0 siblings, 0 replies; 6+ messages in thread
From: Suzuki K. Poulose @ 2015-04-21 9:41 UTC (permalink / raw)
To: linux-arm-kernel
On 21/04/15 00:14, Tyler Baker wrote:
> The breakpoints test should only should be executed on x86 targets, so lets
> emit a skip and omit the installation when ARCH != x86.
>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> tools/testing/selftests/breakpoints/Makefile | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 1822356..430b76d 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64)
> ARCH := x86
> endif
>
> -
> all:
> ifeq ($(ARCH),x86)
> gcc breakpoint_test.c -o breakpoint_test
> @@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test
>
> include ../lib.mk
>
> +install:
> +ifneq ($(ARCH),x86)
> +echo "Not an x86 target, can't install breakpoints selftests"
It would make more sense to send this to stderr than stdout, people may
look for errors there.
Cheers
Suzuki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled
2015-04-21 9:41 ` Suzuki K. Poulose
@ 2015-04-21 22:01 ` Tyler Baker
-1 siblings, 0 replies; 6+ messages in thread
From: Tyler Baker @ 2015-04-21 22:01 UTC (permalink / raw)
To: Suzuki K. Poulose
Cc: Shuah Khan, Kevin Hilman, John Stultz, Darren Hart,
David Herrmann, Michael Ellerman, linux-kernel, linux-arm-kernel
On 21 April 2015 at 02:41, Suzuki K. Poulose <Suzuki.Poulose@arm.com> wrote:
> On 21/04/15 00:14, Tyler Baker wrote:
>>
>> The breakpoints test should only should be executed on x86 targets, so
>> lets
>> emit a skip and omit the installation when ARCH != x86.
>>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>> ---
>> tools/testing/selftests/breakpoints/Makefile | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/breakpoints/Makefile
>> b/tools/testing/selftests/breakpoints/Makefile
>> index 1822356..430b76d 100644
>> --- a/tools/testing/selftests/breakpoints/Makefile
>> +++ b/tools/testing/selftests/breakpoints/Makefile
>> @@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64)
>> ARCH := x86
>> endif
>>
>> -
>> all:
>> ifeq ($(ARCH),x86)
>> gcc breakpoint_test.c -o breakpoint_test
>> @@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test
>>
>> include ../lib.mk
>>
>> +install:
>> +ifneq ($(ARCH),x86)
>> +echo "Not an x86 target, can't install breakpoints selftests"
>
> It would make more sense to send this to stderr than stdout, people may look
> for errors there.
I'm ok with that. However, I'm going to remove this workaround in the
next revision of this series. I am planning to send another series out
to address the shortcomings of lib.mk. At which point I'll make sure
to log these errors/warnings to stderr as you suggested.
>
> Cheers
> Suzuki
>
Thanks for the comment,
Tyler
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled
@ 2015-04-21 22:01 ` Tyler Baker
0 siblings, 0 replies; 6+ messages in thread
From: Tyler Baker @ 2015-04-21 22:01 UTC (permalink / raw)
To: linux-arm-kernel
On 21 April 2015 at 02:41, Suzuki K. Poulose <Suzuki.Poulose@arm.com> wrote:
> On 21/04/15 00:14, Tyler Baker wrote:
>>
>> The breakpoints test should only should be executed on x86 targets, so
>> lets
>> emit a skip and omit the installation when ARCH != x86.
>>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>> ---
>> tools/testing/selftests/breakpoints/Makefile | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/breakpoints/Makefile
>> b/tools/testing/selftests/breakpoints/Makefile
>> index 1822356..430b76d 100644
>> --- a/tools/testing/selftests/breakpoints/Makefile
>> +++ b/tools/testing/selftests/breakpoints/Makefile
>> @@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64)
>> ARCH := x86
>> endif
>>
>> -
>> all:
>> ifeq ($(ARCH),x86)
>> gcc breakpoint_test.c -o breakpoint_test
>> @@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test
>>
>> include ../lib.mk
>>
>> +install:
>> +ifneq ($(ARCH),x86)
>> +echo "Not an x86 target, can't install breakpoints selftests"
>
> It would make more sense to send this to stderr than stdout, people may look
> for errors there.
I'm ok with that. However, I'm going to remove this workaround in the
next revision of this series. I am planning to send another series out
to address the shortcomings of lib.mk. At which point I'll make sure
to log these errors/warnings to stderr as you suggested.
>
> Cheers
> Suzuki
>
Thanks for the comment,
Tyler
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-21 22:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-20 23:14 [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled Tyler Baker
2015-04-20 23:14 ` Tyler Baker
2015-04-21 9:41 ` Suzuki K. Poulose
2015-04-21 9:41 ` Suzuki K. Poulose
2015-04-21 22:01 ` Tyler Baker
2015-04-21 22:01 ` Tyler Baker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.