All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-20 21:49 ` Peter Seiderer
  0 siblings, 0 replies; 13+ messages in thread
From: Peter Seiderer @ 2015-05-20 21:49 UTC (permalink / raw)
  To: linux-kernel
  Cc: devicetree, linux-arm-kernel, Russell King, Kumar Gala,
	Ian Campbell, Mark Rutland, Pawel Moll, Rob Herring,
	Sascha Hauer, Shawn Guo

Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration
taken from Boundary Devices linux kernel tree ([1] and [2]).

[1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dts
[2] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index fd096dc..1c415e4 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -54,6 +54,17 @@
 			gpio = <&gpio3 22 0>;
 			enable-active-high;
 		};
+
+		reg_can_xcvr: regulator@3 {
+			compatible = "regulator-fixed";
+			reg = <3>;
+			regulator-name = "CAN XCVR";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_can_xcvr>;
+			gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		};
 	};
 
 	gpio-keys {
@@ -138,6 +149,13 @@
 	status = "okay";
 };
 
+&can1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_can1_1>;
+	xceiver-supply = <&reg_can_xcvr>;
+	status = "okay";
+};
+
 &ecspi1 {
 	fsl,spi-num-chipselects = <1>;
 	cs-gpios = <&gpio3 19 0>;
@@ -234,6 +252,20 @@
 			>;
 		};
 
+		pinctrl_can1_1: can1grp-1 {
+			fsl,pins = <
+				MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
+				MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
+			>;
+		};
+
+		pinctrl_can_xcvr: can-xcvrgrp {
+			fsl,pins = <
+				/* Flexcan XCVR enable */
+				MX6QDL_PAD_GPIO_2__GPIO1_IO02		0x1b0b0
+			>;
+		};
+
 		pinctrl_ecspi1: ecspi1grp {
 			fsl,pins = <
 				MX6QDL_PAD_EIM_D17__ECSPI1_MISO		0x100b1
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-20 21:49 ` Peter Seiderer
  0 siblings, 0 replies; 13+ messages in thread
From: Peter Seiderer @ 2015-05-20 21:49 UTC (permalink / raw)
  To: linux-arm-kernel

Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration
taken from Boundary Devices linux kernel tree ([1] and [2]).

[1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dts
[2] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index fd096dc..1c415e4 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -54,6 +54,17 @@
 			gpio = <&gpio3 22 0>;
 			enable-active-high;
 		};
+
+		reg_can_xcvr: regulator at 3 {
+			compatible = "regulator-fixed";
+			reg = <3>;
+			regulator-name = "CAN XCVR";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_can_xcvr>;
+			gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		};
 	};
 
 	gpio-keys {
@@ -138,6 +149,13 @@
 	status = "okay";
 };
 
+&can1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_can1_1>;
+	xceiver-supply = <&reg_can_xcvr>;
+	status = "okay";
+};
+
 &ecspi1 {
 	fsl,spi-num-chipselects = <1>;
 	cs-gpios = <&gpio3 19 0>;
@@ -234,6 +252,20 @@
 			>;
 		};
 
+		pinctrl_can1_1: can1grp-1 {
+			fsl,pins = <
+				MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
+				MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
+			>;
+		};
+
+		pinctrl_can_xcvr: can-xcvrgrp {
+			fsl,pins = <
+				/* Flexcan XCVR enable */
+				MX6QDL_PAD_GPIO_2__GPIO1_IO02		0x1b0b0
+			>;
+		};
+
 		pinctrl_ecspi1: ecspi1grp {
 			fsl,pins = <
 				MX6QDL_PAD_EIM_D17__ECSPI1_MISO		0x100b1
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
  2015-05-20 21:49 ` Peter Seiderer
  (?)
@ 2015-05-20 22:26   ` Fabio Estevam
  -1 siblings, 0 replies; 13+ messages in thread
From: Fabio Estevam @ 2015-05-20 22:26 UTC (permalink / raw)
  To: Peter Seiderer
  Cc: linux-kernel, Mark Rutland, devicetree, Russell King, Pawel Moll,
	Ian Campbell, Rob Herring, Sascha Hauer, Kumar Gala, Shawn Guo,
	linux-arm-kernel

On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@gmx.net> wrote:

> +               pinctrl_can1_1: can1grp-1 {
> +                       fsl,pins = <
> +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000

Better not to pass 0x80000000. Use the real PAD settings instead.

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-20 22:26   ` Fabio Estevam
  0 siblings, 0 replies; 13+ messages in thread
From: Fabio Estevam @ 2015-05-20 22:26 UTC (permalink / raw)
  To: Peter Seiderer
  Cc: linux-kernel, Mark Rutland, devicetree, Russell King, Pawel Moll,
	Ian Campbell, Rob Herring, Sascha Hauer, Kumar Gala, Shawn Guo,
	linux-arm-kernel

On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@gmx.net> wrote:

> +               pinctrl_can1_1: can1grp-1 {
> +                       fsl,pins = <
> +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000

Better not to pass 0x80000000. Use the real PAD settings instead.

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-20 22:26   ` Fabio Estevam
  0 siblings, 0 replies; 13+ messages in thread
From: Fabio Estevam @ 2015-05-20 22:26 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@gmx.net> wrote:

> +               pinctrl_can1_1: can1grp-1 {
> +                       fsl,pins = <
> +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000

Better not to pass 0x80000000. Use the real PAD settings instead.

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-21  1:33   ` Shawn Guo
  0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2015-05-21  1:33 UTC (permalink / raw)
  To: Peter Seiderer
  Cc: linux-kernel, devicetree, linux-arm-kernel, Russell King,
	Kumar Gala, Ian Campbell, Mark Rutland, Pawel Moll, Rob Herring,
	Sascha Hauer

On Wed, May 20, 2015 at 11:49:29PM +0200, Peter Seiderer wrote:
> Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration
> taken from Boundary Devices linux kernel tree ([1] and [2]).
> 
> [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dts
> [2] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index fd096dc..1c415e4 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -54,6 +54,17 @@
>  			gpio = <&gpio3 22 0>;
>  			enable-active-high;
>  		};
> +
> +		reg_can_xcvr: regulator@3 {
> +			compatible = "regulator-fixed";
> +			reg = <3>;
> +			regulator-name = "CAN XCVR";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_can_xcvr>;
> +			gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> +		};
>  	};
>  
>  	gpio-keys {
> @@ -138,6 +149,13 @@
>  	status = "okay";
>  };
>  
> +&can1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_can1_1>;
> +	xceiver-supply = <&reg_can_xcvr>;
> +	status = "okay";
> +};
> +
>  &ecspi1 {
>  	fsl,spi-num-chipselects = <1>;
>  	cs-gpios = <&gpio3 19 0>;
> @@ -234,6 +252,20 @@
>  			>;
>  		};
>  
> +		pinctrl_can1_1: can1grp-1 {

The '_1' suffix is meaningless.

		pinctrl_can1: can1grp {

Shawn

> +			fsl,pins = <
> +				MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> +				MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> +			>;
> +		};
> +
> +		pinctrl_can_xcvr: can-xcvrgrp {
> +			fsl,pins = <
> +				/* Flexcan XCVR enable */
> +				MX6QDL_PAD_GPIO_2__GPIO1_IO02		0x1b0b0
> +			>;
> +		};
> +
>  		pinctrl_ecspi1: ecspi1grp {
>  			fsl,pins = <
>  				MX6QDL_PAD_EIM_D17__ECSPI1_MISO		0x100b1
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-21  1:33   ` Shawn Guo
  0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2015-05-21  1:33 UTC (permalink / raw)
  To: Peter Seiderer
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Russell King,
	Kumar Gala, Ian Campbell, Mark Rutland, Pawel Moll, Rob Herring,
	Sascha Hauer

On Wed, May 20, 2015 at 11:49:29PM +0200, Peter Seiderer wrote:
> Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration
> taken from Boundary Devices linux kernel tree ([1] and [2]).
> 
> [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dts
> [2] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi
> 
> Signed-off-by: Peter Seiderer <ps.report-hi6Y0CQ0nG0@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index fd096dc..1c415e4 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -54,6 +54,17 @@
>  			gpio = <&gpio3 22 0>;
>  			enable-active-high;
>  		};
> +
> +		reg_can_xcvr: regulator@3 {
> +			compatible = "regulator-fixed";
> +			reg = <3>;
> +			regulator-name = "CAN XCVR";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_can_xcvr>;
> +			gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> +		};
>  	};
>  
>  	gpio-keys {
> @@ -138,6 +149,13 @@
>  	status = "okay";
>  };
>  
> +&can1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_can1_1>;
> +	xceiver-supply = <&reg_can_xcvr>;
> +	status = "okay";
> +};
> +
>  &ecspi1 {
>  	fsl,spi-num-chipselects = <1>;
>  	cs-gpios = <&gpio3 19 0>;
> @@ -234,6 +252,20 @@
>  			>;
>  		};
>  
> +		pinctrl_can1_1: can1grp-1 {

The '_1' suffix is meaningless.

		pinctrl_can1: can1grp {

Shawn

> +			fsl,pins = <
> +				MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> +				MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> +			>;
> +		};
> +
> +		pinctrl_can_xcvr: can-xcvrgrp {
> +			fsl,pins = <
> +				/* Flexcan XCVR enable */
> +				MX6QDL_PAD_GPIO_2__GPIO1_IO02		0x1b0b0
> +			>;
> +		};
> +
>  		pinctrl_ecspi1: ecspi1grp {
>  			fsl,pins = <
>  				MX6QDL_PAD_EIM_D17__ECSPI1_MISO		0x100b1
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-21  1:33   ` Shawn Guo
  0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2015-05-21  1:33 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, May 20, 2015 at 11:49:29PM +0200, Peter Seiderer wrote:
> Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration
> taken from Boundary Devices linux kernel tree ([1] and [2]).
> 
> [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dts
> [2] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index fd096dc..1c415e4 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -54,6 +54,17 @@
>  			gpio = <&gpio3 22 0>;
>  			enable-active-high;
>  		};
> +
> +		reg_can_xcvr: regulator at 3 {
> +			compatible = "regulator-fixed";
> +			reg = <3>;
> +			regulator-name = "CAN XCVR";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_can_xcvr>;
> +			gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> +		};
>  	};
>  
>  	gpio-keys {
> @@ -138,6 +149,13 @@
>  	status = "okay";
>  };
>  
> +&can1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_can1_1>;
> +	xceiver-supply = <&reg_can_xcvr>;
> +	status = "okay";
> +};
> +
>  &ecspi1 {
>  	fsl,spi-num-chipselects = <1>;
>  	cs-gpios = <&gpio3 19 0>;
> @@ -234,6 +252,20 @@
>  			>;
>  		};
>  
> +		pinctrl_can1_1: can1grp-1 {

The '_1' suffix is meaningless.

		pinctrl_can1: can1grp {

Shawn

> +			fsl,pins = <
> +				MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> +				MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> +			>;
> +		};
> +
> +		pinctrl_can_xcvr: can-xcvrgrp {
> +			fsl,pins = <
> +				/* Flexcan XCVR enable */
> +				MX6QDL_PAD_GPIO_2__GPIO1_IO02		0x1b0b0
> +			>;
> +		};
> +
>  		pinctrl_ecspi1: ecspi1grp {
>  			fsl,pins = <
>  				MX6QDL_PAD_EIM_D17__ECSPI1_MISO		0x100b1
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Aw: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
  2015-05-20 22:26   ` Fabio Estevam
  (?)
@ 2015-05-21  6:51     ` Peter Seiderer
  -1 siblings, 0 replies; 13+ messages in thread
From: Peter Seiderer @ 2015-05-21  6:51 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: linux-kernel, Mark Rutland, devicetree, Russell King, Pawel Moll,
	Ian Campbell, Rob Herring, Sascha Hauer, Kumar Gala, Shawn Guo,
	linux-arm-kernel

Hello Fabio,

> Gesendet: Donnerstag, 21. Mai 2015 um 00:26 Uhr
> Von: "Fabio Estevam" <festevam@gmail.com>
> An: "Peter Seiderer" <ps.report@gmx.net>
> Cc: linux-kernel <linux-kernel@vger.kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "Russell King" <linux@arm.linux.org.uk>, "Pawel Moll" <pawel.moll@arm.com>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Rob Herring" <robh+dt@kernel.org>, "Sascha Hauer" <kernel@pengutronix.de>, "Kumar Gala" <galak@codeaurora.org>, "Shawn Guo" <shawn.guo@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
> Betreff: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
>
> On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@gmx.net> wrote:
> 
> > +               pinctrl_can1_1: can1grp-1 {
> > +                       fsl,pins = <
> > +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> > +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> 
> Better not to pass 0x80000000. Use the real PAD settings instead.
> 

Thanks for review, will fix it...

Regards,
Peter

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Aw: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-21  6:51     ` Peter Seiderer
  0 siblings, 0 replies; 13+ messages in thread
From: Peter Seiderer @ 2015-05-21  6:51 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: linux-kernel, Mark Rutland, devicetree, Russell King, Pawel Moll,
	Ian Campbell, Rob Herring, Sascha Hauer, Kumar Gala, Shawn Guo,
	linux-arm-kernel

Hello Fabio,

> Gesendet: Donnerstag, 21. Mai 2015 um 00:26 Uhr
> Von: "Fabio Estevam" <festevam@gmail.com>
> An: "Peter Seiderer" <ps.report@gmx.net>
> Cc: linux-kernel <linux-kernel@vger.kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "Russell King" <linux@arm.linux.org.uk>, "Pawel Moll" <pawel.moll@arm.com>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Rob Herring" <robh+dt@kernel.org>, "Sascha Hauer" <kernel@pengutronix.de>, "Kumar Gala" <galak@codeaurora.org>, "Shawn Guo" <shawn.guo@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
> Betreff: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
>
> On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@gmx.net> wrote:
> 
> > +               pinctrl_can1_1: can1grp-1 {
> > +                       fsl,pins = <
> > +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> > +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> 
> Better not to pass 0x80000000. Use the real PAD settings instead.
> 

Thanks for review, will fix it...

Regards,
Peter

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Aw: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-21  6:51     ` Peter Seiderer
  0 siblings, 0 replies; 13+ messages in thread
From: Peter Seiderer @ 2015-05-21  6:51 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Fabio,

> Gesendet: Donnerstag, 21. Mai 2015 um 00:26 Uhr
> Von: "Fabio Estevam" <festevam@gmail.com>
> An: "Peter Seiderer" <ps.report@gmx.net>
> Cc: linux-kernel <linux-kernel@vger.kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "devicetree at vger.kernel.org" <devicetree@vger.kernel.org>, "Russell King" <linux@arm.linux.org.uk>, "Pawel Moll" <pawel.moll@arm.com>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Rob Herring" <robh+dt@kernel.org>, "Sascha Hauer" <kernel@pengutronix.de>, "Kumar Gala" <galak@codeaurora.org>, "Shawn Guo" <shawn.guo@linaro.org>, "linux-arm-kernel at lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
> Betreff: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
>
> On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@gmx.net> wrote:
> 
> > +               pinctrl_can1_1: can1grp-1 {
> > +                       fsl,pins = <
> > +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> > +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> 
> Better not to pass 0x80000000. Use the real PAD settings instead.
> 

Thanks for review, will fix it...

Regards,
Peter

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Aw: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
  2015-05-21  1:33   ` Shawn Guo
@ 2015-05-21  6:56     ` Peter Seiderer
  -1 siblings, 0 replies; 13+ messages in thread
From: Peter Seiderer @ 2015-05-21  6:56 UTC (permalink / raw)
  To: Shawn Guo
  Cc: linux-kernel, devicetree, linux-arm-kernel, Russell King,
	Kumar Gala, Ian Campbell, Mark Rutland, Pawel Moll, Rob Herring,
	Sascha Hauer

Hello Shawn,

> Gesendet: Donnerstag, 21. Mai 2015 um 03:33 Uhr
> Von: "Shawn Guo" <shawn.guo@linaro.org>
> An: "Peter Seiderer" <ps.report@gmx.net>
> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Russell King" <linux@arm.linux.org.uk>, "Kumar Gala" <galak@codeaurora.org>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Mark Rutland" <mark.rutland@arm.com>, "Pawel Moll" <pawel.moll@arm.com>, "Rob Herring" <robh+dt@kernel.org>, "Sascha Hauer" <kernel@pengutronix.de>
> Betreff: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
>
> On Wed, May 20, 2015 at 11:49:29PM +0200, Peter Seiderer wrote:
> > Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration
> > taken from Boundary Devices linux kernel tree ([1] and [2]).
> > 
> > [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dts
> > [2] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi
> > 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > index fd096dc..1c415e4 100644
> > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > @@ -54,6 +54,17 @@
> >  			gpio = <&gpio3 22 0>;
> >  			enable-active-high;
> >  		};
> > +
> > +		reg_can_xcvr: regulator@3 {
> > +			compatible = "regulator-fixed";
> > +			reg = <3>;
> > +			regulator-name = "CAN XCVR";
> > +			regulator-min-microvolt = <3300000>;
> > +			regulator-max-microvolt = <3300000>;
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&pinctrl_can_xcvr>;
> > +			gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> > +		};
> >  	};
> >  
> >  	gpio-keys {
> > @@ -138,6 +149,13 @@
> >  	status = "okay";
> >  };
> >  
> > +&can1 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_can1_1>;
> > +	xceiver-supply = <&reg_can_xcvr>;
> > +	status = "okay";
> > +};
> > +
> >  &ecspi1 {
> >  	fsl,spi-num-chipselects = <1>;
> >  	cs-gpios = <&gpio3 19 0>;
> > @@ -234,6 +252,20 @@
> >  			>;
> >  		};
> >  
> > +		pinctrl_can1_1: can1grp-1 {
> 
> The '_1' suffix is meaningless.
> 
> 		pinctrl_can1: can1grp {

Thanks for review, will fix it...

Regards,
Peter

> 
> Shawn
> 
> > +			fsl,pins = <
> > +				MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> > +				MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> > +			>;
> > +		};
> > +
> > +		pinctrl_can_xcvr: can-xcvrgrp {
> > +			fsl,pins = <
> > +				/* Flexcan XCVR enable */
> > +				MX6QDL_PAD_GPIO_2__GPIO1_IO02		0x1b0b0
> > +			>;
> > +		};
> > +
> >  		pinctrl_ecspi1: ecspi1grp {
> >  			fsl,pins = <
> >  				MX6QDL_PAD_EIM_D17__ECSPI1_MISO		0x100b1
> > -- 
> > 2.1.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Aw: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
@ 2015-05-21  6:56     ` Peter Seiderer
  0 siblings, 0 replies; 13+ messages in thread
From: Peter Seiderer @ 2015-05-21  6:56 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Shawn,

> Gesendet: Donnerstag, 21. Mai 2015 um 03:33 Uhr
> Von: "Shawn Guo" <shawn.guo@linaro.org>
> An: "Peter Seiderer" <ps.report@gmx.net>
> Cc: linux-kernel at vger.kernel.org, devicetree at vger.kernel.org, linux-arm-kernel at lists.infradead.org, "Russell King" <linux@arm.linux.org.uk>, "Kumar Gala" <galak@codeaurora.org>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Mark Rutland" <mark.rutland@arm.com>, "Pawel Moll" <pawel.moll@arm.com>, "Rob Herring" <robh+dt@kernel.org>, "Sascha Hauer" <kernel@pengutronix.de>
> Betreff: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
>
> On Wed, May 20, 2015 at 11:49:29PM +0200, Peter Seiderer wrote:
> > Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration
> > taken from Boundary Devices linux kernel tree ([1] and [2]).
> > 
> > [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dts
> > [2] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi
> > 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > index fd096dc..1c415e4 100644
> > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > @@ -54,6 +54,17 @@
> >  			gpio = <&gpio3 22 0>;
> >  			enable-active-high;
> >  		};
> > +
> > +		reg_can_xcvr: regulator at 3 {
> > +			compatible = "regulator-fixed";
> > +			reg = <3>;
> > +			regulator-name = "CAN XCVR";
> > +			regulator-min-microvolt = <3300000>;
> > +			regulator-max-microvolt = <3300000>;
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&pinctrl_can_xcvr>;
> > +			gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> > +		};
> >  	};
> >  
> >  	gpio-keys {
> > @@ -138,6 +149,13 @@
> >  	status = "okay";
> >  };
> >  
> > +&can1 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_can1_1>;
> > +	xceiver-supply = <&reg_can_xcvr>;
> > +	status = "okay";
> > +};
> > +
> >  &ecspi1 {
> >  	fsl,spi-num-chipselects = <1>;
> >  	cs-gpios = <&gpio3 19 0>;
> > @@ -234,6 +252,20 @@
> >  			>;
> >  		};
> >  
> > +		pinctrl_can1_1: can1grp-1 {
> 
> The '_1' suffix is meaningless.
> 
> 		pinctrl_can1: can1grp {

Thanks for review, will fix it...

Regards,
Peter

> 
> Shawn
> 
> > +			fsl,pins = <
> > +				MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> > +				MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> > +			>;
> > +		};
> > +
> > +		pinctrl_can_xcvr: can-xcvrgrp {
> > +			fsl,pins = <
> > +				/* Flexcan XCVR enable */
> > +				MX6QDL_PAD_GPIO_2__GPIO1_IO02		0x1b0b0
> > +			>;
> > +		};
> > +
> >  		pinctrl_ecspi1: ecspi1grp {
> >  			fsl,pins = <
> >  				MX6QDL_PAD_EIM_D17__ECSPI1_MISO		0x100b1
> > -- 
> > 2.1.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-05-21  6:57 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-20 21:49 [PATCH v1] ARM: dts: nitrogen6x: add CAN support Peter Seiderer
2015-05-20 21:49 ` Peter Seiderer
2015-05-20 22:26 ` Fabio Estevam
2015-05-20 22:26   ` Fabio Estevam
2015-05-20 22:26   ` Fabio Estevam
2015-05-21  6:51   ` Aw: " Peter Seiderer
2015-05-21  6:51     ` Peter Seiderer
2015-05-21  6:51     ` Peter Seiderer
2015-05-21  1:33 ` Shawn Guo
2015-05-21  1:33   ` Shawn Guo
2015-05-21  1:33   ` Shawn Guo
2015-05-21  6:56   ` Aw: " Peter Seiderer
2015-05-21  6:56     ` Peter Seiderer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.