From: Paul Gortmaker <paul.gortmaker@windriver.com> To: <linux-kernel@vger.kernel.org> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>, Russell King <linux@arm.linux.org.uk>, <linux-arm-kernel@lists.infradead.org> Subject: [PATCH 07/11] arm: use subsys_initcall in non-modular pl320 IPC code Date: Sun, 31 May 2015 20:54:08 -0400 [thread overview] Message-ID: <1433120052-18281-8-git-send-email-paul.gortmaker@windriver.com> (raw) In-Reply-To: <1433120052-18281-1-git-send-email-paul.gortmaker@windriver.com> The drivers/mailbox/pl320-ipc.o is dependent on config PL320_MBOX which is declared as a bool. Hence the code is never going to be modular. So using module_init as an alias for __initcall can be somewhat misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Also add an inclusion of init.h, as that was previously implicit. Note that direct use of __initcall is discouraged, vs. one of the priority categorized subgroups. As __initcall gets mapped onto device_initcall, our use of subsys_initcall (which seems to make sense for IPC code) will thus change this registration from level 6-device to level 4-subsys (i.e. slightly earlier). However no impact of that small difference is expected. Cc: Russell King <linux@arm.linux.org.uk> Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/mailbox/pl320-ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/pl320-ipc.c b/drivers/mailbox/pl320-ipc.c index f3755e0aa935..f80acb36ff07 100644 --- a/drivers/mailbox/pl320-ipc.c +++ b/drivers/mailbox/pl320-ipc.c @@ -195,4 +195,4 @@ static int __init ipc_init(void) { return amba_driver_register(&pl320_driver); } -module_init(ipc_init); +subsys_initcall(ipc_init); -- 2.2.1
WARNING: multiple messages have this Message-ID (diff)
From: paul.gortmaker@windriver.com (Paul Gortmaker) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/11] arm: use subsys_initcall in non-modular pl320 IPC code Date: Sun, 31 May 2015 20:54:08 -0400 [thread overview] Message-ID: <1433120052-18281-8-git-send-email-paul.gortmaker@windriver.com> (raw) In-Reply-To: <1433120052-18281-1-git-send-email-paul.gortmaker@windriver.com> The drivers/mailbox/pl320-ipc.o is dependent on config PL320_MBOX which is declared as a bool. Hence the code is never going to be modular. So using module_init as an alias for __initcall can be somewhat misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Also add an inclusion of init.h, as that was previously implicit. Note that direct use of __initcall is discouraged, vs. one of the priority categorized subgroups. As __initcall gets mapped onto device_initcall, our use of subsys_initcall (which seems to make sense for IPC code) will thus change this registration from level 6-device to level 4-subsys (i.e. slightly earlier). However no impact of that small difference is expected. Cc: Russell King <linux@arm.linux.org.uk> Cc: linux-arm-kernel at lists.infradead.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/mailbox/pl320-ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/pl320-ipc.c b/drivers/mailbox/pl320-ipc.c index f3755e0aa935..f80acb36ff07 100644 --- a/drivers/mailbox/pl320-ipc.c +++ b/drivers/mailbox/pl320-ipc.c @@ -195,4 +195,4 @@ static int __init ipc_init(void) { return amba_driver_register(&pl320_driver); } -module_init(ipc_init); +subsys_initcall(ipc_init); -- 2.2.1
next prev parent reply other threads:[~2015-06-01 0:57 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-01 0:54 [PATCH 00/11] Replace module_init with an alternate initcall in non modules Paul Gortmaker 2015-06-01 0:54 ` Paul Gortmaker 2015-06-01 0:54 ` Paul Gortmaker 2015-06-01 0:54 ` Paul Gortmaker 2015-06-01 0:54 ` [PATCH 01/11] mm: replace module_init usages with subsys_initcall in nommu.c Paul Gortmaker 2015-06-01 0:54 ` Paul Gortmaker 2015-06-01 0:54 ` [PATCH 02/11] fs/notify: don't use module_init for non-modular inotify_user code Paul Gortmaker 2015-06-01 0:54 ` [PATCH 03/11] netfilter: don't use module_init/exit in core IPV4 code Paul Gortmaker 2015-06-03 16:04 ` Pablo Neira Ayuso 2015-06-03 16:18 ` Paul Gortmaker 2015-06-01 0:54 ` [PATCH 04/11] x86: don't use module_init for non-modular core bootflag code Paul Gortmaker 2015-06-01 0:54 ` [PATCH 05/11] powerpc: use subsys_initcall for Freescale Local Bus Paul Gortmaker 2015-06-01 0:54 ` [PATCH 06/11] powerpc: don't use module_init for non-modular core hugetlb code Paul Gortmaker 2015-06-01 0:54 ` Paul Gortmaker [this message] 2015-06-01 0:54 ` [PATCH 07/11] arm: use subsys_initcall in non-modular pl320 IPC code Paul Gortmaker 2015-06-01 0:54 ` [PATCH 08/11] lib/list_sort: use late_initcall to hook in self tests Paul Gortmaker 2015-06-01 0:54 ` [PATCH 09/11] mm/page_owner.c: use late_initcall to hook in enabling Paul Gortmaker 2015-06-01 0:54 ` Paul Gortmaker 2015-06-01 0:54 ` [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall " Paul Gortmaker 2015-06-01 7:04 ` Peter Zijlstra 2015-06-01 14:11 ` Paul Gortmaker 2015-06-01 14:14 ` Peter Zijlstra 2015-06-01 15:35 ` Paul Gortmaker 2015-06-01 16:26 ` Peter Zijlstra 2015-06-01 0:54 ` [PATCH 11/11] x86: perf_event_intel_pt.c: " Paul Gortmaker 2015-06-01 7:05 ` Peter Zijlstra 2015-06-01 14:13 ` Paul Gortmaker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1433120052-18281-8-git-send-email-paul.gortmaker@windriver.com \ --to=paul.gortmaker@windriver.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.