All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>, Andy Gross <agross@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Kevin Hilman <khilman@linaro.org>,
	Russell King <linux@arm.linux.org.uk>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Lina Iyer <lina.iyer@linaro.org>
Subject: [PATCH v2 2/2] soc: qcom: spm: Fix idle on THUMB2 kernels
Date: Tue,  2 Jun 2015 12:12:58 -0700	[thread overview]
Message-ID: <1433272378-8470-3-git-send-email-sboyd@codeaurora.org> (raw)
In-Reply-To: <1433272378-8470-1-git-send-email-sboyd@codeaurora.org>

The ifc6410 firmware always enters the kernel in ARM state from
deep idle. Use the cpu_resume_arm() wrapper instead of
cpu_resume() to property switch into the THUMB2 state when we
wake up from idle.

This fixes a problem reported by Kevin Hilman on next-20150601
where the ifc6410 fails to boot a THUMB2 kernel because the
platform's firmware always enters the kernel in ARM mode from
deep idle states.

Reported-by: Kevin Hilman <khilman@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Lina Iyer <lina.iyer@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/soc/qcom/spm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c
index b562af816c0a..b04b05a0904e 100644
--- a/drivers/soc/qcom/spm.c
+++ b/drivers/soc/qcom/spm.c
@@ -260,7 +260,7 @@ static int __init qcom_cpuidle_init(struct device_node *cpu_node, int cpu)
 		/* We have atleast one power down mode */
 		cpumask_clear(&mask);
 		cpumask_set_cpu(cpu, &mask);
-		qcom_scm_set_warm_boot_addr(cpu_resume, &mask);
+		qcom_scm_set_warm_boot_addr(cpu_resume_arm, &mask);
 	}
 
 	per_cpu(qcom_idle_ops, cpu) = fns;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] soc: qcom: spm: Fix idle on THUMB2 kernels
Date: Tue,  2 Jun 2015 12:12:58 -0700	[thread overview]
Message-ID: <1433272378-8470-3-git-send-email-sboyd@codeaurora.org> (raw)
In-Reply-To: <1433272378-8470-1-git-send-email-sboyd@codeaurora.org>

The ifc6410 firmware always enters the kernel in ARM state from
deep idle. Use the cpu_resume_arm() wrapper instead of
cpu_resume() to property switch into the THUMB2 state when we
wake up from idle.

This fixes a problem reported by Kevin Hilman on next-20150601
where the ifc6410 fails to boot a THUMB2 kernel because the
platform's firmware always enters the kernel in ARM mode from
deep idle states.

Reported-by: Kevin Hilman <khilman@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Lina Iyer <lina.iyer@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/soc/qcom/spm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c
index b562af816c0a..b04b05a0904e 100644
--- a/drivers/soc/qcom/spm.c
+++ b/drivers/soc/qcom/spm.c
@@ -260,7 +260,7 @@ static int __init qcom_cpuidle_init(struct device_node *cpu_node, int cpu)
 		/* We have atleast one power down mode */
 		cpumask_clear(&mask);
 		cpumask_set_cpu(cpu, &mask);
-		qcom_scm_set_warm_boot_addr(cpu_resume, &mask);
+		qcom_scm_set_warm_boot_addr(cpu_resume_arm, &mask);
 	}
 
 	per_cpu(qcom_idle_ops, cpu) = fns;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2015-06-02 19:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 19:12 [PATCH v2 0/2] Fix cpuidle on qcom's THUMB2 kernels Stephen Boyd
2015-06-02 19:12 ` Stephen Boyd
2015-06-02 19:12 ` [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state Stephen Boyd
2015-06-02 19:12   ` Stephen Boyd
2015-06-02 23:40   ` Russell King - ARM Linux
2015-06-02 23:40     ` Russell King - ARM Linux
2015-06-03  0:11     ` Stephen Boyd
2015-06-03  0:11       ` Stephen Boyd
2015-06-08 21:33       ` Kevin Hilman
2015-06-08 21:33         ` Kevin Hilman
2015-06-08 21:38         ` Stephen Boyd
2015-06-08 21:38           ` Stephen Boyd
2015-06-08 22:03           ` Kevin Hilman
2015-06-08 22:03             ` Kevin Hilman
2015-06-09 15:29             ` Russell King - ARM Linux
2015-06-09 15:29               ` Russell King - ARM Linux
2015-06-09 18:32               ` Stephen Boyd
2015-06-09 18:32                 ` Stephen Boyd
2015-06-15  6:33   ` Uwe Kleine-König
2015-06-15  6:33     ` Uwe Kleine-König
2015-06-15 11:01     ` Russell King - ARM Linux
2015-06-15 11:01       ` Russell King - ARM Linux
2015-06-15 13:38       ` Uwe Kleine-König
2015-06-15 13:38         ` Uwe Kleine-König
2015-06-02 19:12 ` Stephen Boyd [this message]
2015-06-02 19:12   ` [PATCH v2 2/2] soc: qcom: spm: Fix idle on THUMB2 kernels Stephen Boyd
2015-06-04 16:15   ` Lina Iyer
2015-06-04 16:15     ` Lina Iyer
2015-06-02 21:23 ` [PATCH v2 0/2] Fix cpuidle on qcom's " Kevin Hilman
2015-06-02 21:23   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433272378-8470-3-git-send-email-sboyd@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=galak@codeaurora.org \
    --cc=khilman@linaro.org \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.