All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Kevin Hilman <khilman@linaro.org>,
	Andy Gross <agross@codeaurora.org>,
	Kumar Gala <galak@codeaurora.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Lina Iyer <lina.iyer@linaro.org>
Subject: Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state
Date: Tue, 2 Jun 2015 17:11:20 -0700	[thread overview]
Message-ID: <20150603001120.GA4534@codeaurora.org> (raw)
In-Reply-To: <20150602234048.GA7557@n2100.arm.linux.org.uk>

On 06/03, Russell King - ARM Linux wrote:
> On Tue, Jun 02, 2015 at 12:12:57PM -0700, Stephen Boyd wrote:
> > Some platforms always enter the kernel in the ARM state even if
> > the kernel is compiled for THUMB2. Add a small wrapper on top of
> > cpu_resume() that switches into THUMB2 state.
> > 
> > This fixes a problem reported by Kevin Hilman on next-20150601
> > where the ifc6410 fails to boot a THUMB2 kernel because the
> > platform's firmware always enters the kernel in ARM mode from
> > deep idle states.
> 
> I think this bit of the commit message isn't quite correct: this will
> only resolve the boot problem with a T2 kernel when the failing platform
> is converted to use the cpu_resume_arm() entry point.
> 
> Apart from that, the patch looks good to me, thanks.

Sure, it could say "This provides the functionality to fix a problem
reported by..."

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state
Date: Tue, 2 Jun 2015 17:11:20 -0700	[thread overview]
Message-ID: <20150603001120.GA4534@codeaurora.org> (raw)
In-Reply-To: <20150602234048.GA7557@n2100.arm.linux.org.uk>

On 06/03, Russell King - ARM Linux wrote:
> On Tue, Jun 02, 2015 at 12:12:57PM -0700, Stephen Boyd wrote:
> > Some platforms always enter the kernel in the ARM state even if
> > the kernel is compiled for THUMB2. Add a small wrapper on top of
> > cpu_resume() that switches into THUMB2 state.
> > 
> > This fixes a problem reported by Kevin Hilman on next-20150601
> > where the ifc6410 fails to boot a THUMB2 kernel because the
> > platform's firmware always enters the kernel in ARM mode from
> > deep idle states.
> 
> I think this bit of the commit message isn't quite correct: this will
> only resolve the boot problem with a T2 kernel when the failing platform
> is converted to use the cpu_resume_arm() entry point.
> 
> Apart from that, the patch looks good to me, thanks.

Sure, it could say "This provides the functionality to fix a problem
reported by..."

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-06-03  0:11 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 19:12 [PATCH v2 0/2] Fix cpuidle on qcom's THUMB2 kernels Stephen Boyd
2015-06-02 19:12 ` Stephen Boyd
2015-06-02 19:12 ` [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state Stephen Boyd
2015-06-02 19:12   ` Stephen Boyd
2015-06-02 23:40   ` Russell King - ARM Linux
2015-06-02 23:40     ` Russell King - ARM Linux
2015-06-03  0:11     ` Stephen Boyd [this message]
2015-06-03  0:11       ` Stephen Boyd
2015-06-08 21:33       ` Kevin Hilman
2015-06-08 21:33         ` Kevin Hilman
2015-06-08 21:38         ` Stephen Boyd
2015-06-08 21:38           ` Stephen Boyd
2015-06-08 22:03           ` Kevin Hilman
2015-06-08 22:03             ` Kevin Hilman
2015-06-09 15:29             ` Russell King - ARM Linux
2015-06-09 15:29               ` Russell King - ARM Linux
2015-06-09 18:32               ` Stephen Boyd
2015-06-09 18:32                 ` Stephen Boyd
2015-06-15  6:33   ` Uwe Kleine-König
2015-06-15  6:33     ` Uwe Kleine-König
2015-06-15 11:01     ` Russell King - ARM Linux
2015-06-15 11:01       ` Russell King - ARM Linux
2015-06-15 13:38       ` Uwe Kleine-König
2015-06-15 13:38         ` Uwe Kleine-König
2015-06-02 19:12 ` [PATCH v2 2/2] soc: qcom: spm: Fix idle on THUMB2 kernels Stephen Boyd
2015-06-02 19:12   ` Stephen Boyd
2015-06-04 16:15   ` Lina Iyer
2015-06-04 16:15     ` Lina Iyer
2015-06-02 21:23 ` [PATCH v2 0/2] Fix cpuidle on qcom's " Kevin Hilman
2015-06-02 21:23   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150603001120.GA4534@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=galak@codeaurora.org \
    --cc=khilman@linaro.org \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.