From: Ming Lin <mlin@kernel.org> To: Mike Snitzer <snitzer@redhat.com> Cc: axboe@fb.com, Christoph Hellwig <hch@infradead.org>, "Martin K. Petersen" <martin.petersen@oracle.com>, device-mapper development <dm-devel@redhat.com>, Ming Lei <ming.lei@canonical.com>, Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com>, Lars Ellenberg <drbd-dev@lists.linbit.com>, Philip Kelleher <pjk1939@linux.vnet.ibm.com>, Kent Overstreet <kent.overstreet@gmail.com>, Nitin Gupta <ngupta@vflare.org>, Ming Lin <ming.l@ssi.samsung.com>, Oleg Drokin <oleg.drokin@intel.com>, Al Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>, Andreas Dilger <andreas.dilger@intel.com>, Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>, lkml <linux-kernel@vger.kernel.org>, Jim Paris <jim@jtan.com>, Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>, drbd-user@lists.linbit.com, Joe Thornber <ejt@redhat.com> Subject: Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios Date: Mon, 10 Aug 2015 09:14:12 -0700 [thread overview] Message-ID: <1439223252.27204.10.camel@hasee> (raw) In-Reply-To: <20150810150216.GA22719@redhat.com> On Mon, 2015-08-10 at 11:02 -0400, Mike Snitzer wrote: > On Sun, Aug 09 2015 at 3:18am -0400, > Ming Lin <mlin@kernel.org> wrote: > > > On Sun, 2015-08-09 at 00:01 -0700, Christoph Hellwig wrote: > > > On Sat, Aug 08, 2015 at 11:55:47PM -0700, Ming Lin wrote: > > > > Will change it to MAX_BIO_SECTORS. > > > > May I add your ACK? > > > > > > Yes, please go ahead. > > > > Thanks. I'll send a new version of the series once device-mapper guy > > acks. > > > > Hi Mike, > > > > I have updated my tree. Could you pull and re-test? > > https://git.kernel.org/cgit/linux/kernel/git/mlin/linux.git/log/?h=block-generic-req > > > > The 2 thin-provisioning tests passed. > > I've merged your latest branch with my dm-4.3 branch, I had one conflict > in the merge due to the dm_merge_bvec() change from 4.2-rc6 (no > surprise). I've published the result here: > http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/log/?h=block-late-bio-splitting > > It passes the device-mapper-test-suite's 'thin-provisioning' tests. > > > Hope I can have your ACK soon. > > Shouldn't we also be using MAX_BIO_SECTORS in blkdev_issue_write_same > (instead of UINT_MAX >> 9)? I also prefer using MAX_BIO_SECTORS. Otherwise, we may have non page size aligned splits. Say, write_same 8G. Using UINT_MAX >> 9, we'll have 2 sector aligned splits in blkdev_issue_write_same(): 0 - (4G - 512 - 1) (4G - 512, 8G -1) This looks weired. Using MAX_BIO_SECTORS, we'll have 4 page size aligned splits: 0 - (2G -1) 2G - (4G - 1) 4G - (6G - 1) 6G - (8G - 1) I'll use MAX_BIO_SECTORS in blkdev_issue_write_same() if no objection. > > Aside from that, I'm in favor of seeing this late bio splitting patchset > finally land upstream (hopefully in time for the 4.3 merge, Jens?): > > Acked-by: Mike Snitzer <snitzer@redhat.com> Thanks! May I add your Ack to "PATCH: block: kill merge_bvec_fn() completely" also? > > p.s. I'll be working with Joe Thornber on optimizing DM (particularly > dm-thinp and dm-cache) once this patchset is included upstream. You'll > see I've already added a couple WIP dm-thinp patches ontop.
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lin <mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: Ming Lei <ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>, device-mapper development <dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Hellwig <hch-jcswGhMUV9g@public.gmane.org>, Alasdair Kergon <agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Lars Ellenberg <drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org>, Philip Kelleher <pjk1939-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>, Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Kent Overstreet <kent.overstreet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Nitin Gupta <ngupta-KNmc09w0p+Ednm+yROfE0A@public.gmane.org>, Ming Lin <ming.l-Vzezgt5dB6uUEJcrhfAQsw@public.gmane.org>, Oleg Drokin <oleg.drokin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>, Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>, axboe-b10kYP2dOMg@public.gmane.org, Andreas Dilger <andreas.dilger-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Martin K. Petersen" <martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>, Christoph-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, Geoff Levand <geoff-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>, lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Jim Paris <jim-XrPbb/hENzg@public.gmane.org>, Minchan Kim <minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Joe Thornber <ejt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Dongsu Park <dpark-VwIFZPTo/vqsTnJN9+BGXg@public.gmane.org>, drbd-user-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Subject: Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios Date: Mon, 10 Aug 2015 09:14:12 -0700 [thread overview] Message-ID: <1439223252.27204.10.camel@hasee> (raw) In-Reply-To: <20150810150216.GA22719-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> On Mon, 2015-08-10 at 11:02 -0400, Mike Snitzer wrote: > On Sun, Aug 09 2015 at 3:18am -0400, > Ming Lin <mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > > On Sun, 2015-08-09 at 00:01 -0700, Christoph Hellwig wrote: > > > On Sat, Aug 08, 2015 at 11:55:47PM -0700, Ming Lin wrote: > > > > Will change it to MAX_BIO_SECTORS. > > > > May I add your ACK? > > > > > > Yes, please go ahead. > > > > Thanks. I'll send a new version of the series once device-mapper guy > > acks. > > > > Hi Mike, > > > > I have updated my tree. Could you pull and re-test? > > https://git.kernel.org/cgit/linux/kernel/git/mlin/linux.git/log/?h=block-generic-req > > > > The 2 thin-provisioning tests passed. > > I've merged your latest branch with my dm-4.3 branch, I had one conflict > in the merge due to the dm_merge_bvec() change from 4.2-rc6 (no > surprise). I've published the result here: > http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/log/?h=block-late-bio-splitting > > It passes the device-mapper-test-suite's 'thin-provisioning' tests. > > > Hope I can have your ACK soon. > > Shouldn't we also be using MAX_BIO_SECTORS in blkdev_issue_write_same > (instead of UINT_MAX >> 9)? I also prefer using MAX_BIO_SECTORS. Otherwise, we may have non page size aligned splits. Say, write_same 8G. Using UINT_MAX >> 9, we'll have 2 sector aligned splits in blkdev_issue_write_same(): 0 - (4G - 512 - 1) (4G - 512, 8G -1) This looks weired. Using MAX_BIO_SECTORS, we'll have 4 page size aligned splits: 0 - (2G -1) 2G - (4G - 1) 4G - (6G - 1) 6G - (8G - 1) I'll use MAX_BIO_SECTORS in blkdev_issue_write_same() if no objection. > > Aside from that, I'm in favor of seeing this late bio splitting patchset > finally land upstream (hopefully in time for the 4.3 merge, Jens?): > > Acked-by: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Thanks! May I add your Ack to "PATCH: block: kill merge_bvec_fn() completely" also? > > p.s. I'll be working with Joe Thornber on optimizing DM (particularly > dm-thinp and dm-cache) once this patchset is included upstream. You'll > see I've already added a couple WIP dm-thinp patches ontop.
next prev parent reply other threads:[~2015-08-10 16:14 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-06 7:44 [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin 2015-07-06 7:44 ` [PATCH v5 02/11] block: simplify bio_add_page() Ming Lin 2015-07-06 7:44 ` [PATCH v5 03/11] bcache: remove driver private bio splitting code Ming Lin 2015-07-06 7:44 ` [PATCH v5 04/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin 2015-07-06 7:44 ` [PATCH v5 05/11] block: remove split code in blkdev_issue_discard Ming Lin 2015-07-06 7:44 ` [PATCH v5 06/11] md/raid5: split bio for chunk_aligned_read Ming Lin 2015-07-06 7:44 ` [PATCH v5 07/11] md/raid5: get rid of bio_fits_rdev() Ming Lin 2015-07-06 7:44 ` [PATCH v5 08/11] block: kill merge_bvec_fn() completely Ming Lin 2015-07-06 7:44 ` [PATCH v5 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin 2015-07-06 7:44 ` [PATCH v5 10/11] block: remove bio_get_nr_vecs() Ming Lin 2015-07-06 10:58 ` Steven Whitehouse 2015-07-06 17:21 ` Ming Lin 2015-07-07 9:04 ` Steven Whitehouse 2015-07-06 7:44 ` [PATCH v5 11/11] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin 2015-07-31 19:23 ` [PATCH v5 01/11] block: make generic_make_request handle " Mike Snitzer 2015-07-31 21:19 ` Ming Lin 2015-07-31 21:19 ` Ming Lin 2015-07-31 21:38 ` Mike Snitzer 2015-07-31 21:38 ` Mike Snitzer 2015-07-31 22:02 ` Ming Lin 2015-07-31 22:18 ` Ming Lin 2015-08-01 6:58 ` Ming Lin 2015-08-01 6:58 ` Ming Lin 2015-08-01 16:33 ` Mike Snitzer 2015-08-03 5:58 ` Ming Lin 2015-08-03 5:58 ` Ming Lin 2015-08-04 11:36 ` Christoph Hellwig 2015-08-05 6:03 ` Ming Lin 2015-08-05 6:03 ` Ming Lin 2015-08-07 7:30 ` Christoph Hellwig 2015-08-07 7:30 ` Christoph Hellwig 2015-08-07 23:40 ` Ming Lin 2015-08-07 23:40 ` Ming Lin 2015-08-08 0:30 ` Kent Overstreet 2015-08-08 5:17 ` Ming Lin 2015-08-08 5:17 ` Ming Lin 2015-08-08 5:22 ` Kent Overstreet 2015-08-08 12:35 ` Christoph Hellwig 2015-08-08 12:35 ` Christoph Hellwig 2015-08-08 8:52 ` [dm-devel] " Hannes Reinecke 2015-08-08 9:02 ` Kent Overstreet 2015-08-13 6:04 ` Hannes Reinecke 2015-08-07 0:00 ` Kent Overstreet 2015-08-07 7:30 ` Christoph Hellwig 2015-08-07 7:30 ` Christoph Hellwig 2015-08-08 16:19 ` [dm-devel] " Martin K. Petersen 2015-08-08 16:19 ` Martin K. Petersen 2015-08-09 5:59 ` Ming Lin 2015-08-09 5:59 ` Ming Lin 2015-08-09 6:41 ` Christoph Hellwig 2015-08-09 6:41 ` Christoph Hellwig 2015-08-09 6:55 ` Ming Lin 2015-08-09 6:55 ` Ming Lin 2015-08-09 7:01 ` Christoph Hellwig 2015-08-09 7:01 ` Christoph Hellwig 2015-08-09 7:18 ` Ming Lin 2015-08-09 7:18 ` Ming Lin 2015-08-10 15:02 ` Mike Snitzer 2015-08-10 15:02 ` Mike Snitzer 2015-08-10 16:14 ` Ming Lin [this message] 2015-08-10 16:14 ` Ming Lin 2015-08-10 16:18 ` Ming Lin 2015-08-10 16:18 ` Ming Lin 2015-08-10 16:40 ` Martin K. Petersen 2015-08-10 16:40 ` Martin K. Petersen 2015-08-10 18:13 ` Mike Snitzer 2015-08-10 22:30 ` Ming Lin 2015-08-10 22:30 ` Ming Lin 2015-08-10 16:22 ` Martin K. Petersen 2015-08-10 16:22 ` Martin K. Petersen 2015-08-10 18:18 ` Ming Lin 2015-08-11 2:00 ` Martin K. Petersen 2015-08-11 2:00 ` Martin K. Petersen 2015-08-11 2:41 ` Mike Snitzer 2015-08-11 2:41 ` Mike Snitzer 2015-08-11 3:38 ` Kent Overstreet 2015-08-11 14:08 ` Mike Snitzer 2015-08-11 14:08 ` Mike Snitzer 2015-08-11 17:49 ` Martin K. Petersen 2015-08-11 17:49 ` Martin K. Petersen 2015-08-11 18:05 ` Martin K. Petersen 2015-08-11 18:05 ` Martin K. Petersen 2015-08-11 20:56 ` Ming Lin 2015-08-11 20:56 ` Ming Lin 2015-08-12 0:24 ` Martin K. Petersen 2015-08-12 0:24 ` Martin K. Petersen 2015-08-12 4:41 ` Ming Lin 2015-08-12 4:41 ` Ming Lin 2015-08-11 17:36 ` Martin K. Petersen 2015-08-11 17:36 ` Martin K. Petersen 2015-08-11 17:47 ` Mike Snitzer 2015-08-11 17:47 ` Mike Snitzer 2015-08-11 18:01 ` [dm-devel] " Martin K. Petersen 2015-08-11 18:01 ` Martin K. Petersen 2015-08-18 5:09 ` Ming Lin 2015-08-18 7:04 ` Ming Lin 2015-08-18 14:45 ` Mike Snitzer 2015-08-18 17:32 ` Ming Lin 2015-08-18 19:59 ` Mike Snitzer 2015-08-18 21:16 ` Ming Lin 2015-08-18 21:22 ` Mike Snitzer 2015-08-18 22:17 ` Ming Lin -- strict thread matches above, loose matches on Subject: below -- 2015-07-06 7:11 [PATCH v5 00/11] simplify block layer based on immutable biovecs mlin 2015-07-06 7:11 ` [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios mlin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1439223252.27204.10.camel@hasee \ --to=mlin@kernel.org \ --cc=agk@redhat.com \ --cc=andreas.dilger@intel.com \ --cc=axboe@fb.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=dpark@posteo.net \ --cc=drbd-dev@lists.linbit.com \ --cc=drbd-user@lists.linbit.com \ --cc=ejt@redhat.com \ --cc=geoff@infradead.org \ --cc=hch@infradead.org \ --cc=hch@lst.de \ --cc=jim@jtan.com \ --cc=jkosina@suse.cz \ --cc=kent.overstreet@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=minchan@kernel.org \ --cc=ming.l@ssi.samsung.com \ --cc=ming.lei@canonical.com \ --cc=ngupta@vflare.org \ --cc=oleg.drokin@intel.com \ --cc=pjk1939@linux.vnet.ibm.com \ --cc=snitzer@redhat.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.