[PATCH] bash: Disable custom memory allocator

[PATCH] bash: Disable custom memory allocator

[Aníbal Limón]

Bash is failing trying to allocate memory [1] using the custom
memory allocator if we disable it the issue is fixed.

The major distributions also disabled by default [2], so we
don't have a good reason to use it.

[YOCTO #8452]

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c0
[2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c5

Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
 meta/recipes-extended/bash/bash.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
index c06f157..020409f 100644
--- a/meta/recipes-extended/bash/bash.inc
+++ b/meta/recipes-extended/bash/bash.inc
@@ -7,7 +7,7 @@ DEPENDS = "ncurses bison-native"
 inherit autotools gettext texinfo update-alternatives ptest
 
 EXTRA_AUTORECONF += "--exclude=autoheader"
-EXTRA_OECONF = "--enable-job-control"
+EXTRA_OECONF = "--enable-job-control --without-bash-malloc"
 
 # If NON_INTERACTIVE_LOGIN_SHELLS is defined, all login shells read the
 # startup files, even if they are not interactive.
-- 
1.9.1

Re: [PATCH] bash: Disable custom memory allocator

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]


> On Oct 9, 2015, at 3:21 PM, Aníbal Limón <anibal.limon@linux.intel.com> wrote:
> 
> Bash is failing trying to allocate memory [1] using the custom
> memory allocator if we disable it the issue is fixed.
> 
> The major distributions also disabled by default [2], so we
> don't have a good reason to use it.

The fix is OK but commit message needs improvement. The underlying issue is due to bash’s malloc using brk() calls
to allocate memory, which fail when address randomization is enabled in kernel. sbrk() based custom allocators are obsolete
on the downside we will lose a bit of performance but correctness is more important here.

> 
> [YOCTO #8452]
> 
> [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c0
> [2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c5
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> meta/recipes-extended/bash/bash.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
> index c06f157..020409f 100644
> --- a/meta/recipes-extended/bash/bash.inc
> +++ b/meta/recipes-extended/bash/bash.inc
> @@ -7,7 +7,7 @@ DEPENDS = "ncurses bison-native"
> inherit autotools gettext texinfo update-alternatives ptest
> 
> EXTRA_AUTORECONF += "--exclude=autoheader"
> -EXTRA_OECONF = "--enable-job-control"
> +EXTRA_OECONF = "--enable-job-control --without-bash-malloc"
> 
> # If NON_INTERACTIVE_LOGIN_SHELLS is defined, all login shells read the
> # startup files, even if they are not interactive.
> --
> 1.9.1
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH] bash: Disable custom memory allocator

[Benjamin Esquivel]

Hey Anibal, a line or 2 in mentioning the issue at the git commit
message would be required. You're only mentioning that there is an
issue and it would be informational to say what it is, even though the
bug number is at the end.

On Fri, 2015-10-09 at 17:21 -0500, Aníbal Limón wrote:
> Bash is failing trying to allocate memory [1] using the custom
> memory allocator if we disable it the issue is fixed.
> 
> The major distributions also disabled by default [2], so we
> don't have a good reason to use it.
> 
> [YOCTO #8452]
> 
> [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c0
> [2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c5
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  meta/recipes-extended/bash/bash.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes
> -extended/bash/bash.inc
> index c06f157..020409f 100644
> --- a/meta/recipes-extended/bash/bash.inc
> +++ b/meta/recipes-extended/bash/bash.inc
> @@ -7,7 +7,7 @@ DEPENDS = "ncurses bison-native"
>  inherit autotools gettext texinfo update-alternatives ptest
>  
>  EXTRA_AUTORECONF += "--exclude=autoheader"
> -EXTRA_OECONF = "--enable-job-control"
> +EXTRA_OECONF = "--enable-job-control --without-bash-malloc"
>  
>  # If NON_INTERACTIVE_LOGIN_SHELLS is defined, all login shells read
> the
>  # startup files, even if they are not interactive.

Re: [PATCH] bash: Disable custom memory allocator

[Aníbal Limón]

Hi Benjamin,

This commit is already merged Ross or RP improved the message.

Cheers,
     alimon

On 13/10/15 10:58, Benjamin Esquivel wrote:
> Hey Anibal, a line or 2 in mentioning the issue at the git commit
> message would be required. You're only mentioning that there is an
> issue and it would be informational to say what it is, even though the
> bug number is at the end.
>
> On Fri, 2015-10-09 at 17:21 -0500, Aníbal Limón wrote:
>> Bash is failing trying to allocate memory [1] using the custom
>> memory allocator if we disable it the issue is fixed.
>>
>> The major distributions also disabled by default [2], so we
>> don't have a good reason to use it.
>>
>> [YOCTO #8452]
>>
>> [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c0
>> [2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c5
>>
>> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
>> ---
>>   meta/recipes-extended/bash/bash.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes
>> -extended/bash/bash.inc
>> index c06f157..020409f 100644
>> --- a/meta/recipes-extended/bash/bash.inc
>> +++ b/meta/recipes-extended/bash/bash.inc
>> @@ -7,7 +7,7 @@ DEPENDS = "ncurses bison-native"
>>   inherit autotools gettext texinfo update-alternatives ptest
>>   
>>   EXTRA_AUTORECONF += "--exclude=autoheader"
>> -EXTRA_OECONF = "--enable-job-control"
>> +EXTRA_OECONF = "--enable-job-control --without-bash-malloc"
>>   
>>   # If NON_INTERACTIVE_LOGIN_SHELLS is defined, all login shells read
>> the
>>   # startup files, even if they are not interactive.

Re: [PATCH] bash: Disable custom memory allocator

[Benjamin Esquivel]

Great!

On Tue, 2015-10-13 at 11:06 -0500, Aníbal Limón wrote:
> Hi Benjamin,
> 
> This commit is already merged Ross or RP improved the message.
> 
> Cheers,
>      alimon
> 
> On 13/10/15 10:58, Benjamin Esquivel wrote:
> > Hey Anibal, a line or 2 in mentioning the issue at the git commit
> > message would be required. You're only mentioning that there is an
> > issue and it would be informational to say what it is, even though
> > the
> > bug number is at the end.
> > 
> > On Fri, 2015-10-09 at 17:21 -0500, Aníbal Limón wrote:
> > > Bash is failing trying to allocate memory [1] using the custom
> > > memory allocator if we disable it the issue is fixed.
> > > 
> > > The major distributions also disabled by default [2], so we
> > > don't have a good reason to use it.
> > > 
> > > [YOCTO #8452]
> > > 
> > > [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c0
> > > [2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c5
> > > 
> > > Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> > > ---
> > >   meta/recipes-extended/bash/bash.inc | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes
> > > -extended/bash/bash.inc
> > > index c06f157..020409f 100644
> > > --- a/meta/recipes-extended/bash/bash.inc
> > > +++ b/meta/recipes-extended/bash/bash.inc
> > > @@ -7,7 +7,7 @@ DEPENDS = "ncurses bison-native"
> > >   inherit autotools gettext texinfo update-alternatives ptest
> > >   
> > >   EXTRA_AUTORECONF += "--exclude=autoheader"
> > > -EXTRA_OECONF = "--enable-job-control"
> > > +EXTRA_OECONF = "--enable-job-control --without-bash-malloc"
> > >   
> > >   # If NON_INTERACTIVE_LOGIN_SHELLS is defined, all login shells
> > > read
> > > the
> > >   # startup files, even if they are not interactive.
> 

Re: [PATCH] bash: Disable custom memory allocator

[Richard Purdie]

On Tue, 2015-10-13 at 11:06 -0500, Aníbal Limón wrote:
> Hi Benjamin,
> 
> This commit is already merged Ross or RP improved the message.

I did that since I wanted to get the fix merged due to the issues it was
causing on the autobuilder and with the release. Nice find btw!

Cheers,

Richard