* [Qemu-devel] [PATCH] configure: check for $cxx before use
@ 2015-11-12 16:29 John Snow
2015-11-12 16:47 ` Laurent Vivier
2015-11-12 16:54 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: John Snow @ 2015-11-12 16:29 UTC (permalink / raw)
To: qemu-devel; +Cc: lvivier, peter.maydell, John Snow
I broke this when adding checks for clang++.
Reported-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 46fd8bd..f75df4b 100755
--- a/configure
+++ b/configure
@@ -4435,7 +4435,8 @@ fi
if test "$fortify_source" != "no"; then
if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
fortify_source="no";
- elif echo | $cxx -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
+ elif test -n "$cxx" &&
+ echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then
fortify_source="no";
else
fortify_source="yes"
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: check for $cxx before use
2015-11-12 16:29 [Qemu-devel] [PATCH] configure: check for $cxx before use John Snow
@ 2015-11-12 16:47 ` Laurent Vivier
2015-11-12 16:54 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2015-11-12 16:47 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: peter.maydell
On 12/11/2015 17:29, John Snow wrote:
> I broke this when adding checks for clang++.
>
> Reported-by: Laurent Vivier <lvivier@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
>
> ---
> configure | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 46fd8bd..f75df4b 100755
> --- a/configure
> +++ b/configure
> @@ -4435,7 +4435,8 @@ fi
> if test "$fortify_source" != "no"; then
> if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
> fortify_source="no";
> - elif echo | $cxx -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
> + elif test -n "$cxx" &&
> + echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then
> fortify_source="no";
> else
> fortify_source="yes"
>
This fixes the problem: no more error message.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: check for $cxx before use
2015-11-12 16:29 [Qemu-devel] [PATCH] configure: check for $cxx before use John Snow
2015-11-12 16:47 ` Laurent Vivier
@ 2015-11-12 16:54 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2015-11-12 16:54 UTC (permalink / raw)
To: John Snow; +Cc: Laurent Vivier, QEMU Developers
On 12 November 2015 at 16:29, John Snow <jsnow@redhat.com> wrote:
> I broke this when adding checks for clang++.
>
> Reported-by: Laurent Vivier <lvivier@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
>
> ---
> configure | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 46fd8bd..f75df4b 100755
> --- a/configure
> +++ b/configure
> @@ -4435,7 +4435,8 @@ fi
> if test "$fortify_source" != "no"; then
> if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
> fortify_source="no";
> - elif echo | $cxx -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
> + elif test -n "$cxx" &&
> + echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then
> fortify_source="no";
> else
> fortify_source="yes"
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
I'll apply it directly to master as a buildfix.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-12 16:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 16:29 [Qemu-devel] [PATCH] configure: check for $cxx before use John Snow
2015-11-12 16:47 ` Laurent Vivier
2015-11-12 16:54 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.