From: Petr Mladek <pmladek@suse.com> To: Andrew Morton <akpm@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Josh Triplett <josh@joshtriplett.org>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org>, Jiri Kosina <jkosina@suse.cz>, Borislav Petkov <bp@suse.de>, Michal Hocko <mhocko@suse.cz>, linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com> Subject: [PATCH v3 12/22] kthread: Use try_lock_kthread_work() in flush_kthread_work() Date: Wed, 18 Nov 2015 14:25:17 +0100 [thread overview] Message-ID: <1447853127-3461-13-git-send-email-pmladek@suse.com> (raw) In-Reply-To: <1447853127-3461-1-git-send-email-pmladek@suse.com> Remove code duplication and use the new try_lock_kthread_work() function in flush_kthread_work() as well. Signed-off-by: Petr Mladek <pmladek@suse.com> --- kernel/kthread.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/kernel/kthread.c b/kernel/kthread.c index dbd090466e2a..f7caaaca5825 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -933,16 +933,12 @@ void flush_kthread_work(struct kthread_work *work) struct kthread_worker *worker; bool noop = false; -retry: - worker = work->worker; - if (!worker) + local_irq_disable(); + if (!try_lock_kthread_work(work)) { + local_irq_enable(); return; - - spin_lock_irq(&worker->lock); - if (work->worker != worker) { - spin_unlock_irq(&worker->lock); - goto retry; } + worker = work->worker; if (!list_empty(&work->node)) insert_kthread_work(worker, &fwork.work, work->node.next); -- 1.8.5.6
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com> To: Andrew Morton <akpm@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Josh Triplett <josh@joshtriplett.org>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org>, Jiri Kosina <jkosina@suse.cz>, Borislav Petkov <bp@suse.de>, Michal Hocko <mhocko@suse.cz>, linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com> Subject: [PATCH v3 12/22] kthread: Use try_lock_kthread_work() in flush_kthread_work() Date: Wed, 18 Nov 2015 14:25:17 +0100 [thread overview] Message-ID: <1447853127-3461-13-git-send-email-pmladek@suse.com> (raw) In-Reply-To: <1447853127-3461-1-git-send-email-pmladek@suse.com> Remove code duplication and use the new try_lock_kthread_work() function in flush_kthread_work() as well. Signed-off-by: Petr Mladek <pmladek@suse.com> --- kernel/kthread.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/kernel/kthread.c b/kernel/kthread.c index dbd090466e2a..f7caaaca5825 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -933,16 +933,12 @@ void flush_kthread_work(struct kthread_work *work) struct kthread_worker *worker; bool noop = false; -retry: - worker = work->worker; - if (!worker) + local_irq_disable(); + if (!try_lock_kthread_work(work)) { + local_irq_enable(); return; - - spin_lock_irq(&worker->lock); - if (work->worker != worker) { - spin_unlock_irq(&worker->lock); - goto retry; } + worker = work->worker; if (!list_empty(&work->node)) insert_kthread_work(worker, &fwork.work, work->node.next); -- 1.8.5.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-18 13:30 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-18 13:25 [PATCH v3 00/22] kthread: Use kthread worker API more widely Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 01/22] timer: Allow to check when the timer callback has not finished yet Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 22:32 ` Thomas Gleixner 2015-11-18 22:32 ` Thomas Gleixner 2015-11-19 12:43 ` Petr Mladek 2015-11-19 12:43 ` Petr Mladek 2015-11-19 12:43 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 02/22] kthread/smpboot: Do not park in kthread_create_on_cpu() Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-25 21:16 ` Thomas Gleixner 2015-11-25 21:16 ` Thomas Gleixner 2015-11-25 21:16 ` Thomas Gleixner 2015-11-18 13:25 ` [PATCH v3 03/22] kthread: Allow to call __kthread_create_on_node() with va_list args Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 04/22] kthread: Add create_kthread_worker*() Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 05/22] kthread: Add drain_kthread_worker() Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 06/22] kthread: Add destroy_kthread_worker() Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 07/22] kthread: Detect when a kthread work is used by more workers Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-23 22:27 ` Tejun Heo 2015-11-23 22:27 ` Tejun Heo 2015-11-24 10:06 ` Petr Mladek 2015-11-24 10:06 ` Petr Mladek 2015-11-24 10:06 ` Petr Mladek 2015-11-24 14:49 ` Tejun Heo 2015-11-24 14:49 ` Tejun Heo 2015-11-24 16:28 ` Petr Mladek 2015-11-24 16:28 ` Petr Mladek 2015-11-24 14:56 ` Peter Zijlstra 2015-11-24 14:56 ` Peter Zijlstra 2015-11-24 14:56 ` Peter Zijlstra 2015-11-18 13:25 ` [PATCH v3 08/22] kthread: Initial support for delayed kthread work Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 09/22] kthread: Allow to cancel " Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-23 22:58 ` Tejun Heo 2015-11-23 22:58 ` Tejun Heo 2015-11-23 22:58 ` Tejun Heo 2015-11-24 10:21 ` Petr Mladek 2015-11-24 10:21 ` Petr Mladek 2015-11-24 20:23 ` Linus Torvalds 2015-11-24 20:23 ` Linus Torvalds 2015-11-24 20:23 ` Linus Torvalds 2015-11-24 20:28 ` Tejun Heo 2015-11-24 20:28 ` Tejun Heo 2015-11-24 20:28 ` Tejun Heo 2015-11-24 20:49 ` Linus Torvalds 2015-11-24 20:49 ` Linus Torvalds 2015-11-18 13:25 ` [PATCH v3 10/22] kthread: Allow to modify delayed " Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 11/22] kthread: Better support freezable kthread workers Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` Petr Mladek [this message] 2015-11-18 13:25 ` [PATCH v3 12/22] kthread: Use try_lock_kthread_work() in flush_kthread_work() Petr Mladek 2015-11-18 13:25 ` [PATCH v3 13/22] mm/huge_page: Convert khugepaged() into kthread worker API Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 14/22] ring_buffer: Convert benchmark kthreads " Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 15/22] hung_task: Convert hungtaskd " Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 16/22] kmemleak: Convert kmemleak kthread " Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 17/22] ipmi: Convert kipmi " Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-23 19:36 ` Corey Minyard 2015-11-23 19:36 ` Corey Minyard 2015-11-24 12:12 ` Petr Mladek 2015-11-24 12:12 ` Petr Mladek 2015-11-24 12:12 ` Petr Mladek 2015-11-24 13:30 ` Corey Minyard 2015-11-24 13:30 ` Corey Minyard 2015-11-24 13:30 ` Corey Minyard 2015-11-18 13:25 ` [PATCH v3 18/22] IB/fmr_pool: Convert the cleanup thread " Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-19 12:46 ` Yuval Shaia 2015-11-19 12:46 ` Yuval Shaia 2015-11-18 13:25 ` [PATCH v3 19/22] memstick/r592: Better synchronize debug messages in r592_io kthread Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 20/22] memstick/r592: convert r592_io kthread into kthread worker API Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 21/22] thermal/intel_powerclamp: Remove duplicated code that starts the kthread Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2015-11-18 13:25 ` [PATCH v3 22/22] thermal/intel_powerclamp: Convert the kthread to kthread worker API Petr Mladek 2015-11-18 13:25 ` Petr Mladek 2016-01-07 19:55 ` Jacob Pan 2016-01-07 19:55 ` Jacob Pan 2016-01-08 16:49 ` Petr Mladek 2016-01-08 16:49 ` Petr Mladek 2016-01-12 2:17 ` Jacob Pan 2016-01-12 2:17 ` Jacob Pan 2016-01-12 10:11 ` Petr Mladek 2016-01-12 10:11 ` Petr Mladek 2016-01-12 16:20 ` Jacob Pan 2016-01-12 16:20 ` Jacob Pan 2016-01-13 10:18 ` Petr Mladek 2016-01-13 10:18 ` Petr Mladek 2016-01-13 10:18 ` Petr Mladek 2016-01-13 17:53 ` Jacob Pan 2016-01-13 17:53 ` Jacob Pan 2016-01-14 15:37 ` Petr Mladek 2016-01-14 15:37 ` Petr Mladek 2015-11-18 14:25 ` [PATCH v3 00/22] kthread: Use kthread worker API more widely Paul E. McKenney 2015-11-18 14:25 ` Paul E. McKenney 2015-11-18 14:25 ` Paul E. McKenney
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1447853127-3461-13-git-send-email-pmladek@suse.com \ --to=pmladek@suse.com \ --cc=akpm@linux-foundation.org \ --cc=bp@suse.de \ --cc=jkosina@suse.cz \ --cc=josh@joshtriplett.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.cz \ --cc=mingo@redhat.com \ --cc=oleg@redhat.com \ --cc=paulmck@linux.vnet.ibm.com \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=torvalds@linux-foundation.org \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.