All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Arnd Bergmann <arnd@arndb.de>, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Jingoo Han <jingoohan1@gmail.com>,
	Pratyush Anand <pratyush.anand@gmail.com>,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: [PATCH v4 1/5] PCI: designware: add memory barrier after enabling region
Date: Thu,  3 Dec 2015 15:35:20 +0200	[thread overview]
Message-ID: <1449149725-27607-2-git-send-email-stanimir.varbanov@linaro.org> (raw)
In-Reply-To: <1449149725-27607-1-git-send-email-stanimir.varbanov@linaro.org>

Add 'write memory' barrier after enable region in PCIE_ATU_CR2
register. The barrier is needed to ensure that the region enable
request has been reached it's destination at time when we
read/write to PCI configuration space.

Without this barrier PCI device enumeration during kernel boot
is not reliable, and reading configuration space for particular
PCI device on the bus returns zero aka no device.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
 drivers/pci/host/pcie-designware.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 02a7452bdf23..ed4dc2e2553b 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -164,6 +164,11 @@ static void dw_pcie_prog_outbound_atu(struct pcie_port *pp, int index,
 	dw_pcie_writel_rc(pp, upper_32_bits(pci_addr), PCIE_ATU_UPPER_TARGET);
 	dw_pcie_writel_rc(pp, type, PCIE_ATU_CR1);
 	dw_pcie_writel_rc(pp, PCIE_ATU_ENABLE, PCIE_ATU_CR2);
+	/*
+	 * ensure that the ATU enable has been happaned before accessing
+	 * pci configuration/io spaces through dw_pcie_cfg_[read|write].
+	 */
+	wmb();
 }
 
 static struct irq_chip dw_msi_irq_chip = {
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Arnd Bergmann <arnd@arndb.de>, Jingoo Han <jingoohan1@gmail.com>,
	Pratyush Anand <pratyush.anand@gmail.com>,
	Bjorn Andersson <bjorn.andersson@sonymobile.com>,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>
Subject: [PATCH v4 1/5] PCI: designware: add memory barrier after enabling region
Date: Thu,  3 Dec 2015 15:35:20 +0200	[thread overview]
Message-ID: <1449149725-27607-2-git-send-email-stanimir.varbanov@linaro.org> (raw)
In-Reply-To: <1449149725-27607-1-git-send-email-stanimir.varbanov@linaro.org>

Add 'write memory' barrier after enable region in PCIE_ATU_CR2
register. The barrier is needed to ensure that the region enable
request has been reached it's destination at time when we
read/write to PCI configuration space.

Without this barrier PCI device enumeration during kernel boot
is not reliable, and reading configuration space for particular
PCI device on the bus returns zero aka no device.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
 drivers/pci/host/pcie-designware.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 02a7452bdf23..ed4dc2e2553b 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -164,6 +164,11 @@ static void dw_pcie_prog_outbound_atu(struct pcie_port *pp, int index,
 	dw_pcie_writel_rc(pp, upper_32_bits(pci_addr), PCIE_ATU_UPPER_TARGET);
 	dw_pcie_writel_rc(pp, type, PCIE_ATU_CR1);
 	dw_pcie_writel_rc(pp, PCIE_ATU_ENABLE, PCIE_ATU_CR2);
+	/*
+	 * ensure that the ATU enable has been happaned before accessing
+	 * pci configuration/io spaces through dw_pcie_cfg_[read|write].
+	 */
+	wmb();
 }
 
 static struct irq_chip dw_msi_irq_chip = {
-- 
1.7.9.5


WARNING: multiple messages have this Message-ID (diff)
From: stanimir.varbanov@linaro.org (Stanimir Varbanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/5] PCI: designware: add memory barrier after enabling region
Date: Thu,  3 Dec 2015 15:35:20 +0200	[thread overview]
Message-ID: <1449149725-27607-2-git-send-email-stanimir.varbanov@linaro.org> (raw)
In-Reply-To: <1449149725-27607-1-git-send-email-stanimir.varbanov@linaro.org>

Add 'write memory' barrier after enable region in PCIE_ATU_CR2
register. The barrier is needed to ensure that the region enable
request has been reached it's destination at time when we
read/write to PCI configuration space.

Without this barrier PCI device enumeration during kernel boot
is not reliable, and reading configuration space for particular
PCI device on the bus returns zero aka no device.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
 drivers/pci/host/pcie-designware.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 02a7452bdf23..ed4dc2e2553b 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -164,6 +164,11 @@ static void dw_pcie_prog_outbound_atu(struct pcie_port *pp, int index,
 	dw_pcie_writel_rc(pp, upper_32_bits(pci_addr), PCIE_ATU_UPPER_TARGET);
 	dw_pcie_writel_rc(pp, type, PCIE_ATU_CR1);
 	dw_pcie_writel_rc(pp, PCIE_ATU_ENABLE, PCIE_ATU_CR2);
+	/*
+	 * ensure that the ATU enable has been happaned before accessing
+	 * pci configuration/io spaces through dw_pcie_cfg_[read|write].
+	 */
+	wmb();
 }
 
 static struct irq_chip dw_msi_irq_chip = {
-- 
1.7.9.5

  reply	other threads:[~2015-12-03 13:35 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 13:35 [PATCH v4 0/5] Qualcomm PCIe driver and designware fixes Stanimir Varbanov
2015-12-03 13:35 ` Stanimir Varbanov
2015-12-03 13:35 ` Stanimir Varbanov [this message]
2015-12-03 13:35   ` [PATCH v4 1/5] PCI: designware: add memory barrier after enabling region Stanimir Varbanov
2015-12-03 13:35   ` Stanimir Varbanov
2015-12-08  9:01   ` Stanimir Varbanov
2015-12-08  9:01     ` Stanimir Varbanov
2015-12-09  4:40     ` Pratyush Anand
2015-12-09  4:40       ` Pratyush Anand
2015-12-09  4:40       ` Pratyush Anand
2015-12-09  9:52       ` Arnd Bergmann
2015-12-09  9:52         ` Arnd Bergmann
2015-12-09  9:52         ` Arnd Bergmann
2015-12-09 10:29         ` Stanimir Varbanov
2015-12-09 10:29           ` Stanimir Varbanov
2015-12-09 10:29           ` Stanimir Varbanov
2015-12-09 10:23       ` Russell King - ARM Linux
2015-12-09 10:23         ` Russell King - ARM Linux
2015-12-09 10:23         ` Russell King - ARM Linux
2015-12-11  4:05         ` Pratyush Anand
2015-12-11  4:05           ` Pratyush Anand
2015-12-11  4:05           ` Pratyush Anand
2015-12-11  5:48           ` Jisheng Zhang
2015-12-11  5:48             ` Jisheng Zhang
2015-12-11  5:48             ` Jisheng Zhang
2015-12-11  5:48             ` Jisheng Zhang
2015-12-22 12:36             ` Jingoo Han
2015-12-22 12:36               ` Jingoo Han
2015-12-22 12:36               ` Jingoo Han
2015-12-17 15:45           ` Stanimir Varbanov
2015-12-17 15:45             ` Stanimir Varbanov
2015-12-17 15:45             ` Stanimir Varbanov
2015-12-17 15:51             ` Pratyush Anand
2015-12-17 15:51               ` Pratyush Anand
2015-12-17 15:51               ` Pratyush Anand
2015-12-03 13:35 ` [PATCH v4 3/5] PCI: qcom: Add Qualcomm PCIe controller driver Stanimir Varbanov
2015-12-03 13:35   ` Stanimir Varbanov
2015-12-15  8:24   ` Stanimir Varbanov
2015-12-15  8:24     ` Stanimir Varbanov
2015-12-16 21:17     ` Bjorn Helgaas
2015-12-16 21:17       ` Bjorn Helgaas
2015-12-16 21:53   ` Bjorn Helgaas
2015-12-16 21:53     ` Bjorn Helgaas
2015-12-17 13:18     ` Stanimir Varbanov
2015-12-17 13:18       ` Stanimir Varbanov
2015-12-17 21:15       ` Bjorn Helgaas
2015-12-17 21:15         ` Bjorn Helgaas
     [not found] ` <1449149725-27607-1-git-send-email-stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-12-03 13:35   ` [PATCH v4 2/5] DT: PCI: qcom: Document PCIe devicetree bindings Stanimir Varbanov
2015-12-03 13:35     ` Stanimir Varbanov
2015-12-03 13:35     ` Stanimir Varbanov
2015-12-03 20:42     ` Rob Herring
2015-12-03 20:42       ` Rob Herring
2015-12-03 13:35   ` [PATCH v4 4/5] ARM: dts: apq8064: add pcie devicetree node Stanimir Varbanov
2015-12-03 13:35     ` Stanimir Varbanov
2015-12-03 13:35     ` Stanimir Varbanov
2015-12-03 13:35 ` [PATCH v4 5/5] ARM: dts: ifc6410: enable pcie dt node for this board Stanimir Varbanov
2015-12-03 13:35   ` Stanimir Varbanov
     [not found]   ` <1449149725-27607-6-git-send-email-stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-12-17 21:55     ` Bjorn Andersson
2015-12-17 21:55       ` Bjorn Andersson
2015-12-17 21:55       ` Bjorn Andersson
2015-12-17 21:55       ` Bjorn Andersson
2015-12-18  9:57       ` Stanimir Varbanov
2015-12-18  9:57         ` Stanimir Varbanov
2015-12-18  9:57         ` Stanimir Varbanov
2015-12-07 17:33 ` [PATCH v4 0/5] Qualcomm PCIe driver and designware fixes Srinivas Kandagatla
2015-12-07 17:33   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449149725-27607-2-git-send-email-stanimir.varbanov@linaro.org \
    --to=stanimir.varbanov@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jingoohan1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=pratyush.anand@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.