From: Stanimir Varbanov <stanimir.varbanov@linaro.org> To: Bjorn Helgaas <helgaas@kernel.org>, Stanimir Varbanov <stanimir.varbanov@linaro.org> Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Arnd Bergmann <arnd@arndb.de>, Jingoo Han <jingoohan1@gmail.com>, Pratyush Anand <pratyush.anand@gmail.com>, Bjorn Andersson <bjorn.andersson@sonymobile.com> Subject: Re: [PATCH v4 3/5] PCI: qcom: Add Qualcomm PCIe controller driver Date: Thu, 17 Dec 2015 15:18:43 +0200 [thread overview] Message-ID: <5672B633.6030503@linaro.org> (raw) In-Reply-To: <20151216215304.GB27791@localhost> Bjorn, thanks for the comments! On 12/16/2015 11:53 PM, Bjorn Helgaas wrote: > On Thu, Dec 03, 2015 at 03:35:22PM +0200, Stanimir Varbanov wrote: >> From: Stanimir Varbanov <svarbanov@mm-sol.com> >> >> The PCIe driver reuse the Designware common code for host >> and MSI initialization, and also program the Qualcomm >> application specific registers. >> >> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com> >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> >> --- >> MAINTAINERS | 7 + >> drivers/pci/host/Kconfig | 10 + >> drivers/pci/host/Makefile | 1 + >> drivers/pci/host/pcie-qcom.c | 624 ++++++++++++++++++++++++++++++++++++++++++ > >> +#define PCIE20_CAP 0x70 >> +#define PCIE20_CAP_LINKCTRLSTATUS (PCIE20_CAP + 0x10) >> +#define PCIE20_CAP_LINKCTRLSTATUS_LINK_UP BIT(29) > > This looks like it could be referring to a standard PCIe Capability; > could you use the existing PCI_EXP_LNKSTA and PCI_EXP_LNKSTA_DLLLA > symbols here? And readw() instead of readl()? Yes, that is possible but I still need to keep PCIE20_CAP capabilities offset. > >> +static int qcom_pcie_enable_link_training(struct qcom_pcie *pcie) >> +{ >> + struct device *dev = pcie->dev; >> + u32 val; >> + int ret; >> + >> + /* enable link training */ >> + val = readl(pcie->elbi + PCIE20_ELBI_SYS_CTRL); >> + val |= PCIE20_ELBI_SYS_CTRL_LT_ENABLE; >> + writel(val, pcie->elbi + PCIE20_ELBI_SYS_CTRL); >> + >> + /* wait for up to 100ms for the link to come up */ >> + ret = readl_poll_timeout(pcie->elbi + PCIE20_ELBI_SYS_STTS, val, >> + val & XMLH_LINK_UP, LINKUP_DELAY_US, >> + LINKUP_TIMEOUT_US); >> + >> + if (ret < 0 || !dw_pcie_link_up(&pcie->pp)) { >> + dev_err(dev, "link initialization failed\n"); >> + return -ETIMEDOUT; >> + } >> + >> + return 0; >> +} > > This looks a lot like the *_establish_link() functions in other > DesignWare-based drivers. Can you make it look even more similar, > e.g., by renaming it to qcom_pcie_establish_link() and maybe moving > some of the PHY functionality here? > > readl_poll_timeout() is nice and avoids the hand-coded timeout loop > the other drivers use. But is there benefit in checking for > XMLH_LINK_UP, or could you simply poll dw_pcie_link_up() like the > others do? If it's sufficient, I'd prefer using dw_pcie_link_up() > by itself because it's a little more generic. OK I will modify the code to use dw_pcie_link_up() and ensure that this check is sufficient. -- regards, Stan
WARNING: multiple messages have this Message-ID (diff)
From: stanimir.varbanov@linaro.org (Stanimir Varbanov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 3/5] PCI: qcom: Add Qualcomm PCIe controller driver Date: Thu, 17 Dec 2015 15:18:43 +0200 [thread overview] Message-ID: <5672B633.6030503@linaro.org> (raw) In-Reply-To: <20151216215304.GB27791@localhost> Bjorn, thanks for the comments! On 12/16/2015 11:53 PM, Bjorn Helgaas wrote: > On Thu, Dec 03, 2015 at 03:35:22PM +0200, Stanimir Varbanov wrote: >> From: Stanimir Varbanov <svarbanov@mm-sol.com> >> >> The PCIe driver reuse the Designware common code for host >> and MSI initialization, and also program the Qualcomm >> application specific registers. >> >> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com> >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> >> --- >> MAINTAINERS | 7 + >> drivers/pci/host/Kconfig | 10 + >> drivers/pci/host/Makefile | 1 + >> drivers/pci/host/pcie-qcom.c | 624 ++++++++++++++++++++++++++++++++++++++++++ > >> +#define PCIE20_CAP 0x70 >> +#define PCIE20_CAP_LINKCTRLSTATUS (PCIE20_CAP + 0x10) >> +#define PCIE20_CAP_LINKCTRLSTATUS_LINK_UP BIT(29) > > This looks like it could be referring to a standard PCIe Capability; > could you use the existing PCI_EXP_LNKSTA and PCI_EXP_LNKSTA_DLLLA > symbols here? And readw() instead of readl()? Yes, that is possible but I still need to keep PCIE20_CAP capabilities offset. > >> +static int qcom_pcie_enable_link_training(struct qcom_pcie *pcie) >> +{ >> + struct device *dev = pcie->dev; >> + u32 val; >> + int ret; >> + >> + /* enable link training */ >> + val = readl(pcie->elbi + PCIE20_ELBI_SYS_CTRL); >> + val |= PCIE20_ELBI_SYS_CTRL_LT_ENABLE; >> + writel(val, pcie->elbi + PCIE20_ELBI_SYS_CTRL); >> + >> + /* wait for up to 100ms for the link to come up */ >> + ret = readl_poll_timeout(pcie->elbi + PCIE20_ELBI_SYS_STTS, val, >> + val & XMLH_LINK_UP, LINKUP_DELAY_US, >> + LINKUP_TIMEOUT_US); >> + >> + if (ret < 0 || !dw_pcie_link_up(&pcie->pp)) { >> + dev_err(dev, "link initialization failed\n"); >> + return -ETIMEDOUT; >> + } >> + >> + return 0; >> +} > > This looks a lot like the *_establish_link() functions in other > DesignWare-based drivers. Can you make it look even more similar, > e.g., by renaming it to qcom_pcie_establish_link() and maybe moving > some of the PHY functionality here? > > readl_poll_timeout() is nice and avoids the hand-coded timeout loop > the other drivers use. But is there benefit in checking for > XMLH_LINK_UP, or could you simply poll dw_pcie_link_up() like the > others do? If it's sufficient, I'd prefer using dw_pcie_link_up() > by itself because it's a little more generic. OK I will modify the code to use dw_pcie_link_up() and ensure that this check is sufficient. -- regards, Stan
next prev parent reply other threads:[~2015-12-17 13:18 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-03 13:35 [PATCH v4 0/5] Qualcomm PCIe driver and designware fixes Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov 2015-12-03 13:35 ` [PATCH v4 1/5] PCI: designware: add memory barrier after enabling region Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov 2015-12-08 9:01 ` Stanimir Varbanov 2015-12-08 9:01 ` Stanimir Varbanov 2015-12-09 4:40 ` Pratyush Anand 2015-12-09 4:40 ` Pratyush Anand 2015-12-09 4:40 ` Pratyush Anand 2015-12-09 9:52 ` Arnd Bergmann 2015-12-09 9:52 ` Arnd Bergmann 2015-12-09 9:52 ` Arnd Bergmann 2015-12-09 10:29 ` Stanimir Varbanov 2015-12-09 10:29 ` Stanimir Varbanov 2015-12-09 10:29 ` Stanimir Varbanov 2015-12-09 10:23 ` Russell King - ARM Linux 2015-12-09 10:23 ` Russell King - ARM Linux 2015-12-09 10:23 ` Russell King - ARM Linux 2015-12-11 4:05 ` Pratyush Anand 2015-12-11 4:05 ` Pratyush Anand 2015-12-11 4:05 ` Pratyush Anand 2015-12-11 5:48 ` Jisheng Zhang 2015-12-11 5:48 ` Jisheng Zhang 2015-12-11 5:48 ` Jisheng Zhang 2015-12-11 5:48 ` Jisheng Zhang 2015-12-22 12:36 ` Jingoo Han 2015-12-22 12:36 ` Jingoo Han 2015-12-22 12:36 ` Jingoo Han 2015-12-17 15:45 ` Stanimir Varbanov 2015-12-17 15:45 ` Stanimir Varbanov 2015-12-17 15:45 ` Stanimir Varbanov 2015-12-17 15:51 ` Pratyush Anand 2015-12-17 15:51 ` Pratyush Anand 2015-12-17 15:51 ` Pratyush Anand 2015-12-03 13:35 ` [PATCH v4 3/5] PCI: qcom: Add Qualcomm PCIe controller driver Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov 2015-12-15 8:24 ` Stanimir Varbanov 2015-12-15 8:24 ` Stanimir Varbanov 2015-12-16 21:17 ` Bjorn Helgaas 2015-12-16 21:17 ` Bjorn Helgaas 2015-12-16 21:53 ` Bjorn Helgaas 2015-12-16 21:53 ` Bjorn Helgaas 2015-12-17 13:18 ` Stanimir Varbanov [this message] 2015-12-17 13:18 ` Stanimir Varbanov 2015-12-17 21:15 ` Bjorn Helgaas 2015-12-17 21:15 ` Bjorn Helgaas [not found] ` <1449149725-27607-1-git-send-email-stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-12-03 13:35 ` [PATCH v4 2/5] DT: PCI: qcom: Document PCIe devicetree bindings Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov 2015-12-03 20:42 ` Rob Herring 2015-12-03 20:42 ` Rob Herring 2015-12-03 13:35 ` [PATCH v4 4/5] ARM: dts: apq8064: add pcie devicetree node Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov 2015-12-03 13:35 ` [PATCH v4 5/5] ARM: dts: ifc6410: enable pcie dt node for this board Stanimir Varbanov 2015-12-03 13:35 ` Stanimir Varbanov [not found] ` <1449149725-27607-6-git-send-email-stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-12-17 21:55 ` Bjorn Andersson 2015-12-17 21:55 ` Bjorn Andersson 2015-12-17 21:55 ` Bjorn Andersson 2015-12-17 21:55 ` Bjorn Andersson 2015-12-18 9:57 ` Stanimir Varbanov 2015-12-18 9:57 ` Stanimir Varbanov 2015-12-18 9:57 ` Stanimir Varbanov 2015-12-07 17:33 ` [PATCH v4 0/5] Qualcomm PCIe driver and designware fixes Srinivas Kandagatla 2015-12-07 17:33 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5672B633.6030503@linaro.org \ --to=stanimir.varbanov@linaro.org \ --cc=arnd@arndb.de \ --cc=bhelgaas@google.com \ --cc=bjorn.andersson@sonymobile.com \ --cc=devicetree@vger.kernel.org \ --cc=helgaas@kernel.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jingoohan1@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=pratyush.anand@gmail.com \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.