* [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
2015-12-18 8:49 ` Aleksei Mamlin
@ 2015-12-18 8:51 ` Aleksei Mamlin
-1 siblings, 0 replies; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:51 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Aleksei Mamlin
Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index 239b5d2..ec3b837 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -102,6 +102,18 @@
pinctrl-names = "default";
pinctrl-0 = <&i2c2_pins_a>;
status = "okay";
+
+ gt911: touchscreen@5d {
+ compatible = "goodix,gt911";
+ reg = <0x5d>;
+ interrupt-parent = <&pio>;
+ interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21 (PH21) */
+ pinctrl-names = "default";
+ pinctrl-0 = <&ts_reset_pin>;
+ irq-gpios = <&pio 7 21 GPIO_ACTIVE_HIGH>; /* INT (PH21) */
+ reset-gpios = <&pio 1 13 GPIO_ACTIVE_HIGH>; /* RST (PB13) */
+ touchscreen-swapped-x-y;
+ };
};
&lradc {
@@ -146,6 +158,13 @@
};
&pio {
+ ts_reset_pin: ts_reset_pin@0 {
+ allwinner,pins = "PB13";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
usb0_id_detect_pin: usb0_id_detect_pin@0 {
allwinner,pins = "PH4";
allwinner,function = "gpio_in";
--
2.4.10
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
@ 2015-12-18 8:51 ` Aleksei Mamlin
0 siblings, 0 replies; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:51 UTC (permalink / raw)
To: linux-arm-kernel
Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index 239b5d2..ec3b837 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -102,6 +102,18 @@
pinctrl-names = "default";
pinctrl-0 = <&i2c2_pins_a>;
status = "okay";
+
+ gt911: touchscreen at 5d {
+ compatible = "goodix,gt911";
+ reg = <0x5d>;
+ interrupt-parent = <&pio>;
+ interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21 (PH21) */
+ pinctrl-names = "default";
+ pinctrl-0 = <&ts_reset_pin>;
+ irq-gpios = <&pio 7 21 GPIO_ACTIVE_HIGH>; /* INT (PH21) */
+ reset-gpios = <&pio 1 13 GPIO_ACTIVE_HIGH>; /* RST (PB13) */
+ touchscreen-swapped-x-y;
+ };
};
&lradc {
@@ -146,6 +158,13 @@
};
&pio {
+ ts_reset_pin: ts_reset_pin at 0 {
+ allwinner,pins = "PB13";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
usb0_id_detect_pin: usb0_id_detect_pin at 0 {
allwinner,pins = "PH4";
allwinner,function = "gpio_in";
--
2.4.10
^ permalink raw reply related [flat|nested] 26+ messages in thread
[parent not found: <1450428710-5653-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
2015-12-18 8:51 ` Aleksei Mamlin
@ 2015-12-18 21:25 ` Maxime Ripard
-1 siblings, 0 replies; 26+ messages in thread
From: Maxime Ripard @ 2015-12-18 21:25 UTC (permalink / raw)
To: Aleksei Mamlin
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
Hi,
On Fri, Dec 18, 2015 at 11:51:50AM +0300, Aleksei Mamlin wrote:
> Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> index 239b5d2..ec3b837 100644
> --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> @@ -102,6 +102,18 @@
> pinctrl-names = "default";
> pinctrl-0 = <&i2c2_pins_a>;
> status = "okay";
> +
> + gt911: touchscreen@5d {
> + compatible = "goodix,gt911";
> + reg = <0x5d>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21 (PH21) */
> + pinctrl-names = "default";
> + pinctrl-0 = <&ts_reset_pin>;
> + irq-gpios = <&pio 7 21 GPIO_ACTIVE_HIGH>; /* INT (PH21) */
It seems odd that you need both irq-gpios and interrupts. These two
are completely redundant, and you should even actually use only one in
your driver, since the second request_irq will fail.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
@ 2015-12-18 21:25 ` Maxime Ripard
0 siblings, 0 replies; 26+ messages in thread
From: Maxime Ripard @ 2015-12-18 21:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Fri, Dec 18, 2015 at 11:51:50AM +0300, Aleksei Mamlin wrote:
> Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> ---
> arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> index 239b5d2..ec3b837 100644
> --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> @@ -102,6 +102,18 @@
> pinctrl-names = "default";
> pinctrl-0 = <&i2c2_pins_a>;
> status = "okay";
> +
> + gt911: touchscreen at 5d {
> + compatible = "goodix,gt911";
> + reg = <0x5d>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21 (PH21) */
> + pinctrl-names = "default";
> + pinctrl-0 = <&ts_reset_pin>;
> + irq-gpios = <&pio 7 21 GPIO_ACTIVE_HIGH>; /* INT (PH21) */
It seems odd that you need both irq-gpios and interrupts. These two
are completely redundant, and you should even actually use only one in
your driver, since the second request_irq will fail.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151218/18d43e8e/attachment.sig>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
2015-12-18 21:25 ` Maxime Ripard
(?)
@ 2015-12-19 15:11 ` Aleksei Mamlin
[not found] ` <CAF==cZWcY=FH9Sr8RY4j4Ob8iuiYrBGkajZDWpNQzS-t4d074Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
-1 siblings, 1 reply; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-19 15:11 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-arm-kernel, devicetree, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]
2015-12-19 0:25 GMT+03:00 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
> Hi,
>
> On Fri, Dec 18, 2015 at 11:51:50AM +0300, Aleksei Mamlin wrote:
> > Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200
> tablet
> >
> > Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > index 239b5d2..ec3b837 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > @@ -102,6 +102,18 @@
> > pinctrl-names = "default";
> > pinctrl-0 = <&i2c2_pins_a>;
> > status = "okay";
> > +
> > + gt911: touchscreen@5d {
> > + compatible = "goodix,gt911";
> > + reg = <0x5d>;
> > + interrupt-parent = <&pio>;
> > + interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21
> (PH21) */
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&ts_reset_pin>;
> > + irq-gpios = <&pio 7 21 GPIO_ACTIVE_HIGH>; /* INT (PH21) */
>
> It seems odd that you need both irq-gpios and interrupts. These two
> are completely redundant, and you should even actually use only one in
> your driver, since the second request_irq will fail.
>
>
We need both interrupts and irq-gpios because the driver uses the interrupt
gpio pin as output to reset the device. See bindings documentation [1]
[1]
https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/tree/Documentation/devicetree/bindings/input/touchscreen/goodix.txt?h=goodix
Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
--
Thanks and regards,
Aleksei Mamlin
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: Type: text/html, Size: 4057 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-sunxi] Re: [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
2015-12-18 21:25 ` Maxime Ripard
(?)
(?)
@ 2015-12-19 15:49 ` Karsten Merker
-1 siblings, 0 replies; 26+ messages in thread
From: Karsten Merker @ 2015-12-19 15:49 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Aleksei Mamlin, linux-arm-kernel, devicetree, dev
On Fri, Dec 18, 2015 at 10:25:25PM +0100, Maxime Ripard wrote:
> On Fri, Dec 18, 2015 at 11:51:50AM +0300, Aleksei Mamlin wrote:
> > Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
> >
> > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> > ---
> > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > index 239b5d2..ec3b837 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > @@ -102,6 +102,18 @@
> > pinctrl-names = "default";
> > pinctrl-0 = <&i2c2_pins_a>;
> > status = "okay";
> > +
> > + gt911: touchscreen@5d {
> > + compatible = "goodix,gt911";
> > + reg = <0x5d>;
> > + interrupt-parent = <&pio>;
> > + interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21 (PH21) */
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&ts_reset_pin>;
> > + irq-gpios = <&pio 7 21 GPIO_ACTIVE_HIGH>; /* INT (PH21) */
>
> It seems odd that you need both irq-gpios and interrupts. These two
> are completely redundant, and you should even actually use only one in
> your driver, since the second request_irq will fail.
Hello,
there is a "specialty" on this type of touchscreen controller -
the irq pin on the GT9xx series of chips has two distinct
functions:
The first is the regular function for signalling interrupts to
the CPU, which is set up with the "interrupts" property.
The second function comes into play when initializing the chip.
Without a special initialization procedure, the chip provides
basic touchscreen functionality, but several advanced functions
are unavailable. To enable those advanced functions, the host
needs to temporarily configure the irq pin as a (host-side)
output and transmit a specific pattern on the reset and irq
lines. This method doesn't work on all systems, so the driver
only attempts to reprogram the irq line on the host side as an
output if it is explicitly declared with the irq-gpios property.
Regards,
Karsten
--
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
2015-12-18 8:51 ` Aleksei Mamlin
@ 2015-12-21 15:44 ` Maxime Ripard
-1 siblings, 0 replies; 26+ messages in thread
From: Maxime Ripard @ 2015-12-21 15:44 UTC (permalink / raw)
To: Aleksei Mamlin
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
On Fri, Dec 18, 2015 at 11:51:50AM +0300, Aleksei Mamlin wrote:
> Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 2/4] ARM: dts: sun7i: Enable PWM controller on Wexler TAB7200 tablet
2015-12-18 8:49 ` Aleksei Mamlin
@ 2015-12-18 8:52 ` Aleksei Mamlin
-1 siblings, 0 replies; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Aleksei Mamlin
Wexler TAB7200 tablet use channel 0 of the PWM controller for backlight dimming
Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index ec3b837..1dc9079 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -173,6 +173,12 @@
};
};
+&pwm {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm0_pins_a>;
+ status = "okay";
+};
+
®_dcdc2 {
regulator-always-on;
regulator-min-microvolt = <1000000>;
--
2.4.10
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 2/4] ARM: dts: sun7i: Enable PWM controller on Wexler TAB7200 tablet
@ 2015-12-18 8:52 ` Aleksei Mamlin
0 siblings, 0 replies; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: linux-arm-kernel
Wexler TAB7200 tablet use channel 0 of the PWM controller for backlight dimming
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index ec3b837..1dc9079 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -173,6 +173,12 @@
};
};
+&pwm {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm0_pins_a>;
+ status = "okay";
+};
+
®_dcdc2 {
regulator-always-on;
regulator-min-microvolt = <1000000>;
--
2.4.10
^ permalink raw reply related [flat|nested] 26+ messages in thread
[parent not found: <1450428728-5695-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 2/4] ARM: dts: sun7i: Enable PWM controller on Wexler TAB7200 tablet
2015-12-18 8:52 ` Aleksei Mamlin
@ 2015-12-18 21:25 ` Maxime Ripard
-1 siblings, 0 replies; 26+ messages in thread
From: Maxime Ripard @ 2015-12-18 21:25 UTC (permalink / raw)
To: Aleksei Mamlin
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Fri, Dec 18, 2015 at 11:52:08AM +0300, Aleksei Mamlin wrote:
> Wexler TAB7200 tablet use channel 0 of the PWM controller for backlight dimming
>
> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 3/4] ARM: dts: sun7i: Add backlight node to Wexler TAB7200 tablet
2015-12-18 8:49 ` Aleksei Mamlin
@ 2015-12-18 8:52 ` Aleksei Mamlin
-1 siblings, 0 replies; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Aleksei Mamlin
Add a backlight for controlling the lcd panel backlight on Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index 1dc9079..f47e5f1 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -48,6 +48,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/pwm/pwm.h>
/ {
model = "Wexler TAB7200";
@@ -57,6 +58,16 @@
serial0 = &uart0;
};
+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>;
+ brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>;
+ default-brightness-level = <8>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&bl_enable_pin>;
+ enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
+ };
+
chosen {
stdout-path = "serial0:115200n8";
};
@@ -158,6 +169,13 @@
};
&pio {
+ bl_enable_pin: bl_enable_pin@0 {
+ allwinner,pins = "PH7";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
ts_reset_pin: ts_reset_pin@0 {
allwinner,pins = "PB13";
allwinner,function = "gpio_out";
--
2.4.10
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 3/4] ARM: dts: sun7i: Add backlight node to Wexler TAB7200 tablet
@ 2015-12-18 8:52 ` Aleksei Mamlin
0 siblings, 0 replies; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: linux-arm-kernel
Add a backlight for controlling the lcd panel backlight on Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index 1dc9079..f47e5f1 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -48,6 +48,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/pwm/pwm.h>
/ {
model = "Wexler TAB7200";
@@ -57,6 +58,16 @@
serial0 = &uart0;
};
+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>;
+ brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>;
+ default-brightness-level = <8>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&bl_enable_pin>;
+ enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
+ };
+
chosen {
stdout-path = "serial0:115200n8";
};
@@ -158,6 +169,13 @@
};
&pio {
+ bl_enable_pin: bl_enable_pin at 0 {
+ allwinner,pins = "PH7";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
ts_reset_pin: ts_reset_pin at 0 {
allwinner,pins = "PB13";
allwinner,function = "gpio_out";
--
2.4.10
^ permalink raw reply related [flat|nested] 26+ messages in thread
[parent not found: <1450428742-5737-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 3/4] ARM: dts: sun7i: Add backlight node to Wexler TAB7200 tablet
2015-12-18 8:52 ` Aleksei Mamlin
@ 2015-12-18 21:27 ` Maxime Ripard
-1 siblings, 0 replies; 26+ messages in thread
From: Maxime Ripard @ 2015-12-18 21:27 UTC (permalink / raw)
To: Aleksei Mamlin
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
On Fri, Dec 18, 2015 at 11:52:22AM +0300, Aleksei Mamlin wrote:
> Add a backlight for controlling the lcd panel backlight on Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
This one doesn't apply (probably because of some dependency on the
first patch).
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 3/4] ARM: dts: sun7i: Add backlight node to Wexler TAB7200 tablet
2015-12-18 8:52 ` Aleksei Mamlin
@ 2015-12-21 15:45 ` Maxime Ripard
-1 siblings, 0 replies; 26+ messages in thread
From: Maxime Ripard @ 2015-12-21 15:45 UTC (permalink / raw)
To: Aleksei Mamlin
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Fri, Dec 18, 2015 at 11:52:22AM +0300, Aleksei Mamlin wrote:
> Add a backlight for controlling the lcd panel backlight on Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 4/4] ARM: dts: sun7i: Add PA gpio pin to Wexler TAB7200 tablet
2015-12-18 8:49 ` Aleksei Mamlin
@ 2015-12-18 8:52 ` Aleksei Mamlin
-1 siblings, 0 replies; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Aleksei Mamlin
Add PA gpio pin for controlling power of two external amplifiers (NS4890) which are used on the Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index f47e5f1..2f6b21a 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -74,6 +74,9 @@
};
&codec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&codec_pa_pin>;
+ allwinner,pa-gpios = <&pio 7 15 GPIO_ACTIVE_HIGH>; /* PH15 */
status = "okay";
};
@@ -176,6 +179,13 @@
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
};
+ codec_pa_pin: codec_pa_pin@0 {
+ allwinner,pins = "PH15";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
ts_reset_pin: ts_reset_pin@0 {
allwinner,pins = "PB13";
allwinner,function = "gpio_out";
--
2.4.10
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 4/4] ARM: dts: sun7i: Add PA gpio pin to Wexler TAB7200 tablet
@ 2015-12-18 8:52 ` Aleksei Mamlin
0 siblings, 0 replies; 26+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: linux-arm-kernel
Add PA gpio pin for controlling power of two external amplifiers (NS4890) which are used on the Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index f47e5f1..2f6b21a 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -74,6 +74,9 @@
};
&codec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&codec_pa_pin>;
+ allwinner,pa-gpios = <&pio 7 15 GPIO_ACTIVE_HIGH>; /* PH15 */
status = "okay";
};
@@ -176,6 +179,13 @@
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
};
+ codec_pa_pin: codec_pa_pin at 0 {
+ allwinner,pins = "PH15";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
ts_reset_pin: ts_reset_pin at 0 {
allwinner,pins = "PB13";
allwinner,function = "gpio_out";
--
2.4.10
^ permalink raw reply related [flat|nested] 26+ messages in thread
[parent not found: <1450428765-5779-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 4/4] ARM: dts: sun7i: Add PA gpio pin to Wexler TAB7200 tablet
2015-12-18 8:52 ` Aleksei Mamlin
@ 2015-12-21 15:45 ` Maxime Ripard
-1 siblings, 0 replies; 26+ messages in thread
From: Maxime Ripard @ 2015-12-21 15:45 UTC (permalink / raw)
To: Aleksei Mamlin
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
On Fri, Dec 18, 2015 at 11:52:45AM +0300, Aleksei Mamlin wrote:
> Add PA gpio pin for controlling power of two external amplifiers (NS4890) which are used on the Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread