From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] pcie_imx: Adjust the return value when imx_pcie_addr_valid() fails
Date: Wed, 6 Jan 2016 18:53:17 -0200 [thread overview]
Message-ID: <1452113598-32409-2-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1452113598-32409-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@nxp.com>
Since commit ff3e077bd2 ("dm: pci: Add a uclass for PCI") the following
error message is seen:
=> pci 0
Scanning PCI devices on bus 0
BusDevFun VendorId DeviceId Device Class Sub-Class
_____________________________________________________________
00.01.00 0x16c3 0xabcd Bridge device 0x04
Cannot read bus configuration: -1
We can avoid this error by using the same approach as done in the
linux kernel PCI designware driver: (drivers/pci/host/pcie-designware.c)
static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where,
int size, u32 *val)
{
struct pcie_port *pp = bus->sysdata;
int ret;
if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0) {
*val = 0xffffffff;
return PCIBIOS_DEVICE_NOT_FOUND;
}
,where PCIBIOS_DEVICE_NOT_FOUND is returned when an invalid address
is given.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/pci/pcie_imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c
index f1e189e..02867e2 100644
--- a/drivers/pci/pcie_imx.c
+++ b/drivers/pci/pcie_imx.c
@@ -381,7 +381,7 @@ static int imx_pcie_read_config(struct pci_controller *hose, pci_dev_t d,
ret = imx_pcie_addr_valid(d);
if (ret) {
*val = 0xffffffff;
- return ret;
+ return PCIBIOS_DEVICE_NOT_FOUND;
}
va_address = get_bus_address(d, where);
--
1.9.1
next prev parent reply other threads:[~2016-01-06 20:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 20:53 [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel Fabio Estevam
2016-01-06 20:53 ` Fabio Estevam [this message]
2016-01-06 20:57 ` [U-Boot] [PATCH 2/3] pcie_imx: Adjust the return value when imx_pcie_addr_valid() fails Marek Vasut
2016-01-06 20:53 ` [U-Boot] [PATCH 3/3] pcie_layerscape: Adjust the return value when ls_pcie_addr_valid() fails Fabio Estevam
2016-01-06 20:58 ` Marek Vasut
2016-01-06 20:57 ` [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel Marek Vasut
2016-01-06 22:55 ` Tom Rini
2016-01-06 22:58 ` Fabio Estevam
2016-01-06 23:10 ` Tom Rini
2016-01-07 2:11 ` Bin Meng
2016-01-07 12:15 ` Fabio Estevam
2016-01-07 12:58 ` Bin Meng
2016-01-07 13:31 ` Fabio Estevam
2016-01-07 16:28 ` Tom Rini
2016-01-07 16:49 ` Fabio Estevam
2016-01-08 0:02 ` Bin Meng
2016-01-08 0:15 ` Fabio Estevam
2016-01-08 0:31 ` Bin Meng
2016-01-08 0:35 ` Marek Vasut
2016-01-08 1:10 ` Bin Meng
2016-01-08 0:46 ` Bin Meng
2016-01-08 0:48 ` Bin Meng
2016-01-08 2:09 ` Fabio Estevam
2016-01-08 2:18 ` Bin Meng
2016-01-08 2:20 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452113598-32409-2-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.