All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel
Date: Thu, 7 Jan 2016 22:15:13 -0200	[thread overview]
Message-ID: <CAOMZO5CCGv64mXgu85aMtUBqCvKUKZfzvQus7KN-vTMZhyipjw@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmU6MTDE=As4UBDNi--CM4UPTU9kARLztP+WMq+Cs8GgBQ@mail.gmail.com>

On Thu, Jan 7, 2016 at 10:02 PM, Bin Meng <bmeng.cn@gmail.com> wrote:

> What new feature would benefit from this? These two PCIe drivers are
> non-DM drivers and DM PCI is not utilizing those error codes, instead
> DM PCI is using U-Boot standard error codes.

but what prevents DM PCI to use the kernel error codes in the future?

Returning PCIBIOS_DEVICE_NOT_FOUND when the config is invalid is a
common pattern in the kernel.

Take a look at these drivers:

drivers/pci/access.c
drivers/pci/host/pci-mvebu.c
drivers/pci/host/pci-xgene.c
drivers/pci/host/pcie-altera.c
drivers/pci/host/pcie-designware.c
drivers/pci/host/pcie-rcar.c
drivers/pci/xen-pcifront.c

I don't see why we can't do the same in U-boot.

Feel free to submit a patch with your proposal and the maintainer can
then decide which one is more adequate for U-boot.

  reply	other threads:[~2016-01-08  0:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 20:53 [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel Fabio Estevam
2016-01-06 20:53 ` [U-Boot] [PATCH 2/3] pcie_imx: Adjust the return value when imx_pcie_addr_valid() fails Fabio Estevam
2016-01-06 20:57   ` Marek Vasut
2016-01-06 20:53 ` [U-Boot] [PATCH 3/3] pcie_layerscape: Adjust the return value when ls_pcie_addr_valid() fails Fabio Estevam
2016-01-06 20:58   ` Marek Vasut
2016-01-06 20:57 ` [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel Marek Vasut
2016-01-06 22:55 ` Tom Rini
2016-01-06 22:58   ` Fabio Estevam
2016-01-06 23:10     ` Tom Rini
2016-01-07  2:11 ` Bin Meng
2016-01-07 12:15   ` Fabio Estevam
2016-01-07 12:58     ` Bin Meng
2016-01-07 13:31       ` Fabio Estevam
2016-01-07 16:28         ` Tom Rini
2016-01-07 16:49           ` Fabio Estevam
2016-01-08  0:02             ` Bin Meng
2016-01-08  0:15               ` Fabio Estevam [this message]
2016-01-08  0:31                 ` Bin Meng
2016-01-08  0:35                   ` Marek Vasut
2016-01-08  1:10                     ` Bin Meng
2016-01-08  0:46         ` Bin Meng
2016-01-08  0:48           ` Bin Meng
2016-01-08  2:09           ` Fabio Estevam
2016-01-08  2:18             ` Bin Meng
2016-01-08  2:20               ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5CCGv64mXgu85aMtUBqCvKUKZfzvQus7KN-vTMZhyipjw@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.