All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel
Date: Thu, 7 Jan 2016 10:11:10 +0800	[thread overview]
Message-ID: <CAEUhbmWijmsSLrzBXRxrCZPKrZcDn6Bw5U6gYW=-xctLqg9-aQ@mail.gmail.com> (raw)
In-Reply-To: <1452113598-32409-1-git-send-email-festevam@gmail.com>

Hi Fabio,

On Thu, Jan 7, 2016 at 4:53 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Add PCI error values definitions from the kernel (include/linux/pci.h).
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  include/pci.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/include/pci.h b/include/pci.h
> index 2adca85..0ff3c6e 100644
> --- a/include/pci.h
> +++ b/include/pci.h
> @@ -451,6 +451,15 @@
>  #define PCI_EXT_CAP_ID_PMUX    0x1A    /* Protocol Multiplexing */
>  #define PCI_EXT_CAP_ID_PASID   0x1B    /* Process Address Space ID */
>
> +/* Error values that may be returned by PCI functions. */
> +#define PCIBIOS_SUCCESSFUL             0x00
> +#define PCIBIOS_FUNC_NOT_SUPPORTED     0x81
> +#define PCIBIOS_BAD_VENDOR_ID          0x83
> +#define PCIBIOS_DEVICE_NOT_FOUND       0x86
> +#define PCIBIOS_BAD_REGISTER_NUMBER    0x87
> +#define PCIBIOS_SET_FAILED             0x88
> +#define PCIBIOS_BUFFER_TOO_SMALL       0x89
> +
>  /* Include the ID list */
>
>  #include <pci_ids.h>
> --

Why should we introduce another set of error values just to fix this
specific PCIe issue? Isn't -EINVAL enough?

Regards,
Bin

  parent reply	other threads:[~2016-01-07  2:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 20:53 [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel Fabio Estevam
2016-01-06 20:53 ` [U-Boot] [PATCH 2/3] pcie_imx: Adjust the return value when imx_pcie_addr_valid() fails Fabio Estevam
2016-01-06 20:57   ` Marek Vasut
2016-01-06 20:53 ` [U-Boot] [PATCH 3/3] pcie_layerscape: Adjust the return value when ls_pcie_addr_valid() fails Fabio Estevam
2016-01-06 20:58   ` Marek Vasut
2016-01-06 20:57 ` [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel Marek Vasut
2016-01-06 22:55 ` Tom Rini
2016-01-06 22:58   ` Fabio Estevam
2016-01-06 23:10     ` Tom Rini
2016-01-07  2:11 ` Bin Meng [this message]
2016-01-07 12:15   ` Fabio Estevam
2016-01-07 12:58     ` Bin Meng
2016-01-07 13:31       ` Fabio Estevam
2016-01-07 16:28         ` Tom Rini
2016-01-07 16:49           ` Fabio Estevam
2016-01-08  0:02             ` Bin Meng
2016-01-08  0:15               ` Fabio Estevam
2016-01-08  0:31                 ` Bin Meng
2016-01-08  0:35                   ` Marek Vasut
2016-01-08  1:10                     ` Bin Meng
2016-01-08  0:46         ` Bin Meng
2016-01-08  0:48           ` Bin Meng
2016-01-08  2:09           ` Fabio Estevam
2016-01-08  2:18             ` Bin Meng
2016-01-08  2:20               ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmWijmsSLrzBXRxrCZPKrZcDn6Bw5U6gYW=-xctLqg9-aQ@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.