From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Shannon Nelson <shannon.nelson@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Mitch Williams <mitch.a.williams@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ixgbe: constify ixgbe_mbx_operations structure
Date: Fri, 08 Jan 2016 00:25:42 -0800 [thread overview]
Message-ID: <1452241542.19358.30.camel@intel.com> (raw)
In-Reply-To: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Sun, 2016-01-03 at 07:55 +0100, Julia Lawall wrote:
> This ixgbe_mbx_operations structure is never modified, so declare it
> as
> const. The other structure of this type is already const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Dropping this patch since Mark has provided a more in-depth patch to
fix the entire driver.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Shannon Nelson <shannon.nelson@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Mitch Williams <mitch.a.williams@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ixgbe: constify ixgbe_mbx_operations structure
Date: Fri, 08 Jan 2016 08:25:42 +0000 [thread overview]
Message-ID: <1452241542.19358.30.camel@intel.com> (raw)
In-Reply-To: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Sun, 2016-01-03 at 07:55 +0100, Julia Lawall wrote:
> This ixgbe_mbx_operations structure is never modified, so declare it
> as
> const. The other structure of this type is already const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Dropping this patch since Mark has provided a more in-depth patch to
fix the entire driver.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: constify ixgbe_mbx_operations structure
Date: Fri, 08 Jan 2016 00:25:42 -0800 [thread overview]
Message-ID: <1452241542.19358.30.camel@intel.com> (raw)
In-Reply-To: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr>
On Sun, 2016-01-03 at 07:55 +0100, Julia Lawall wrote:
> This ixgbe_mbx_operations structure is never modified, so declare it
> as
> const.? The other structure of this type is already const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c? |??? 2 +-
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h? |??? 2 +-
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |??? 2 +-
> ?3 files changed, 3 insertions(+), 3 deletions(-)
Dropping this patch since Mark has provided a more in-depth patch to
fix the entire driver.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160108/ea425693/attachment-0001.asc>
next prev parent reply other threads:[~2016-01-08 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 6:55 [PATCH] ixgbe: constify ixgbe_mbx_operations structure Julia Lawall
2016-01-03 6:55 ` [Intel-wired-lan] " Julia Lawall
2016-01-03 6:55 ` Julia Lawall
2016-01-08 8:25 ` Jeff Kirsher [this message]
2016-01-08 8:25 ` [Intel-wired-lan] " Jeff Kirsher
2016-01-08 8:25 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452241542.19358.30.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=Julia.Lawall@lip6.fr \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.