[PATCH] brcmfmac: advertise frames supported for TX in AP mode

[PATCH] brcmfmac: advertise frames supported for TX in AP mode

[Rafał Miłecki]

Callback mgmt_tx implementation supports both: PROBE_RESP and ACTION.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
This matches code I can see in brcmf_cfg80211_mgmt_tx, hope it makes
sense.
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index ab431e5..8d9cff4 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -5948,6 +5948,10 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
 		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
 		      BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
 	},
+	[NL80211_IFTYPE_AP] = {
+		.tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
+		      BIT(IEEE80211_STYPE_PROBE_RESP >> 4)
+	},
 	[NL80211_IFTYPE_P2P_CLIENT] = {
 		.tx = 0xffff,
 		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
-- 
1.8.4.5

Re: [PATCH] brcmfmac: advertise frames supported for TX in AP mode

[Arend van Spriel]

On 20-1-2016 14:06, Rafał Miłecki wrote:
> Callback mgmt_tx implementation supports both: PROBE_RESP and ACTION.
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> This matches code I can see in brcmf_cfg80211_mgmt_tx, hope it makes
> sense.

As said in another response [1] this function was added for P2P
functionality. Hence I do not feel comfortable adding this patch without
subsequent testing.

Regards,
Arend

[1] http://mid.gmane.org/56A5EFBD.5070400@broadcom.com

> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index ab431e5..8d9cff4 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -5948,6 +5948,10 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
>  		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
>  		      BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
>  	},
> +	[NL80211_IFTYPE_AP] = {
> +		.tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
> +		      BIT(IEEE80211_STYPE_PROBE_RESP >> 4)
> +	},
>  	[NL80211_IFTYPE_P2P_CLIENT] = {
>  		.tx = 0xffff,
>  		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
> 

Re: [PATCH] brcmfmac: advertise frames supported for TX in AP mode

[Julian Calaby]

Hi,

On Mon, Jan 25, 2016 at 8:52 PM, Arend van Spriel <arend@broadcom.com> wrote:
>
>
> On 20-1-2016 14:06, Rafał Miłecki wrote:
>> Callback mgmt_tx implementation supports both: PROBE_RESP and ACTION.
>>
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> ---
>> This matches code I can see in brcmf_cfg80211_mgmt_tx, hope it makes
>> sense.
>
> As said in another response [1] this function was added for P2P
> functionality. Hence I do not feel comfortable adding this patch without
> subsequent testing.

Has anyone tested this yet?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/