From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rob Herring <robh@kernel.org>, Mans Rullgard <mans@mansr.com>
Cc: Viresh Kumar <vireshk@kernel.org>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Vineet Gupta <vgupta@synopsys.com>,
Russell King <linux@arm.linux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/15] dmaengine: dw: revisit data_width property
Date: Wed, 27 Jan 2016 14:26:23 +0200 [thread overview]
Message-ID: <1453897583.2521.246.camel@linux.intel.com> (raw)
In-Reply-To: <20160126210726.GA4096@rob-hp-laptop>
On Tue, 2016-01-26 at 15:07 -0600, Rob Herring wrote:
> On Sun, Jan 24, 2016 at 07:21:54PM +0000, Mans Rullgard wrote:
> > This patch changes the DT binding, so it should probably be amended
> > for
> > compatibility with old device trees. I've included it as is since
> > I think
> > the change as such is good.
>
> Just because you update the dts files, it doesn't make the change
> okay.
> I'm fine with the DT change, but the driver would have to support
> both
> old and new property names.
We will fix this.
> Doesn't really seem worth doing to me.
The big issue with DT, you know, is hanging around names. This moves
name to be de facto standard for similar in the other drivers.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mans Rullgard <mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
Cc: Viresh Kumar <vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Vineet Gupta <vgupta-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 07/15] dmaengine: dw: revisit data_width property
Date: Wed, 27 Jan 2016 14:26:23 +0200 [thread overview]
Message-ID: <1453897583.2521.246.camel@linux.intel.com> (raw)
In-Reply-To: <20160126210726.GA4096@rob-hp-laptop>
On Tue, 2016-01-26 at 15:07 -0600, Rob Herring wrote:
> On Sun, Jan 24, 2016 at 07:21:54PM +0000, Mans Rullgard wrote:
> > This patch changes the DT binding, so it should probably be amended
> > for
> > compatibility with old device trees. I've included it as is since
> > I think
> > the change as such is good.
>
> Just because you update the dts files, it doesn't make the change
> okay.
> I'm fine with the DT change, but the driver would have to support
> both
> old and new property names.
We will fix this.
> Doesn't really seem worth doing to me.
The big issue with DT, you know, is hanging around names. This moves
name to be de facto standard for similar in the other drivers.
--
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 07/15] dmaengine: dw: revisit data_width property
Date: Wed, 27 Jan 2016 14:26:23 +0200 [thread overview]
Message-ID: <1453897583.2521.246.camel@linux.intel.com> (raw)
In-Reply-To: <20160126210726.GA4096@rob-hp-laptop>
On Tue, 2016-01-26@15:07 -0600, Rob Herring wrote:
> On Sun, Jan 24, 2016@07:21:54PM +0000, Mans Rullgard wrote:
> > This patch changes the DT binding, so it should probably be amended
> > for
> > compatibility with old device trees.??I've included it as is since
> > I think
> > the change as such is good.
>
> Just because you update the dts files, it doesn't make the change
> okay.?
> I'm fine with the DT change, but the driver would have to support
> both?
> old and new property names.
We will fix this.
> Doesn't really seem worth doing to me.
The big issue with DT, you know, is hanging around names. This moves
name to be de facto standard for similar in the other drivers.
--
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/15] dmaengine: dw: revisit data_width property
Date: Wed, 27 Jan 2016 14:26:23 +0200 [thread overview]
Message-ID: <1453897583.2521.246.camel@linux.intel.com> (raw)
In-Reply-To: <20160126210726.GA4096@rob-hp-laptop>
On Tue, 2016-01-26 at 15:07 -0600, Rob Herring wrote:
> On Sun, Jan 24, 2016 at 07:21:54PM +0000, Mans Rullgard wrote:
> > This patch changes the DT binding, so it should probably be amended
> > for
> > compatibility with old device trees.??I've included it as is since
> > I think
> > the change as such is good.
>
> Just because you update the dts files, it doesn't make the change
> okay.?
> I'm fine with the DT change, but the driver would have to support
> both?
> old and new property names.
We will fix this.
> Doesn't really seem worth doing to me.
The big issue with DT, you know, is hanging around names. This moves
name to be de facto standard for similar in the other drivers.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-01-27 12:26 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 19:21 [PATCH 00/15] dmaengine: dw: various fixes and cleanups Mans Rullgard
2016-01-24 19:21 ` [PATCH 01/15] dmaengine: dw: fix byte order of hw descriptor fields Mans Rullgard
2016-01-24 19:21 ` [PATCH 02/15] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain Mans Rullgard
[not found] ` <1453663322-14474-1-git-send-email-mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
2016-01-24 19:21 ` [PATCH 03/15] dmaengine: dw: rename masters to reflect actual topology Mans Rullgard
2016-01-24 19:21 ` Mans Rullgard
2016-01-24 19:21 ` Mans Rullgard
2016-01-24 20:09 ` Hans-Christian Noren Egtvedt
2016-01-24 20:09 ` Hans-Christian Noren Egtvedt
[not found] ` <20160124200959.GA15633-BrfabpQBY5qlHtIdYg32fQ@public.gmane.org>
2016-01-24 20:19 ` Måns Rullgård
2016-01-24 20:19 ` Måns Rullgård
2016-01-24 20:19 ` Måns Rullgård
2016-01-24 20:37 ` Hans-Christian Noren Egtvedt
2016-01-24 20:37 ` Hans-Christian Noren Egtvedt
[not found] ` <20160124203720.GA29010-BrfabpQBY5qlHtIdYg32fQ@public.gmane.org>
2016-01-24 20:57 ` Måns Rullgård
2016-01-24 20:57 ` Måns Rullgård
2016-01-24 20:57 ` Måns Rullgård
[not found] ` <1453663322-14474-4-git-send-email-mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
2016-01-24 22:36 ` Mark Brown
2016-01-24 22:36 ` Mark Brown
2016-01-24 22:36 ` Mark Brown
2016-01-24 22:38 ` Måns Rullgård
2016-01-24 22:38 ` Måns Rullgård
[not found] ` <yw1xk2myli0u.fsf-OEaqT8BN2ezZK2NkWkPsZwC/G2K4zDHf@public.gmane.org>
2016-01-25 6:03 ` Viresh Kumar
2016-01-25 6:03 ` Viresh Kumar
2016-01-25 6:03 ` Viresh Kumar
2016-01-25 6:03 ` Viresh Kumar
2016-01-25 12:05 ` Vinod Koul
2016-01-25 12:05 ` Vinod Koul
2016-01-25 12:23 ` Mark Brown
2016-01-25 12:23 ` Mark Brown
2016-01-25 8:35 ` Andy Shevchenko
2016-01-25 8:35 ` Andy Shevchenko
2016-01-25 12:24 ` Mark Brown
2016-01-25 12:24 ` Mark Brown
2016-01-25 14:01 ` Andy Shevchenko
2016-01-25 14:01 ` Andy Shevchenko
2016-01-27 12:47 ` Mark Brown
2016-01-27 12:47 ` Mark Brown
2016-01-24 19:21 ` [PATCH 04/15] dmaengine: dw: set src and dst master select according to xfer direction Mans Rullgard
2016-01-24 19:21 ` [PATCH 05/15] dmaengine: dw: set LMS field in descriptors Mans Rullgard
2016-01-24 19:21 ` [PATCH 06/15] dmaengine: dw: substitute dma_read_byaddr by dma_readl_native Mans Rullgard
2016-01-24 19:21 ` [PATCH 07/15] dmaengine: dw: revisit data_width property Mans Rullgard
2016-01-24 19:21 ` Mans Rullgard
2016-01-24 19:21 ` Mans Rullgard
2016-01-25 7:32 ` Vineet Gupta
2016-01-25 7:32 ` Vineet Gupta
2016-01-25 7:32 ` Vineet Gupta
2016-01-25 7:32 ` Vineet Gupta
2016-01-25 8:45 ` Andy Shevchenko
2016-01-25 8:45 ` Andy Shevchenko
2016-01-25 8:45 ` Andy Shevchenko
2016-01-25 8:45 ` Andy Shevchenko
2016-01-25 10:31 ` Måns Rullgård
2016-01-25 10:31 ` Måns Rullgård
2016-01-25 10:31 ` Måns Rullgård
2016-01-25 10:31 ` Måns Rullgård
2016-01-25 10:36 ` Andy Shevchenko
2016-01-25 10:36 ` Andy Shevchenko
2016-01-25 10:36 ` Andy Shevchenko
2016-01-25 10:36 ` Andy Shevchenko
2016-01-25 8:42 ` Andy Shevchenko
2016-01-25 8:42 ` Andy Shevchenko
2016-01-25 8:42 ` Andy Shevchenko
2016-01-25 8:42 ` Andy Shevchenko
2016-01-26 21:07 ` Rob Herring
2016-01-26 21:07 ` Rob Herring
2016-01-26 21:07 ` Rob Herring
2016-01-26 21:07 ` Rob Herring
2016-01-27 12:26 ` Andy Shevchenko [this message]
2016-01-27 12:26 ` Andy Shevchenko
2016-01-27 12:26 ` Andy Shevchenko
2016-01-27 12:26 ` Andy Shevchenko
2016-01-24 19:21 ` [PATCH 08/15] dmaengine: dw: define counter variables as unsigned int Mans Rullgard
2016-01-24 19:21 ` [PATCH 09/15] dmaengine: dw: keep entire platform data in struct dw_dma Mans Rullgard
2016-01-24 19:21 ` [PATCH 10/15] dmaengine: dw: pass platform data via struct dw_dma_chip Mans Rullgard
2016-01-24 19:21 ` [PATCH 11/15] dmaengine: dw: platform: use field-by-field initialization Mans Rullgard
2016-01-25 8:48 ` Andy Shevchenko
2016-01-24 19:21 ` [PATCH 12/15] dmaengine: dw: move dwc->paused to dwc->flags Mans Rullgard
2016-01-24 19:22 ` [PATCH 13/15] dmaengine: dw: move dwc->initialized " Mans Rullgard
2016-01-24 19:22 ` [PATCH 14/15] dmaengine: dw: move residue to a descriptor Mans Rullgard
2016-01-24 19:22 ` [PATCH 15/15] dmaengine: dw: set cdesc to NULL when free cyclic transfers Mans Rullgard
2016-01-25 10:37 ` [PATCH 00/15] dmaengine: dw: various fixes and cleanups Andy Shevchenko
2016-01-25 12:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453897583.2521.246.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mans@mansr.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=vgupta@synopsys.com \
--cc=vinod.koul@intel.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.