All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 18/23] x86: tnc: Change disable_igd() to have a return value
Date: Mon,  1 Feb 2016 01:40:53 -0800	[thread overview]
Message-ID: <1454319658-17431-19-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1454319658-17431-1-git-send-email-bmeng.cn@gmail.com>

So far disable_igd() does not have any return value, but we may need
that in the future.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/cpu/queensbay/tnc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/x86/cpu/queensbay/tnc.c b/arch/x86/cpu/queensbay/tnc.c
index f9fddc1..8b79505 100644
--- a/arch/x86/cpu/queensbay/tnc.c
+++ b/arch/x86/cpu/queensbay/tnc.c
@@ -14,7 +14,7 @@
 #include <asm/fsp/fsp_support.h>
 #include <asm/processor.h>
 
-static void __maybe_unused disable_igd(void)
+static int __maybe_unused disable_igd(void)
 {
 	/*
 	 * According to Atom E6xx datasheet, setting VGA Disable (bit17)
@@ -36,6 +36,8 @@ static void __maybe_unused disable_igd(void)
 	 */
 	x86_pci_write_config32(TNC_IGD, IGD_FD, FUNC_DISABLE);
 	x86_pci_write_config32(TNC_SDVO, IGD_FD, FUNC_DISABLE);
+
+	return 0;
 }
 
 int arch_cpu_init(void)
@@ -53,9 +55,11 @@ int arch_cpu_init(void)
 
 int arch_early_init_r(void)
 {
+	int ret = 0;
+
 #ifdef CONFIG_DISABLE_IGD
-	disable_igd();
+	ret = disable_igd();
 #endif
 
-	return 0;
+	return ret;
 }
-- 
1.8.2.1

  parent reply	other threads:[~2016-02-01  9:40 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01  9:40 [U-Boot] [PATCH 00/23] x86: Convert to use DM PCI APIs completely Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 01/23] spi: ich: Some clean up Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-02 15:54     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 02/23] spi: ich: Use compatible strings to distinguish controller version Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-02 15:55     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 03/23] spi: ich: Change PCHV_ to ICHV_ Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-02 16:01     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 04/23] x86: tnc: Drop unprotect_spi_flash() Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:32     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 05/23] x86: quark: " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 06/23] dm: pch: Remove pch_get_version op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 07/23] dm: pch: Rename get_sbase op to get_spi_base Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 08/23] dm: pch: Add get_gpio_base op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 09/23] x86: pch: Implement " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 10/23] dm: pch: Add get_io_base op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 11/23] x86: pch9: Implement " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 12/23] x86: ich6_gpio: Convert to use proper DM API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 13/23] x86: Drop asm/arch/gpio.h Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 14/23] x86: minnowmax: Drop io-base property in the pch_pinctrl node Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 15/23] x86: irq: Get irq_router's bdf via dm_pci_get_bdf() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 16/23] x86: irq: Move irq_router to a per driver priv Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 17/23] x86: irq: Convert to use DM PCI API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` Bin Meng [this message]
2016-02-01 16:20   ` [U-Boot] [PATCH 18/23] x86: tnc: Change disable_igd() to have a return value Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 19/23] x86: tnc: Use DM PCI API in disable_igd() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 20/23] x86: tnc: Remove IGD and SDVO devices from driver model Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 21/23] x86: qemu: Convert to use DM PCI API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 22/23] x86: pci: Use DM PCI APIs in pci_assign_irqs() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 23/23] x86: pci: Drop legacy PCI APIs Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01 16:19 ` [U-Boot] [PATCH 00/23] x86: Convert to use DM PCI APIs completely Simon Glass
2016-02-02  2:25   ` Bin Meng
2016-02-02  3:55     ` Simon Glass
2016-02-02  6:34       ` Bin Meng
2016-02-03  3:30         ` Simon Glass
2016-02-03  3:44           ` Bin Meng
2016-02-04  4:01             ` Simon Glass
2016-02-03  3:37   ` Simon Glass
2016-02-03  3:58     ` Bin Meng
2016-02-04  4:02       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454319658-17431-19-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.