All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/23] dm: pch: Rename get_sbase op to get_spi_base
Date: Mon,  1 Feb 2016 01:40:42 -0800	[thread overview]
Message-ID: <1454319658-17431-8-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1454319658-17431-1-git-send-email-bmeng.cn@gmail.com>

Spell out 'sbase' to 'spi_base' so that it looks clearer.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/cpu/ivybridge/bd82x6x.c | 4 ++--
 drivers/pch/pch-uclass.c         | 6 +++---
 drivers/pch/pch7.c               | 4 ++--
 drivers/pch/pch9.c               | 4 ++--
 drivers/spi/ich.c                | 2 +-
 include/pch.h                    | 8 ++++----
 6 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/arch/x86/cpu/ivybridge/bd82x6x.c b/arch/x86/cpu/ivybridge/bd82x6x.c
index 16796de..66a8414 100644
--- a/arch/x86/cpu/ivybridge/bd82x6x.c
+++ b/arch/x86/cpu/ivybridge/bd82x6x.c
@@ -170,7 +170,7 @@ static int bd82x6x_probe(struct udevice *dev)
 	return 0;
 }
 
-static int bd82x6x_pch_get_sbase(struct udevice *dev, ulong *sbasep)
+static int bd82x6x_pch_get_spi_base(struct udevice *dev, ulong *sbasep)
 {
 	u32 rcba;
 
@@ -201,7 +201,7 @@ static int bd82x6x_set_spi_protect(struct udevice *dev, bool protect)
 }
 
 static const struct pch_ops bd82x6x_pch_ops = {
-	.get_sbase	= bd82x6x_pch_get_sbase,
+	.get_spi_base	= bd82x6x_pch_get_spi_base,
 	.set_spi_protect = bd82x6x_set_spi_protect,
 };
 
diff --git a/drivers/pch/pch-uclass.c b/drivers/pch/pch-uclass.c
index cae4f50..b33d502 100644
--- a/drivers/pch/pch-uclass.c
+++ b/drivers/pch/pch-uclass.c
@@ -12,15 +12,15 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-int pch_get_sbase(struct udevice *dev, ulong *sbasep)
+int pch_get_spi_base(struct udevice *dev, ulong *sbasep)
 {
 	struct pch_ops *ops = pch_get_ops(dev);
 
 	*sbasep = 0;
-	if (!ops->get_sbase)
+	if (!ops->get_spi_base)
 		return -ENOSYS;
 
-	return ops->get_sbase(dev, sbasep);
+	return ops->get_spi_base(dev, sbasep);
 }
 
 int pch_set_spi_protect(struct udevice *dev, bool protect)
diff --git a/drivers/pch/pch7.c b/drivers/pch/pch7.c
index 7c6a2ca..fe1fb85 100644
--- a/drivers/pch/pch7.c
+++ b/drivers/pch/pch7.c
@@ -10,7 +10,7 @@
 
 #define BIOS_CTRL	0xd8
 
-static int pch7_get_sbase(struct udevice *dev, ulong *sbasep)
+static int pch7_get_spi_base(struct udevice *dev, ulong *sbasep)
 {
 	u32 rcba;
 
@@ -38,7 +38,7 @@ static int pch7_set_spi_protect(struct udevice *dev, bool protect)
 }
 
 static const struct pch_ops pch7_ops = {
-	.get_sbase	= pch7_get_sbase,
+	.get_spi_base	= pch7_get_spi_base,
 	.set_spi_protect = pch7_set_spi_protect,
 };
 
diff --git a/drivers/pch/pch9.c b/drivers/pch/pch9.c
index 27a9fda..5ac2e8a 100644
--- a/drivers/pch/pch9.c
+++ b/drivers/pch/pch9.c
@@ -10,7 +10,7 @@
 
 #define SBASE_ADDR	0x54
 
-static int pch9_get_sbase(struct udevice *dev, ulong *sbasep)
+static int pch9_get_spi_base(struct udevice *dev, ulong *sbasep)
 {
 	uint32_t sbase_addr;
 
@@ -21,7 +21,7 @@ static int pch9_get_sbase(struct udevice *dev, ulong *sbasep)
 }
 
 static const struct pch_ops pch9_ops = {
-	.get_sbase	= pch9_get_sbase,
+	.get_spi_base	= pch9_get_spi_base,
 };
 
 static const struct udevice_id pch9_ids[] = {
diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c
index 1acdc88..00b2fed 100644
--- a/drivers/spi/ich.c
+++ b/drivers/spi/ich.c
@@ -119,7 +119,7 @@ static int ich_init_controller(struct udevice *dev,
 	void *sbase;
 
 	/* SBASE is similar */
-	pch_get_sbase(dev->parent, &sbase_addr);
+	pch_get_spi_base(dev->parent, &sbase_addr);
 	sbase = (void *)sbase_addr;
 	debug("%s: sbase=%p\n", __func__, sbase);
 
diff --git a/include/pch.h b/include/pch.h
index f3899d8..c04cfa3 100644
--- a/include/pch.h
+++ b/include/pch.h
@@ -15,13 +15,13 @@
 /* Operations for the Platform Controller Hub */
 struct pch_ops {
 	/**
-	 * get_sbase() - get the address of SPI base
+	 * get_spi_base() - get the address of SPI base
 	 *
 	 * @dev:	PCH device to check
 	 * @sbasep:	Returns address of SPI base if available, else 0
 	 * @return 0 if OK, -ve on error (e.g. there is no SPI base)
 	 */
-	int (*get_sbase)(struct udevice *dev, ulong *sbasep);
+	int (*get_spi_base)(struct udevice *dev, ulong *sbasep);
 
 	/**
 	 * set_spi_protect() - set whether SPI flash is protected or not
@@ -37,13 +37,13 @@ struct pch_ops {
 #define pch_get_ops(dev)        ((struct pch_ops *)(dev)->driver->ops)
 
 /**
- * pch_get_sbase() - get the address of SPI base
+ * pch_get_spi_base() - get the address of SPI base
  *
  * @dev:	PCH device to check
  * @sbasep:	Returns address of SPI base if available, else 0
  * @return 0 if OK, -ve on error (e.g. there is no SPI base)
  */
-int pch_get_sbase(struct udevice *dev, ulong *sbasep);
+int pch_get_spi_base(struct udevice *dev, ulong *sbasep);
 
 /**
  * set_spi_protect() - set whether SPI flash is protected or not
-- 
1.8.2.1

  parent reply	other threads:[~2016-02-01  9:40 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01  9:40 [U-Boot] [PATCH 00/23] x86: Convert to use DM PCI APIs completely Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 01/23] spi: ich: Some clean up Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-02 15:54     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 02/23] spi: ich: Use compatible strings to distinguish controller version Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-02 15:55     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 03/23] spi: ich: Change PCHV_ to ICHV_ Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-02 16:01     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 04/23] x86: tnc: Drop unprotect_spi_flash() Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:32     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 05/23] x86: quark: " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 06/23] dm: pch: Remove pch_get_version op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` Bin Meng [this message]
2016-02-01 16:19   ` [U-Boot] [PATCH 07/23] dm: pch: Rename get_sbase op to get_spi_base Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 08/23] dm: pch: Add get_gpio_base op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 09/23] x86: pch: Implement " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 10/23] dm: pch: Add get_io_base op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 11/23] x86: pch9: Implement " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 12/23] x86: ich6_gpio: Convert to use proper DM API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 13/23] x86: Drop asm/arch/gpio.h Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 14/23] x86: minnowmax: Drop io-base property in the pch_pinctrl node Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 15/23] x86: irq: Get irq_router's bdf via dm_pci_get_bdf() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 16/23] x86: irq: Move irq_router to a per driver priv Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 17/23] x86: irq: Convert to use DM PCI API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 18/23] x86: tnc: Change disable_igd() to have a return value Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 19/23] x86: tnc: Use DM PCI API in disable_igd() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 20/23] x86: tnc: Remove IGD and SDVO devices from driver model Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 21/23] x86: qemu: Convert to use DM PCI API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 22/23] x86: pci: Use DM PCI APIs in pci_assign_irqs() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 23/23] x86: pci: Drop legacy PCI APIs Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01 16:19 ` [U-Boot] [PATCH 00/23] x86: Convert to use DM PCI APIs completely Simon Glass
2016-02-02  2:25   ` Bin Meng
2016-02-02  3:55     ` Simon Glass
2016-02-02  6:34       ` Bin Meng
2016-02-03  3:30         ` Simon Glass
2016-02-03  3:44           ` Bin Meng
2016-02-04  4:01             ` Simon Glass
2016-02-03  3:37   ` Simon Glass
2016-02-03  3:58     ` Bin Meng
2016-02-04  4:02       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454319658-17431-8-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.