All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/23] spi: ich: Change PCHV_ to ICHV_
Date: Mon,  1 Feb 2016 01:40:38 -0800	[thread overview]
Message-ID: <1454319658-17431-4-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1454319658-17431-1-git-send-email-bmeng.cn@gmail.com>

The ICH SPI controller supports two variants, one of which is ICH7
compatible and the other is ICH9 compatible. Change 'pch_version'
to 'ich_version' to better match its original name.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/spi/ich.c | 14 +++++++-------
 drivers/spi/ich.h |  7 ++++++-
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c
index b863539..1acdc88 100644
--- a/drivers/spi/ich.c
+++ b/drivers/spi/ich.c
@@ -123,7 +123,7 @@ static int ich_init_controller(struct udevice *dev,
 	sbase = (void *)sbase_addr;
 	debug("%s: sbase=%p\n", __func__, sbase);
 
-	if (plat->ich_version == PCHV_7) {
+	if (plat->ich_version == ICHV_7) {
 		struct ich7_spi_regs *ich7_spi = sbase;
 
 		ich7_spi = (struct ich7_spi_regs *)sbase;
@@ -139,7 +139,7 @@ static int ich_init_controller(struct udevice *dev,
 		ctlr->bbar = offsetof(struct ich7_spi_regs, bbar);
 		ctlr->preop = offsetof(struct ich7_spi_regs, preop);
 		ctlr->base = ich7_spi;
-	} else if (plat->ich_version == PCHV_9) {
+	} else if (plat->ich_version == ICHV_9) {
 		struct ich9_spi_regs *ich9_spi = sbase;
 
 		ctlr->ichspi_lock = readw(&ich9_spi->hsfs) & HSFS_FLOCKDN;
@@ -165,7 +165,7 @@ static int ich_init_controller(struct udevice *dev,
 
 	/* Work out the maximum speed we can support */
 	ctlr->max_speed = 20000000;
-	if (plat->ich_version == PCHV_9 && ich9_can_do_33mhz(dev))
+	if (plat->ich_version == ICHV_9 && ich9_can_do_33mhz(dev))
 		ctlr->max_speed = 33000000;
 	debug("ICH SPI: Version ID %d detected at %p, speed %ld\n",
 	      plat->ich_version, ctlr->base, ctlr->max_speed);
@@ -394,7 +394,7 @@ static int ich_spi_xfer(struct udevice *dev, unsigned int bitlen,
 	if (ret < 0)
 		return ret;
 
-	if (plat->ich_version == PCHV_7)
+	if (plat->ich_version == ICHV_7)
 		ich_writew(ctlr, SPIS_CDS | SPIS_FCERR, ctlr->status);
 	else
 		ich_writeb(ctlr, SPIS_CDS | SPIS_FCERR, ctlr->status);
@@ -649,7 +649,7 @@ static int ich_spi_child_pre_probe(struct udevice *dev)
 	 * ICH 7 SPI controller only supports array read command
 	 * and byte program command for SST flash
 	 */
-	if (plat->ich_version == PCHV_7) {
+	if (plat->ich_version == ICHV_7) {
 		slave->mode_rx = SPI_RX_SLOW;
 		slave->mode = SPI_TX_BYTE;
 	}
@@ -665,12 +665,12 @@ static int ich_spi_ofdata_to_platdata(struct udevice *dev)
 	ret = fdt_node_check_compatible(gd->fdt_blob, dev->of_offset,
 					"intel,ich7-spi");
 	if (ret == 0) {
-		plat->ich_version = PCHV_7;
+		plat->ich_version = ICHV_7;
 	} else {
 		ret = fdt_node_check_compatible(gd->fdt_blob, dev->of_offset,
 						"intel,ich9-spi");
 		if (ret == 0)
-			plat->ich_version = PCHV_9;
+			plat->ich_version = ICHV_9;
 	}
 
 	return ret;
diff --git a/drivers/spi/ich.h b/drivers/spi/ich.h
index 6344e80..bd0a820 100644
--- a/drivers/spi/ich.h
+++ b/drivers/spi/ich.h
@@ -127,8 +127,13 @@ struct spi_trans {
 #define SPI_OPCODE_WREN		0x06
 #define SPI_OPCODE_FAST_READ	0x0b
 
+enum ich_version {
+	ICHV_7,
+	ICHV_9,
+};
+
 struct ich_spi_platdata {
-	enum pch_version ich_version;	/* Controller version, 7 or 9 */
+	enum ich_version ich_version;	/* Controller version, 7 or 9 */
 };
 
 struct ich_spi_priv {
-- 
1.8.2.1

  parent reply	other threads:[~2016-02-01  9:40 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01  9:40 [U-Boot] [PATCH 00/23] x86: Convert to use DM PCI APIs completely Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 01/23] spi: ich: Some clean up Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-02 15:54     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 02/23] spi: ich: Use compatible strings to distinguish controller version Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-02 15:55     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` Bin Meng [this message]
2016-02-01 16:19   ` [U-Boot] [PATCH 03/23] spi: ich: Change PCHV_ to ICHV_ Simon Glass
2016-02-02 16:01     ` Jagan Teki
2016-02-03  4:32       ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 04/23] x86: tnc: Drop unprotect_spi_flash() Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:32     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 05/23] x86: quark: " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 06/23] dm: pch: Remove pch_get_version op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 07/23] dm: pch: Rename get_sbase op to get_spi_base Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 08/23] dm: pch: Add get_gpio_base op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 09/23] x86: pch: Implement " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 10/23] dm: pch: Add get_io_base op Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 11/23] x86: pch9: Implement " Bin Meng
2016-02-01 16:19   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 12/23] x86: ich6_gpio: Convert to use proper DM API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 13/23] x86: Drop asm/arch/gpio.h Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 14/23] x86: minnowmax: Drop io-base property in the pch_pinctrl node Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 15/23] x86: irq: Get irq_router's bdf via dm_pci_get_bdf() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 16/23] x86: irq: Move irq_router to a per driver priv Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 17/23] x86: irq: Convert to use DM PCI API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 18/23] x86: tnc: Change disable_igd() to have a return value Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:33     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 19/23] x86: tnc: Use DM PCI API in disable_igd() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 20/23] x86: tnc: Remove IGD and SDVO devices from driver model Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 21/23] x86: qemu: Convert to use DM PCI API Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 22/23] x86: pci: Use DM PCI APIs in pci_assign_irqs() Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01  9:40 ` [U-Boot] [PATCH 23/23] x86: pci: Drop legacy PCI APIs Bin Meng
2016-02-01 16:20   ` Simon Glass
2016-02-03  4:34     ` Bin Meng
2016-02-01 16:19 ` [U-Boot] [PATCH 00/23] x86: Convert to use DM PCI APIs completely Simon Glass
2016-02-02  2:25   ` Bin Meng
2016-02-02  3:55     ` Simon Glass
2016-02-02  6:34       ` Bin Meng
2016-02-03  3:30         ` Simon Glass
2016-02-03  3:44           ` Bin Meng
2016-02-04  4:01             ` Simon Glass
2016-02-03  3:37   ` Simon Glass
2016-02-03  3:58     ` Bin Meng
2016-02-04  4:02       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454319658-17431-4-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.