All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramalingam C <ramalingam.c@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, Deepak M <m.deepak@intel.com>
Subject: [PATCH 1/2] drm/i915: Using the bpp value wrt the pixel format
Date: Wed,  3 Feb 2016 17:57:35 +0530	[thread overview]
Message-ID: <1454502456-10556-1-git-send-email-ramalingam.c@intel.com> (raw)
In-Reply-To: <8737ta2knw.fsf@intel.com>

From: Deepak M <m.deepak@intel.com>

The bpp value which is used while calulating the txbyteclkhs values
should be wrt the pixel format value. Currently bpp is coming
from pipe config to calculate txbyteclkhs. Fix it in this patch.

Signed-off-by: Deepak M <m.deepak@intel.com>
Signed-off-by: Yogesh Mohan Marimuthu <yogesh.mohan.marimuthu@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
 drivers/gpu/drm/i915/intel_dsi.c           |    5 ++---
 drivers/gpu/drm/i915/intel_dsi.h           |    1 +
 drivers/gpu/drm/i915/intel_dsi_panel_vbt.c |    1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 91cef35..aa11293 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -775,10 +775,9 @@ static void set_dsi_timings(struct drm_encoder *encoder,
 {
 	struct drm_device *dev = encoder->dev;
 	struct drm_i915_private *dev_priv = dev->dev_private;
-	struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
 	struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 	enum port port;
-	unsigned int bpp = intel_crtc->config->pipe_bpp;
+	unsigned int bpp = intel_dsi->dsi_bpp;
 	unsigned int lane_count = intel_dsi->lane_count;
 
 	u16 hactive, hfp, hsync, hbp, vfp, vsync, vbp;
@@ -849,7 +848,7 @@ static void intel_dsi_prepare(struct intel_encoder *intel_encoder)
 	struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 	const struct drm_display_mode *adjusted_mode = &intel_crtc->config->base.adjusted_mode;
 	enum port port;
-	unsigned int bpp = intel_crtc->config->pipe_bpp;
+	unsigned int bpp = intel_dsi->dsi_bpp;
 	u32 val, tmp;
 	u16 mode_hdisplay;
 
diff --git a/drivers/gpu/drm/i915/intel_dsi.h b/drivers/gpu/drm/i915/intel_dsi.h
index de7be7f..9bf6fa1d 100644
--- a/drivers/gpu/drm/i915/intel_dsi.h
+++ b/drivers/gpu/drm/i915/intel_dsi.h
@@ -64,6 +64,7 @@ struct intel_dsi {
 
 	/* video mode pixel format for MIPI_DSI_FUNC_PRG register */
 	u32 pixel_format;
+	u32 dsi_bpp;
 
 	/* video mode format for MIPI_VIDEO_MODE_FORMAT register */
 	u32 video_mode_format;
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index 1d43e6f..bf266cb 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -435,6 +435,7 @@ struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id)
 	intel_dsi->bw_timer = mipi_config->dbi_bw_timer;
 	intel_dsi->video_frmt_cfg_bits =
 		mipi_config->bta_enabled ? DISABLE_VIDEO_BTA : 0;
+	intel_dsi->dsi_bpp = bits_per_pixel;
 
 	pclk = mode->clock;
 
-- 
1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-02-03 12:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 17:54 [PATCH 1/2] drm/i915/BXT: Fixed COS blanking issue Ramalingam C
2016-02-02 17:54 ` [PATCH 2/2] drm/i915/dsi: Add audio reference in dsi encoder Ramalingam C
2016-02-03  1:52   ` Thulasimani, Sivakumar
2016-02-03  8:57   ` Jani Nikula
2016-02-03  9:24     ` Ramalingam C
2016-02-03 10:01       ` Jani Nikula
2016-02-19  9:23         ` Jani Nikula
2016-02-19  9:31           ` Ramalingam C
2016-02-02 18:23 ` [PATCH 1/2] drm/i915/BXT: Fixed COS blanking issue kbuild test robot
2016-02-02 18:38 ` kbuild test robot
2016-02-03  1:49 ` Thulasimani, Sivakumar
2016-02-03 12:20   ` Ramalingam C
2016-02-03  8:02 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2016-02-03  9:44 ` [PATCH 1/2] " Jani Nikula
2016-02-03 12:18   ` Ramalingam C
2016-02-03 12:27   ` Ramalingam C [this message]
2016-02-03 12:27     ` [PATCH 2/2] " Ramalingam C
2016-02-04 13:54       ` Jani Nikula
2016-02-11 14:49         ` Ramalingam C
2016-02-11 14:59           ` [PATCH 2/3 V3] " Ramalingam C
2016-02-19  9:16             ` Jani Nikula
2016-02-04 13:13     ` [PATCH 1/2] drm/i915: Using the bpp value wrt the pixel format Jani Nikula
2016-02-11 15:00       ` Ramalingam C
2016-02-11 15:03         ` [PATCH 1/3 V2] " Ramalingam C
2016-02-11 15:05           ` [PATCH 3/3] drm/i915: Updating the CPU_TRANSCODER for BXT DSI Ramalingam C
2016-02-19  9:07             ` Jani Nikula
2016-02-23 14:31               ` Ramalingam C
2016-02-19  8:50           ` [PATCH 1/3 V2] drm/i915: Using the bpp value wrt the pixel format Jani Nikula
2016-02-19 12:50             ` Mika Kahola
2016-02-19 13:08               ` Jani Nikula
2016-02-15 16:28   ` [PATCH 1/2] drm/i915/BXT: Fixed COS blanking issue Daniel Vetter
2016-02-03 13:12 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Using the bpp value wrt the pixel format (rev2) Patchwork
2016-02-15 16:24 ` [PATCH 1/2] drm/i915/BXT: Fixed COS blanking issue Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454502456-10556-1-git-send-email-ramalingam.c@intel.com \
    --to=ramalingam.c@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=m.deepak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.