From: Laxman Dewangan <ldewangan@nvidia.com> To: <lee.jones@linaro.org>, <alexandre.belloni@free-electrons.com>, <k.kozlowski@samsung.com>, <javier@osg.samsung.com> Cc: <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>, <rtc-linux@googlegroups.com>, Laxman Dewangan <ldewangan@nvidia.com> Subject: [PATCH V3 1/5] rtc: max77686: fix checkpatch error Date: Wed, 3 Feb 2016 19:17:09 +0530 [thread overview] Message-ID: <1454507233-9959-2-git-send-email-ldewangan@nvidia.com> (raw) In-Reply-To: <1454507233-9959-1-git-send-email-ldewangan@nvidia.com> Fix following check patch error in rtc-max77686 driver: - Alignment should match open parenthesis. - braces {} should be used on all arms of this statement. - Prefer using the BIT macro Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> CC: Javier Martinez Canillas <javier@osg.samsung.com> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes from V1: - None, added reviewed/tested by. Changes from V1: - None drivers/rtc/rtc-max77686.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 188593d..253cf12 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -24,20 +24,20 @@ /* RTC Control Register */ #define BCD_EN_SHIFT 0 -#define BCD_EN_MASK (1 << BCD_EN_SHIFT) +#define BCD_EN_MASK BIT(BCD_EN_SHIFT) #define MODEL24_SHIFT 1 -#define MODEL24_MASK (1 << MODEL24_SHIFT) +#define MODEL24_MASK BIT(MODEL24_SHIFT) /* RTC Update Register1 */ #define RTC_UDR_SHIFT 0 -#define RTC_UDR_MASK (1 << RTC_UDR_SHIFT) +#define RTC_UDR_MASK BIT(RTC_UDR_SHIFT) #define RTC_RBUDR_SHIFT 4 -#define RTC_RBUDR_MASK (1 << RTC_RBUDR_SHIFT) +#define RTC_RBUDR_MASK BIT(RTC_RBUDR_SHIFT) /* RTC Hour register */ #define HOUR_PM_SHIFT 6 -#define HOUR_PM_MASK (1 << HOUR_PM_SHIFT) +#define HOUR_PM_MASK BIT(HOUR_PM_SHIFT) /* RTC Alarm Enable */ #define ALARM_ENABLE_SHIFT 7 -#define ALARM_ENABLE_MASK (1 << ALARM_ENABLE_SHIFT) +#define ALARM_ENABLE_MASK BIT(ALARM_ENABLE_SHIFT) #define REG_RTC_NONE 0xdeadbeef @@ -205,9 +205,9 @@ static void max77686_rtc_data_to_tm(u8 *data, struct rtc_time *tm, tm->tm_sec = data[RTC_SEC] & mask; tm->tm_min = data[RTC_MIN] & mask; - if (info->rtc_24hr_mode) + if (info->rtc_24hr_mode) { tm->tm_hour = data[RTC_HOUR] & 0x1f; - else { + } else { tm->tm_hour = data[RTC_HOUR] & 0x0f; if (data[RTC_HOUR] & HOUR_PM_MASK) tm->tm_hour += 12; @@ -256,7 +256,7 @@ static int max77686_rtc_tm_to_data(struct rtc_time *tm, u8 *data, } static int max77686_rtc_update(struct max77686_rtc_info *info, - enum MAX77686_RTC_OP op) + enum MAX77686_RTC_OP op) { int ret; unsigned int data; @@ -547,7 +547,7 @@ out: } static int max77686_rtc_alarm_irq_enable(struct device *dev, - unsigned int enabled) + unsigned int enabled) { struct max77686_rtc_info *info = dev_get_drvdata(dev); int ret; @@ -612,7 +612,7 @@ static int max77686_rtc_probe(struct platform_device *pdev) int ret; info = devm_kzalloc(&pdev->dev, sizeof(struct max77686_rtc_info), - GFP_KERNEL); + GFP_KERNEL); if (!info) return -ENOMEM; @@ -662,7 +662,8 @@ static int max77686_rtc_probe(struct platform_device *pdev) } ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL, - max77686_rtc_alarm_irq, 0, "rtc-alarm1", info); + max77686_rtc_alarm_irq, 0, + "rtc-alarm1", info); if (ret < 0) dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", info->virq, ret); -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com> To: <lee.jones@linaro.org>, <alexandre.belloni@free-electrons.com>, <k.kozlowski@samsung.com>, <javier@osg.samsung.com> Cc: <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>, <rtc-linux@googlegroups.com>, Laxman Dewangan <ldewangan@nvidia.com> Subject: [rtc-linux] [PATCH V3 1/5] rtc: max77686: fix checkpatch error Date: Wed, 3 Feb 2016 19:17:09 +0530 [thread overview] Message-ID: <1454507233-9959-2-git-send-email-ldewangan@nvidia.com> (raw) In-Reply-To: <1454507233-9959-1-git-send-email-ldewangan@nvidia.com> Fix following check patch error in rtc-max77686 driver: - Alignment should match open parenthesis. - braces {} should be used on all arms of this statement. - Prefer using the BIT macro Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> CC: Javier Martinez Canillas <javier@osg.samsung.com> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes from V1: - None, added reviewed/tested by. Changes from V1: - None drivers/rtc/rtc-max77686.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 188593d..253cf12 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -24,20 +24,20 @@ /* RTC Control Register */ #define BCD_EN_SHIFT 0 -#define BCD_EN_MASK (1 << BCD_EN_SHIFT) +#define BCD_EN_MASK BIT(BCD_EN_SHIFT) #define MODEL24_SHIFT 1 -#define MODEL24_MASK (1 << MODEL24_SHIFT) +#define MODEL24_MASK BIT(MODEL24_SHIFT) /* RTC Update Register1 */ #define RTC_UDR_SHIFT 0 -#define RTC_UDR_MASK (1 << RTC_UDR_SHIFT) +#define RTC_UDR_MASK BIT(RTC_UDR_SHIFT) #define RTC_RBUDR_SHIFT 4 -#define RTC_RBUDR_MASK (1 << RTC_RBUDR_SHIFT) +#define RTC_RBUDR_MASK BIT(RTC_RBUDR_SHIFT) /* RTC Hour register */ #define HOUR_PM_SHIFT 6 -#define HOUR_PM_MASK (1 << HOUR_PM_SHIFT) +#define HOUR_PM_MASK BIT(HOUR_PM_SHIFT) /* RTC Alarm Enable */ #define ALARM_ENABLE_SHIFT 7 -#define ALARM_ENABLE_MASK (1 << ALARM_ENABLE_SHIFT) +#define ALARM_ENABLE_MASK BIT(ALARM_ENABLE_SHIFT) #define REG_RTC_NONE 0xdeadbeef @@ -205,9 +205,9 @@ static void max77686_rtc_data_to_tm(u8 *data, struct rtc_time *tm, tm->tm_sec = data[RTC_SEC] & mask; tm->tm_min = data[RTC_MIN] & mask; - if (info->rtc_24hr_mode) + if (info->rtc_24hr_mode) { tm->tm_hour = data[RTC_HOUR] & 0x1f; - else { + } else { tm->tm_hour = data[RTC_HOUR] & 0x0f; if (data[RTC_HOUR] & HOUR_PM_MASK) tm->tm_hour += 12; @@ -256,7 +256,7 @@ static int max77686_rtc_tm_to_data(struct rtc_time *tm, u8 *data, } static int max77686_rtc_update(struct max77686_rtc_info *info, - enum MAX77686_RTC_OP op) + enum MAX77686_RTC_OP op) { int ret; unsigned int data; @@ -547,7 +547,7 @@ out: } static int max77686_rtc_alarm_irq_enable(struct device *dev, - unsigned int enabled) + unsigned int enabled) { struct max77686_rtc_info *info = dev_get_drvdata(dev); int ret; @@ -612,7 +612,7 @@ static int max77686_rtc_probe(struct platform_device *pdev) int ret; info = devm_kzalloc(&pdev->dev, sizeof(struct max77686_rtc_info), - GFP_KERNEL); + GFP_KERNEL); if (!info) return -ENOMEM; @@ -662,7 +662,8 @@ static int max77686_rtc_probe(struct platform_device *pdev) } ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL, - max77686_rtc_alarm_irq, 0, "rtc-alarm1", info); + max77686_rtc_alarm_irq, 0, + "rtc-alarm1", info); if (ret < 0) dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", info->virq, ret); -- 2.1.4 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-02-03 13:58 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-03 13:47 [PATCH V3 0/5] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-03 13:47 ` Laxman Dewangan [this message] 2016-02-03 13:47 ` [rtc-linux] [PATCH V3 1/5] rtc: max77686: fix checkpatch error Laxman Dewangan 2016-02-03 13:47 ` [PATCH V3 2/5] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-03 13:47 ` [PATCH V3 3/5] rtc: max77686: avoid reference of parent device info multiple places Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-03 13:47 ` [PATCH V3 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-03 13:47 ` [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-04 0:10 ` Krzysztof Kozlowski 2016-02-04 0:10 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-04 2:03 ` Laxman Dewangan 2016-02-04 2:03 ` [rtc-linux] " Laxman Dewangan 2016-02-04 2:50 ` Laxman Dewangan 2016-02-04 2:50 ` [rtc-linux] " Laxman Dewangan 2016-02-04 3:04 ` Javier Martinez Canillas 2016-02-04 3:04 ` [rtc-linux] " Javier Martinez Canillas 2016-02-04 16:49 ` Javier Martinez Canillas 2016-02-04 16:49 ` [rtc-linux] " Javier Martinez Canillas 2016-02-04 6:58 ` Krzysztof Kozlowski 2016-02-04 6:58 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-04 9:08 ` Krzysztof Kozlowski 2016-02-04 9:08 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-04 10:13 ` Laxman Dewangan 2016-02-04 10:13 ` [rtc-linux] " Laxman Dewangan 2016-02-04 17:35 ` Javier Martinez Canillas 2016-02-04 17:35 ` [rtc-linux] " Javier Martinez Canillas 2016-02-05 14:37 ` Laxman Dewangan 2016-02-05 14:37 ` [rtc-linux] " Laxman Dewangan 2016-02-06 5:30 ` Javier Martinez Canillas 2016-02-06 5:30 ` [rtc-linux] " Javier Martinez Canillas 2016-02-06 6:29 ` Laxman Dewangan 2016-02-06 6:29 ` [rtc-linux] " Laxman Dewangan 2016-02-06 13:01 ` Javier Martinez Canillas 2016-02-06 13:01 ` [rtc-linux] " Javier Martinez Canillas 2016-02-06 13:40 ` Laxman Dewangan 2016-02-06 13:40 ` [rtc-linux] " Laxman Dewangan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1454507233-9959-2-git-send-email-ldewangan@nvidia.com \ --to=ldewangan@nvidia.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=cw00.choi@samsung.com \ --cc=javier@osg.samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rtc-linux@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.