From: Laxman Dewangan <ldewangan@nvidia.com> To: <lee.jones@linaro.org>, <alexandre.belloni@free-electrons.com>, <k.kozlowski@samsung.com>, <javier@osg.samsung.com> Cc: <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>, <rtc-linux@googlegroups.com>, Laxman Dewangan <ldewangan@nvidia.com> Subject: [PATCH V3 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Date: Wed, 3 Feb 2016 19:17:12 +0530 [thread overview] Message-ID: <1454507233-9959-5-git-send-email-ldewangan@nvidia.com> (raw) In-Reply-To: <1454507233-9959-1-git-send-email-ldewangan@nvidia.com> There is different RTC I2C address for RTC block in MAX77686. Driver is creating dummy i2c client for this address to access the register of this IP block. As there is no call to i2c_get_clientdata() for rtc_i2c client, there is no need to store pointer and hence removing the call to set client data for rtc i2c client. Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> CC: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- This is new in this series based on review comment from V1. Changes from V2: - Rephrase description. - Added reviewed by. drivers/mfd/max77686.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index d959ebb..bda6fd7 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c, "Failed to allocate I2C device for RTC\n"); return -ENODEV; } - i2c_set_clientdata(max77686->rtc, max77686); max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com> To: <lee.jones@linaro.org>, <alexandre.belloni@free-electrons.com>, <k.kozlowski@samsung.com>, <javier@osg.samsung.com> Cc: <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>, <rtc-linux@googlegroups.com>, Laxman Dewangan <ldewangan@nvidia.com> Subject: [rtc-linux] [PATCH V3 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Date: Wed, 3 Feb 2016 19:17:12 +0530 [thread overview] Message-ID: <1454507233-9959-5-git-send-email-ldewangan@nvidia.com> (raw) In-Reply-To: <1454507233-9959-1-git-send-email-ldewangan@nvidia.com> There is different RTC I2C address for RTC block in MAX77686. Driver is creating dummy i2c client for this address to access the register of this IP block. As there is no call to i2c_get_clientdata() for rtc_i2c client, there is no need to store pointer and hence removing the call to set client data for rtc i2c client. Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> CC: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- This is new in this series based on review comment from V1. Changes from V2: - Rephrase description. - Added reviewed by. drivers/mfd/max77686.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index d959ebb..bda6fd7 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c, "Failed to allocate I2C device for RTC\n"); return -ENODEV; } - i2c_set_clientdata(max77686->rtc, max77686); max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, -- 2.1.4 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-02-03 13:58 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-03 13:47 [PATCH V3 0/5] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-03 13:47 ` [PATCH V3 1/5] rtc: max77686: fix checkpatch error Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-03 13:47 ` [PATCH V3 2/5] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-03 13:47 ` [PATCH V3 3/5] rtc: max77686: avoid reference of parent device info multiple places Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-03 13:47 ` Laxman Dewangan [this message] 2016-02-03 13:47 ` [rtc-linux] [PATCH V3 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan 2016-02-03 13:47 ` [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan 2016-02-03 13:47 ` [rtc-linux] " Laxman Dewangan 2016-02-04 0:10 ` Krzysztof Kozlowski 2016-02-04 0:10 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-04 2:03 ` Laxman Dewangan 2016-02-04 2:03 ` [rtc-linux] " Laxman Dewangan 2016-02-04 2:50 ` Laxman Dewangan 2016-02-04 2:50 ` [rtc-linux] " Laxman Dewangan 2016-02-04 3:04 ` Javier Martinez Canillas 2016-02-04 3:04 ` [rtc-linux] " Javier Martinez Canillas 2016-02-04 16:49 ` Javier Martinez Canillas 2016-02-04 16:49 ` [rtc-linux] " Javier Martinez Canillas 2016-02-04 6:58 ` Krzysztof Kozlowski 2016-02-04 6:58 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-04 9:08 ` Krzysztof Kozlowski 2016-02-04 9:08 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-04 10:13 ` Laxman Dewangan 2016-02-04 10:13 ` [rtc-linux] " Laxman Dewangan 2016-02-04 17:35 ` Javier Martinez Canillas 2016-02-04 17:35 ` [rtc-linux] " Javier Martinez Canillas 2016-02-05 14:37 ` Laxman Dewangan 2016-02-05 14:37 ` [rtc-linux] " Laxman Dewangan 2016-02-06 5:30 ` Javier Martinez Canillas 2016-02-06 5:30 ` [rtc-linux] " Javier Martinez Canillas 2016-02-06 6:29 ` Laxman Dewangan 2016-02-06 6:29 ` [rtc-linux] " Laxman Dewangan 2016-02-06 13:01 ` Javier Martinez Canillas 2016-02-06 13:01 ` [rtc-linux] " Javier Martinez Canillas 2016-02-06 13:40 ` Laxman Dewangan 2016-02-06 13:40 ` [rtc-linux] " Laxman Dewangan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1454507233-9959-5-git-send-email-ldewangan@nvidia.com \ --to=ldewangan@nvidia.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=cw00.choi@samsung.com \ --cc=javier@osg.samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rtc-linux@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.