[PATCH] dhcpcd: add recipe for dhcpcd

[PATCH] dhcpcd: add recipe for dhcpcd

[Nate Karstens]

Adds a new recipe for dhcpcd. Modifies the configure script to keep the
host system header files from being used instead of the target system.

Signed-off-by: Nate Karstens <nate.karstens@garmin.com>
---
 .../dhcpcd/dhcpcd-6.9.4/configure.patch               | 12 ++++++++++++
 meta/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb      | 19 +++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 meta/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
 create mode 100644 meta/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb

diff --git a/meta/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch b/meta/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
new file mode 100644
index 0000000..d61b05e
--- /dev/null
+++ b/meta/recipes-connectivity/dhcpcd/dhcpcd-6.9.4/configure.patch
@@ -0,0 +1,12 @@
+--- ./configure
++++ ./configure
+@@ -316,9 +316,6 @@
+ if [ "$STATIC" = yes ]; then
+ 	echo "LDFLAGS+=	-static" >>$CONFIG_MK
+ fi
+-for x in $INCLUDEDIR; do
+-	echo "CPPFLAGS+=	-I$x" >>$CONFIG_MK
+-done
+
+ if [ -z "$DEBUG" -a -f .fslckout ]; then
+ 	printf "Found fossil checkout ... "
diff --git a/meta/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb b/meta/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
new file mode 100644
index 0000000..1c0aff4
--- /dev/null
+++ b/meta/recipes-connectivity/dhcpcd/dhcpcd_6.9.4.bb
@@ -0,0 +1,19 @@
+SECTION = "console/network"
+SUMMARY = "dhcpcd - a DHCP client"
+DESCRIPTION = "dhcpcd runs on your machine and silently configures your computer to work on the attached networks without trouble and mostly without configuration."
+
+HOMEPAGE = "http://roy.marples.name/projects/dhcpcd/"
+
+LICENSE = "BSD-2-Clause"
+LIC_FILES_CHKSUM = "file://dhcpcd.c;endline=26;md5=7daf225c91b8065ecc974fc594b2a7de"
+
+SRC_URI = "http://roy.marples.name/downloads/${BPN}/${BPN}-${PV}.tar.xz \
+           file://configure.patch"
+
+SRC_URI[md5sum] = "02f5043a415cd4b6d089631a0cd95f5b"
+SRC_URI[sha256sum] = "c3f3ff7473ef158a1e71db9aea7424df2c3477ad064e2b542f27948a5abc9ba0"
+
+inherit autotools
+
+B = "${S}"
+EXTRA_OECONF = "--enable-ipv4 --enable-ipv6"
-- 
1.9.1

Re: [PATCH] dhcpcd: add recipe for dhcpcd

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

On 10 December 2015 at 03:36, Nate Karstens <nate.karstens@garmin.com>
wrote:

> Adds a new recipe for dhcpcd. Modifies the configure script to keep the
> host system header files from being used instead of the target system.
>
> Signed-off-by: Nate Karstens <nate.karstens@garmin.com>
>

For new recipes to be added to oe-core there needs to be a good rationale.
It seems that this is very well suited for the meta-networking layer (part
of meta-oe).

Ross

[-- Attachment #2: Type: text/html, Size: 937 bytes --]

Re: [PATCH] dhcpcd: add recipe for dhcpcd

[Karstens, Nate]

[-- Attachment #1: Type: text/plain, Size: 1941 bytes --]

Thanks, Ross. There are currently two DHCP clients included in oe-core. The ISC DHCP client is in the dhcp recipe and udhcpc is included in busybox. There is also a very outdated recipe for dhcpcd in meta-alt-desktop-extras.

Based on this I can see two approaches: 1) locate all DHCP client recipes in the same layer because they all provide the same functionality or 2) include alternatives in other layers (which in this case really just means dhcpcd as the ISC DHCP client and busybox shouldn’t really be considered “alternatives”).

In either case it probably makes sense to remove the old recipe from meta-alt-desktop-extras.

Thoughts?

Nate

From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Tuesday, December 22, 2015 11:04 AM
To: Karstens, Nate <Nate.Karstens@garmin.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] dhcpcd: add recipe for dhcpcd


On 10 December 2015 at 03:36, Nate Karstens <nate.karstens@garmin.com<mailto:nate.karstens@garmin.com>> wrote:
Adds a new recipe for dhcpcd. Modifies the configure script to keep the
host system header files from being used instead of the target system.

Signed-off-by: Nate Karstens <nate.karstens@garmin.com<mailto:nate.karstens@garmin.com>>

For new recipes to be added to oe-core there needs to be a good rationale.  It seems that this is very well suited for the meta-networking layer (part of meta-oe).

Ross

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be confidential and/or legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

[-- Attachment #2: Type: text/html, Size: 5736 bytes --]

Re: [PATCH] dhcpcd: add recipe for dhcpcd

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

On 22 December 2015 at 17:13, Karstens, Nate <Nate.Karstens@garmin.com>
wrote:

> Based on this I can see two approaches: 1) locate all DHCP client recipes
> in the same layer because they all provide the same functionality or 2)
> include alternatives in other layers (which in this case really just means
> dhcpcd as the ISC DHCP client and busybox shouldn’t really be considered
> “alternatives”).
>
>
>
> In either case it probably makes sense to remove the old recipe from
> meta-alt-desktop-extras.
>
>
>

Definitely (2), oe-core needs *something* to provide DHCP functionality but
meta-networking is the obvious fit for an alternative choice.

Ross

[-- Attachment #2: Type: text/html, Size: 1538 bytes --]

Re: [PATCH] dhcpcd: add recipe for dhcpcd

[Karstens, Nate]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

Sounds good. I’ll resubmit to meta-networking. Once that goes through I’ll submit a patch to remove it from meta-alt-desktop-extras.

Thanks,

Nate

From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Tuesday, December 22, 2015 3:20 PM
To: Karstens, Nate <Nate.Karstens@garmin.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] dhcpcd: add recipe for dhcpcd


On 22 December 2015 at 17:13, Karstens, Nate <Nate.Karstens@garmin.com<mailto:Nate.Karstens@garmin.com>> wrote:
Based on this I can see two approaches: 1) locate all DHCP client recipes in the same layer because they all provide the same functionality or 2) include alternatives in other layers (which in this case really just means dhcpcd as the ISC DHCP client and busybox shouldn’t really be considered “alternatives”).

In either case it probably makes sense to remove the old recipe from meta-alt-desktop-extras.


Definitely (2), oe-core needs *something* to provide DHCP functionality but meta-networking is the obvious fit for an alternative choice.

Ross

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be confidential and/or legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.

[-- Attachment #2: Type: text/html, Size: 5556 bytes --]