All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] rtl8139: using CP_TX_OWN for ownership transferring during tx
@ 2016-04-01  2:53 Jason Wang
  2016-04-05  0:54 ` Jason Wang
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2016-04-01  2:53 UTC (permalink / raw)
  To: jasowang, qemu-devel

Through CP_TX_OWN and CP_RX_OWN points to the same bit, we'd better use
CP_TX_OWN for tx descriptor handling.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/net/rtl8139.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
index fee97bf..1e5ec14 100644
--- a/hw/net/rtl8139.c
+++ b/hw/net/rtl8139.c
@@ -2046,7 +2046,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
     }
 
     /* transfer ownership to target */
-    txdw0 &= ~CP_RX_OWN;
+    txdw0 &= ~CP_TX_OWN;
 
     /* reset error indicator bits */
     txdw0 &= ~CP_TX_STATUS_UNF;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] rtl8139: using CP_TX_OWN for ownership transferring during tx
  2016-04-01  2:53 [Qemu-devel] [PATCH] rtl8139: using CP_TX_OWN for ownership transferring during tx Jason Wang
@ 2016-04-05  0:54 ` Jason Wang
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2016-04-05  0:54 UTC (permalink / raw)
  To: qemu-devel



On 04/01/2016 10:53 AM, Jason Wang wrote:
> Through CP_TX_OWN and CP_RX_OWN points to the same bit, we'd better use
> CP_TX_OWN for tx descriptor handling.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  hw/net/rtl8139.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
> index fee97bf..1e5ec14 100644
> --- a/hw/net/rtl8139.c
> +++ b/hw/net/rtl8139.c
> @@ -2046,7 +2046,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
>      }
>  
>      /* transfer ownership to target */
> -    txdw0 &= ~CP_RX_OWN;
> +    txdw0 &= ~CP_TX_OWN;
>  
>      /* reset error indicator bits */
>      txdw0 &= ~CP_TX_STATUS_UNF;

Applied to -net.

Thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-05  0:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-01  2:53 [Qemu-devel] [PATCH] rtl8139: using CP_TX_OWN for ownership transferring during tx Jason Wang
2016-04-05  0:54 ` Jason Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.