From: qiujiang <qiujiang@huawei.com> To: linus.walleij@linaro.org, gnurou@gmail.com Cc: mika.westerberg@linux.intel.com, andy.shevchenko@gmail.com, delicious.quinoa@gmail.com, jamie@jamieiles.com, charles.chenxin@huawei.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linuxarm@huawei.com, qiujiang <qiujiang@huawei.com> Subject: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Date: Wed, 6 Apr 2016 15:07:58 +0800 [thread overview] Message-ID: <1459926480-32966-2-git-send-email-qiujiang@huawei.com> (raw) In-Reply-To: <1459926480-32966-1-git-send-email-qiujiang@huawei.com> This patch removed the name property from dwapb_port_property. The name property is redundant because we can get those info from dwapb_gpio dev and pp->idx property. Signed-off-by: qiujiang <qiujiang@huawei.com> --- drivers/gpio/gpio-dwapb.c | 22 +++++++++------------- drivers/mfd/intel_quark_i2c_gpio.c | 1 - include/linux/platform_data/gpio-dwapb.h | 1 - 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 597de1e..91afec8 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -409,8 +409,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout, NULL, false); if (err) { - dev_err(gpio->dev, "failed to init gpio chip for %s\n", - pp->name); + dev_err(gpio->dev, "failed to init gpio chip\n"); return err; } @@ -429,8 +428,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, err = gpiochip_add_data(&port->gc, port); if (err) - dev_err(gpio->dev, "failed to register gpiochip for %s\n", - pp->name); + dev_err(gpio->dev, "failed to register gpiochip\n"); else port->is_registered = true; @@ -480,15 +478,16 @@ dwapb_gpio_get_pdata_of(struct device *dev) if (of_property_read_u32(port_np, "reg", &pp->idx) || pp->idx >= DWAPB_MAX_PORTS) { - dev_err(dev, "missing/invalid port index for %s\n", - port_np->full_name); + dev_err(dev, + "missing/invalid port index for port%d\n", i); return ERR_PTR(-EINVAL); } if (of_property_read_u32(port_np, "snps,nr-gpios", &pp->ngpio)) { - dev_info(dev, "failed to get number of gpios for %s\n", - port_np->full_name); + dev_info(dev, + "failed to get number of gpios for port%d\n", + i); pp->ngpio = 32; } @@ -499,15 +498,12 @@ dwapb_gpio_get_pdata_of(struct device *dev) if (pp->idx == 0 && of_property_read_bool(port_np, "interrupt-controller")) { pp->irq = irq_of_parse_and_map(port_np, 0); - if (!pp->irq) { - dev_warn(dev, "no irq for bank %s\n", - port_np->full_name); - } + if (!pp->irq) + dev_warn(dev, "no irq for this bank\n"); } pp->irq_shared = false; pp->gpio_base = -1; - pp->name = port_np->full_name; } return pdata; diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c index bdc5e27..a4ef99b 100644 --- a/drivers/mfd/intel_quark_i2c_gpio.c +++ b/drivers/mfd/intel_quark_i2c_gpio.c @@ -220,7 +220,6 @@ static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell) /* Set the properties for portA */ pdata->properties->node = NULL; - pdata->properties->name = "intel-quark-x1000-gpio-portA"; pdata->properties->idx = 0; pdata->properties->ngpio = INTEL_QUARK_MFD_NGPIO; pdata->properties->gpio_base = INTEL_QUARK_MFD_GPIO_BASE; diff --git a/include/linux/platform_data/gpio-dwapb.h b/include/linux/platform_data/gpio-dwapb.h index 28702c8..955b579 100644 --- a/include/linux/platform_data/gpio-dwapb.h +++ b/include/linux/platform_data/gpio-dwapb.h @@ -16,7 +16,6 @@ struct dwapb_port_property { struct device_node *node; - const char *name; unsigned int idx; unsigned int ngpio; unsigned int gpio_base; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: qiujiang <qiujiang@huawei.com> To: <linus.walleij@linaro.org>, <gnurou@gmail.com> Cc: <mika.westerberg@linux.intel.com>, <andy.shevchenko@gmail.com>, <delicious.quinoa@gmail.com>, <jamie@jamieiles.com>, <charles.chenxin@huawei.com>, <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>, <linux-acpi@vger.kernel.org>, <linuxarm@huawei.com>, qiujiang <qiujiang@huawei.com> Subject: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Date: Wed, 6 Apr 2016 15:07:58 +0800 [thread overview] Message-ID: <1459926480-32966-2-git-send-email-qiujiang@huawei.com> (raw) In-Reply-To: <1459926480-32966-1-git-send-email-qiujiang@huawei.com> This patch removed the name property from dwapb_port_property. The name property is redundant because we can get those info from dwapb_gpio dev and pp->idx property. Signed-off-by: qiujiang <qiujiang@huawei.com> --- drivers/gpio/gpio-dwapb.c | 22 +++++++++------------- drivers/mfd/intel_quark_i2c_gpio.c | 1 - include/linux/platform_data/gpio-dwapb.h | 1 - 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 597de1e..91afec8 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -409,8 +409,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout, NULL, false); if (err) { - dev_err(gpio->dev, "failed to init gpio chip for %s\n", - pp->name); + dev_err(gpio->dev, "failed to init gpio chip\n"); return err; } @@ -429,8 +428,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, err = gpiochip_add_data(&port->gc, port); if (err) - dev_err(gpio->dev, "failed to register gpiochip for %s\n", - pp->name); + dev_err(gpio->dev, "failed to register gpiochip\n"); else port->is_registered = true; @@ -480,15 +478,16 @@ dwapb_gpio_get_pdata_of(struct device *dev) if (of_property_read_u32(port_np, "reg", &pp->idx) || pp->idx >= DWAPB_MAX_PORTS) { - dev_err(dev, "missing/invalid port index for %s\n", - port_np->full_name); + dev_err(dev, + "missing/invalid port index for port%d\n", i); return ERR_PTR(-EINVAL); } if (of_property_read_u32(port_np, "snps,nr-gpios", &pp->ngpio)) { - dev_info(dev, "failed to get number of gpios for %s\n", - port_np->full_name); + dev_info(dev, + "failed to get number of gpios for port%d\n", + i); pp->ngpio = 32; } @@ -499,15 +498,12 @@ dwapb_gpio_get_pdata_of(struct device *dev) if (pp->idx == 0 && of_property_read_bool(port_np, "interrupt-controller")) { pp->irq = irq_of_parse_and_map(port_np, 0); - if (!pp->irq) { - dev_warn(dev, "no irq for bank %s\n", - port_np->full_name); - } + if (!pp->irq) + dev_warn(dev, "no irq for this bank\n"); } pp->irq_shared = false; pp->gpio_base = -1; - pp->name = port_np->full_name; } return pdata; diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c index bdc5e27..a4ef99b 100644 --- a/drivers/mfd/intel_quark_i2c_gpio.c +++ b/drivers/mfd/intel_quark_i2c_gpio.c @@ -220,7 +220,6 @@ static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell) /* Set the properties for portA */ pdata->properties->node = NULL; - pdata->properties->name = "intel-quark-x1000-gpio-portA"; pdata->properties->idx = 0; pdata->properties->ngpio = INTEL_QUARK_MFD_NGPIO; pdata->properties->gpio_base = INTEL_QUARK_MFD_GPIO_BASE; diff --git a/include/linux/platform_data/gpio-dwapb.h b/include/linux/platform_data/gpio-dwapb.h index 28702c8..955b579 100644 --- a/include/linux/platform_data/gpio-dwapb.h +++ b/include/linux/platform_data/gpio-dwapb.h @@ -16,7 +16,6 @@ struct dwapb_port_property { struct device_node *node; - const char *name; unsigned int idx; unsigned int ngpio; unsigned int gpio_base; -- 1.9.1
next prev parent reply other threads:[~2016-04-06 6:59 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-06 7:07 [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang 2016-04-06 7:07 ` qiujiang 2016-04-06 7:07 ` qiujiang [this message] 2016-04-06 7:07 ` [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property qiujiang 2016-04-06 12:57 ` Andy Shevchenko 2016-04-07 11:45 ` Jiang Qiu 2016-04-07 11:45 ` Jiang Qiu 2016-04-06 7:07 ` [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode qiujiang 2016-04-06 7:07 ` qiujiang 2016-04-06 13:01 ` Andy Shevchenko 2016-04-07 11:14 ` Jiang Qiu 2016-04-07 11:14 ` Jiang Qiu 2016-04-15 2:29 ` Kefeng Wang 2016-04-15 2:29 ` Kefeng Wang 2016-04-06 7:08 ` [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support qiujiang 2016-04-06 7:08 ` qiujiang 2016-04-08 8:26 ` Linus Walleij 2016-04-08 8:38 ` Mika Westerberg 2016-04-11 12:43 ` Jiang Qiu 2016-04-11 12:43 ` Jiang Qiu 2016-04-12 6:46 ` Mika Westerberg 2016-04-12 6:55 ` Jiang Qiu 2016-04-12 6:55 ` Jiang Qiu 2016-04-15 7:40 ` Linus Walleij 2016-04-15 7:58 ` Jiang Qiu 2016-04-15 7:58 ` Jiang Qiu 2016-04-11 13:00 ` Linus Walleij 2016-04-11 12:33 ` Jiang Qiu 2016-04-11 12:33 ` Jiang Qiu 2016-04-06 13:03 ` [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1459926480-32966-2-git-send-email-qiujiang@huawei.com \ --to=qiujiang@huawei.com \ --cc=andy.shevchenko@gmail.com \ --cc=charles.chenxin@huawei.com \ --cc=delicious.quinoa@gmail.com \ --cc=gnurou@gmail.com \ --cc=jamie@jamieiles.com \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mika.westerberg@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.