From: Jiang Qiu <qiujiang@huawei.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, Alan Tull <delicious.quinoa@gmail.com>, Jamie Iles <jamie@jamieiles.com>, charles.chenxin@huawei.com, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, linuxarm@huawei.com Subject: Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Date: Thu, 7 Apr 2016 19:45:30 +0800 [thread overview] Message-ID: <5706485A.1000802@huawei.com> (raw) In-Reply-To: <CAHp75Vc4OxOtA1jseX+BOP9zRzsV98z4VKiY=rdpLdi7K2umNg@mail.gmail.com> Hi Andy, Thanks for your reply. See my comments inline. Thanks Jiang 在 2016/4/6 20:57, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang <qiujiang@huawei.com> wrote: >> This patch removed the name property from dwapb_port_property. >> The name property is redundant because we can get those info >> from dwapb_gpio dev and pp->idx property. > > Where idx is used in such replacements? Actually, it is not used so far. As Alan mentioned, the only additional info from the pp->name against dev is the port index. I present here to prevent anyone from missing it. If it is inappropriate, I will remove it. > >> --- a/drivers/gpio/gpio-dwapb.c >> +++ b/drivers/gpio/gpio-dwapb.c >> @@ -409,8 +409,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, >> err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout, >> NULL, false); >> if (err) { >> - dev_err(gpio->dev, "failed to init gpio chip for %s\n", >> - pp->name); >> + dev_err(gpio->dev, "failed to init gpio chip\n"); > > Do we have any port index here available (expected value I suppose)? The 3rd parameter 'offs' can be used, I will add it. > >> @@ -429,8 +428,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, >> >> err = gpiochip_add_data(&port->gc, port); >> if (err) >> - dev_err(gpio->dev, "failed to register gpiochip for %s\n", >> - pp->name); >> + dev_err(gpio->dev, "failed to register gpiochip\n"); > > Ditto. > > >> @@ -499,15 +498,12 @@ dwapb_gpio_get_pdata_of(struct device *dev) >> if (pp->idx == 0 && >> of_property_read_bool(port_np, "interrupt-controller")) { >> pp->irq = irq_of_parse_and_map(port_np, 0); >> - if (!pp->irq) { >> - dev_warn(dev, "no irq for bank %s\n", >> - port_np->full_name); >> - } >> + if (!pp->irq) >> + dev_warn(dev, "no irq for this bank\n"); > > pp->idx here? > > dev_warn(dev, "no irq for port%d\n", pp->idx); Here, pp->idx should always be zero, means portA, because only portA can be a interrupt controller as dwapb gpio IP defined. So, I omited it. > >> --- a/drivers/mfd/intel_quark_i2c_gpio.c >> +++ b/drivers/mfd/intel_quark_i2c_gpio.c >> @@ -220,7 +220,6 @@ static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell) >> >> /* Set the properties for portA */ >> pdata->properties->node = NULL; >> - pdata->properties->name = "intel-quark-x1000-gpio-portA"; >> pdata->properties->idx = 0; >> pdata->properties->ngpio = INTEL_QUARK_MFD_NGPIO; >> pdata->properties->gpio_base = INTEL_QUARK_MFD_GPIO_BASE; > > For Quark part: > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Qiu <qiujiang@huawei.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, "Alan Tull" <delicious.quinoa@gmail.com>, Jamie Iles <jamie@jamieiles.com>, <charles.chenxin@huawei.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, <linuxarm@huawei.com> Subject: Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Date: Thu, 7 Apr 2016 19:45:30 +0800 [thread overview] Message-ID: <5706485A.1000802@huawei.com> (raw) In-Reply-To: <CAHp75Vc4OxOtA1jseX+BOP9zRzsV98z4VKiY=rdpLdi7K2umNg@mail.gmail.com> Hi Andy, Thanks for your reply. See my comments inline. Thanks Jiang 在 2016/4/6 20:57, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang <qiujiang@huawei.com> wrote: >> This patch removed the name property from dwapb_port_property. >> The name property is redundant because we can get those info >> from dwapb_gpio dev and pp->idx property. > > Where idx is used in such replacements? Actually, it is not used so far. As Alan mentioned, the only additional info from the pp->name against dev is the port index. I present here to prevent anyone from missing it. If it is inappropriate, I will remove it. > >> --- a/drivers/gpio/gpio-dwapb.c >> +++ b/drivers/gpio/gpio-dwapb.c >> @@ -409,8 +409,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, >> err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout, >> NULL, false); >> if (err) { >> - dev_err(gpio->dev, "failed to init gpio chip for %s\n", >> - pp->name); >> + dev_err(gpio->dev, "failed to init gpio chip\n"); > > Do we have any port index here available (expected value I suppose)? The 3rd parameter 'offs' can be used, I will add it. > >> @@ -429,8 +428,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, >> >> err = gpiochip_add_data(&port->gc, port); >> if (err) >> - dev_err(gpio->dev, "failed to register gpiochip for %s\n", >> - pp->name); >> + dev_err(gpio->dev, "failed to register gpiochip\n"); > > Ditto. > > >> @@ -499,15 +498,12 @@ dwapb_gpio_get_pdata_of(struct device *dev) >> if (pp->idx == 0 && >> of_property_read_bool(port_np, "interrupt-controller")) { >> pp->irq = irq_of_parse_and_map(port_np, 0); >> - if (!pp->irq) { >> - dev_warn(dev, "no irq for bank %s\n", >> - port_np->full_name); >> - } >> + if (!pp->irq) >> + dev_warn(dev, "no irq for this bank\n"); > > pp->idx here? > > dev_warn(dev, "no irq for port%d\n", pp->idx); Here, pp->idx should always be zero, means portA, because only portA can be a interrupt controller as dwapb gpio IP defined. So, I omited it. > >> --- a/drivers/mfd/intel_quark_i2c_gpio.c >> +++ b/drivers/mfd/intel_quark_i2c_gpio.c >> @@ -220,7 +220,6 @@ static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell) >> >> /* Set the properties for portA */ >> pdata->properties->node = NULL; >> - pdata->properties->name = "intel-quark-x1000-gpio-portA"; >> pdata->properties->idx = 0; >> pdata->properties->ngpio = INTEL_QUARK_MFD_NGPIO; >> pdata->properties->gpio_base = INTEL_QUARK_MFD_GPIO_BASE; > > For Quark part: > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> >
next prev parent reply other threads:[~2016-04-07 11:45 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-06 7:07 [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang 2016-04-06 7:07 ` qiujiang 2016-04-06 7:07 ` [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property qiujiang 2016-04-06 7:07 ` qiujiang 2016-04-06 12:57 ` Andy Shevchenko 2016-04-07 11:45 ` Jiang Qiu [this message] 2016-04-07 11:45 ` Jiang Qiu 2016-04-06 7:07 ` [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode qiujiang 2016-04-06 7:07 ` qiujiang 2016-04-06 13:01 ` Andy Shevchenko 2016-04-07 11:14 ` Jiang Qiu 2016-04-07 11:14 ` Jiang Qiu 2016-04-15 2:29 ` Kefeng Wang 2016-04-15 2:29 ` Kefeng Wang 2016-04-06 7:08 ` [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support qiujiang 2016-04-06 7:08 ` qiujiang 2016-04-08 8:26 ` Linus Walleij 2016-04-08 8:38 ` Mika Westerberg 2016-04-11 12:43 ` Jiang Qiu 2016-04-11 12:43 ` Jiang Qiu 2016-04-12 6:46 ` Mika Westerberg 2016-04-12 6:55 ` Jiang Qiu 2016-04-12 6:55 ` Jiang Qiu 2016-04-15 7:40 ` Linus Walleij 2016-04-15 7:58 ` Jiang Qiu 2016-04-15 7:58 ` Jiang Qiu 2016-04-11 13:00 ` Linus Walleij 2016-04-11 12:33 ` Jiang Qiu 2016-04-11 12:33 ` Jiang Qiu 2016-04-06 13:03 ` [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5706485A.1000802@huawei.com \ --to=qiujiang@huawei.com \ --cc=andy.shevchenko@gmail.com \ --cc=charles.chenxin@huawei.com \ --cc=delicious.quinoa@gmail.com \ --cc=gnurou@gmail.com \ --cc=jamie@jamieiles.com \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mika.westerberg@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.