All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/3] drm/i915/shrinker: Only report objects with extra pinned pages as pinned
@ 2016-04-20 11:09 Chris Wilson
  2016-04-20 11:09 ` [PATCH v2 2/3] drm/i915/shrinker: Report "unevictable" pages Chris Wilson
  2016-04-20 11:09 ` [PATCH v2 3/3] drm/i915/shrinker: Only shmemfs objects are backed by swap Chris Wilson
  0 siblings, 2 replies; 6+ messages in thread
From: Chris Wilson @ 2016-04-20 11:09 UTC (permalink / raw)
  To: intel-gfx; +Cc: Akash Goel

When iterating over the bound list, we expect all objects there to have
their pages pinned (by the bound VMA). So only report those objects with
additional pin count on their pages as "pinned". These should be those
objects used for display and hardware access.

Reported-by: Akash Goel <akash.goel@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Akash Goel <akash.goel@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gem_shrinker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
index d46388f25e04..4e4fcfa76b4c 100644
--- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
+++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
@@ -361,7 +361,7 @@ i915_gem_shrinker_oom(struct notifier_block *nb, unsigned long event, void *ptr)
 		if (!obj->base.filp)
 			continue;
 
-		if (obj->pages_pin_count)
+		if (obj->pages_pin_count > num_vma_bound(obj))
 			pinned += obj->base.size;
 		else
 			bound += obj->base.size;
-- 
2.8.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/shrinker: Only report objects with extra pinned pages as pinned
@ 2016-04-20  8:56 Joonas Lahtinen
  2016-04-20 11:04 ` [PATCH v2 1/3] " Chris Wilson
  0 siblings, 1 reply; 6+ messages in thread
From: Joonas Lahtinen @ 2016-04-20  8:56 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: Akash Goel

On ke, 2016-04-20 at 08:43 +0100, Chris Wilson wrote:
> When iterating over the bound list, we expect all objects there to have
> their pages pinned (by the bound VMA). So only add those objects with
> additional pin count on their pages as "pinned". These should be those
> objects used for display and hardware access.
> 
> Reported-by: Akash Goel <akash.goel@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

> Cc: Akash Goel <akash.goel@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_shrinker.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
> index d46388f25e04..4e4fcfa76b4c 100644
> --- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
> +++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
> @@ -361,7 +361,7 @@ i915_gem_shrinker_oom(struct notifier_block *nb, unsigned long event, void *ptr)
>  		if (!obj->base.filp)
>  			continue;
>  
> -		if (obj->pages_pin_count)
> +		if (obj->pages_pin_count > num_vma_bound(obj))
>  			pinned += obj->base.size;
>  		else
>  			bound += obj->base.size;
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-04-20 11:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-20 11:09 [PATCH v2 1/3] drm/i915/shrinker: Only report objects with extra pinned pages as pinned Chris Wilson
2016-04-20 11:09 ` [PATCH v2 2/3] drm/i915/shrinker: Report "unevictable" pages Chris Wilson
2016-04-20 11:51   ` Mika Kuoppala
2016-04-20 11:09 ` [PATCH v2 3/3] drm/i915/shrinker: Only shmemfs objects are backed by swap Chris Wilson
2016-04-20 11:54   ` Mika Kuoppala
  -- strict thread matches above, loose matches on Subject: below --
2016-04-20  8:56 [PATCH] drm/i915/shrinker: Only report objects with extra pinned pages as pinned Joonas Lahtinen
2016-04-20 11:04 ` [PATCH v2 1/3] " Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.